OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 6
Total Committers: 146
Last Commit: 21 Nov
Commits this week: 6
Total Lines of Code (LoC): 7,560,943
Net change in LoC this week: 122

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 3 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 09 Jan
5:17 pm

antoniop

Extend and fix xowiki.create_form_with_form_instance automated test with respect to checkbox behavior

- simple checkboxes (normal and repeated): as we do not specify a value for those, the default should be expected, not the last option

- checkboxes in repeated compound fields: upon triavial re-editing, the values should stay the same

This change exposes a bug in acs::test::xpath::get_form_values

Options
    • -8
    • +56
    /openacs-4/packages/xowiki/tcl/test/xowiki-test-procs.tcl
2:06 pm

antoniop

Handle differences in data-model between oracle and postgres, where oracle uses an additional filename column in the cr_revisions table when a revision points to a file

Many thanks to Josue Cardona for reporting the regression

Options
    • -3
    • +10
    /openacs-4/packages/acs-content-repository/tcl/revision-procs.tcl
Wednesday 20 Dec 2023
2:13 pm

antoniop

Port of downstream modification:

do not restrict the format the user can supply. Sanitize the filename later and complain only if this is made exclusively of invalid characters.

Options
    • -2
    • +12
    /openacs-4/packages/xowiki/tcl/xowiki-www-procs.tcl
12:04 pm

antoniop

get_form_data reform:

when validation fails, revert all changes performed on the object while filling up the form fields.

Rationale: when validation fails, we do not persist the data. The same we should not let unvalidated data sneak into the object, as this may be e.g. displayed on the page or be otherwise used by the system.

Options
    • -1
    • +15
    /openacs-4/packages/xowiki/tcl/xowiki-www-procs.tcl
Sunday 17 Dec 2023
8:28 pm

gustafn

Added support for automatic disconnect when a dynamic cluster node is shut down

When the dynamic cluster configuration has scale for certain

occasions, it makes sense to provide down scaling support when these

occasions are over, which does not rely on the configured cluster

disconnect timeout (ClusterAutodeleteInterval). The new code will send

automatically a disconnect request when a dynamic cluster node is

terminating gracefully.

Depending on the configuration, a new version of NaviServer will be

necessary to reliably execute disconnect requests. Appropriate changes

are in the NaviServer release/4.99 and main branches.

- Bumped version numbers:

* acs-tcl to 5.10.1b4

* acs-admin to 5.10.1b4

Options
    • -3
    • +3
    /openacs-4/packages/acs-admin/acs-admin.info
    • -5
    • +5
    /openacs-4/packages/acs-admin/www/cluster.tcl
    • -2
    • +2
    /openacs-4/packages/acs-tcl/acs-tcl.info
    • -9
    • +19
    /openacs-4/packages/acs-tcl/tcl/cluster-init.tcl
    • -41
    • +75
    /openacs-4/packages/acs-tcl/tcl/cluster-procs.tcl
Thursday 14 Dec 2023
10:57 am

antoniop

Do not retrieve extra_css from query_parameters, as this is vulnerable to injections

Many thanks to Markus Moser

Options
    • -2
    • +4
    /openacs-4/packages/xowiki/tcl/xowiki-www-procs.tcl
Thursday 07 Dec 2023
2:42 pm

antoniop

Provide a specific message key for when messages are not available

Many thanks to Sebastian Scheder

Options
    • -2
    • +2
    /openacs-4/packages/chat/chat.info
    • -0
    • +1
    /openacs-4/packages/chat/catalog/chat.de_DE.ISO-8859-1.xml
    • -0
    • +1
    /openacs-4/packages/chat/catalog/chat.en_US.ISO-8859-1.xml
    • -0
    • +1
    /openacs-4/packages/chat/catalog/chat.it_IT.ISO-8859-1.xml
    • -1
    • +1
    /openacs-4/packages/chat/lib/current-messages.adp
Tuesday 05 Dec 2023
6:14 pm

gustafn

Adding auto-deletion of dynamic cluster nodes and small refactoring

- New kernel parameter "ClusterAutodeleteInterval" to specify, when a

dynamic cluster node is not regarded as temporarily unavailable but

as definitely gone. The default value for this parameter is 2m (2

minutes).

- small refactoring to reduce duplicated logic

- Bumped version numbers:

* acs-kernel to 5.10.1b4

* acs-tcl to 5.10.1b3

* acs-admin to 5.10.1b3

Options
    • -4
    • +4
    /openacs-4/packages/acs-admin/acs-admin.info
    • -13
    • +2
    /openacs-4/packages/acs-admin/www/cluster.tcl
    • -2
    • +3
    /openacs-4/packages/acs-kernel/acs-kernel.info
    • -3
    • +3
    /openacs-4/packages/acs-tcl/acs-tcl.info
    • -0
    • +10
    /openacs-4/packages/acs-tcl/tcl/cluster-init.tcl
    • -10
    • +65
    /openacs-4/packages/acs-tcl/tcl/cluster-procs.tcl
Monday 04 Dec 2023
4:32 pm

gustafn

Small update for cluster support

- Improved visualization of cluster nodes that we lost contact to

- New kernel parameters to reduce hard-coded values and to make purpose more explicit

* new parameter ClusterHeartbeatInterval (default 20s),

was hardcoded before to the new default value

* renamed PreferredLocationRegexp -> ClusterPreferredLocationRegexp

* renamed EnableLoggingP -> ClusterEnableLoggingP

- Bumped version numbers:

* acs-kernel to 5.10.1b3

* acs-tcl to 5.10.1b2

* acs-admin to 5.10.1b2

acs-kernel acs-admin acs-tcl/

Options
    • -3
    • +3
    /openacs-4/packages/acs-admin/acs-admin.info
    • -2
    • +27
    /openacs-4/packages/acs-admin/www/cluster.tcl
    • -4
    • +5
    /openacs-4/packages/acs-kernel/acs-kernel.info
    • -0
    • +24
    /openacs-4/packages/acs-kernel/sql/oracle/upgrade/upgrade-5.10.1b2-5.10.1b3.sql
    • -0
    • +24
    /openacs-4/packages/acs-kernel/sql/postgresql/upgrade/upgrade-5.10.1b2-5.10.1b3.sql
    • -3
    • +3
    /openacs-4/packages/acs-tcl/acs-tcl.info
    • -4
    • +9
    /openacs-4/packages/acs-tcl/tcl/cluster-init.tcl
    • -2
    • +9
    /openacs-4/packages/acs-tcl/tcl/cluster-procs.tcl
4:32 pm

gustafn

file upgrade-5.10.1b2-5.10.1b3.sql was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/acs-kernel/sql/oracle/upgrade/upgrade-5.10.1b2-5.10.1b3.sql
    • -0
    • +0
    /openacs-4/packages/acs-kernel/sql/postgresql/upgrade/upgrade-5.10.1b2-5.10.1b3.sql
3:19 pm

antoniop

template::widget::merge_tag_attributes has to be public already, as it is used by template::widget::select_locales

Options
    • -3
    • +3
    /openacs-4/packages/acs-templating/tcl/widget-procs.tcl
Saturday 02 Dec 2023
12:10 pm

gustafn

Avoid duplicate entries in acs_sc_msg_type_elements

-- The three columns msg_type_id, element_name, and

-- element_msg_type_id identify the paramter uniquely, and must be

-- therefore not null.

Bump version number to 5.10.1b2

Options
    • -2
    • +2
    /openacs-4/packages/acs-service-contract/acs-service-contract.info
    • -4
    • +8
    /openacs-4/packages/acs-service-contract/sql/oracle/acs-sc-msg-types-create.sql
    • -0
    • +19
    /openacs-4/packages/acs-service-contract/sql/oracle/upgrade/upgrade-5.10.1b1-5.10.1b2.sql
    • -7
    • +7
    /openacs-4/packages/acs-service-contract/sql/postgresql/acs-sc-msg-types-create.sql
    • -0
    • +13
    /openacs-4/packages/acs-service-contract/sql/postgresql/upgrade/upgrade-5.10.1b1-5.10.1b2.sql
12:10 pm

gustafn

file upgrade-5.10.1b1-5.10.1b2.sql was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/acs-service-contract/sql/oracle/upgrade/upgrade-5.10.1b1-5.10.1b2.sql
    • -0
    • +0
    /openacs-4/packages/acs-service-contract/sql/postgresql/upgrade/upgrade-5.10.1b1-5.10.1b2.sql
Friday 01 Dec 2023
11:33 am

gustafn

improved spelling

Options
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/security-procs.tcl
11:32 am

gustafn

provide the version directory instead of the version on the admin page

Earlier versions had just the version, but not the version directory, which is

the precise information

CVS: ----------------------------------------------------------------------

Options
    • -4
    • +4
    /openacs-4/packages/acs-tcl/lib/check-installed.tcl
10:57 am

gustafn

don't trust in stability of version numbers, but check, what we have actually got.

The structure of the distributed zip file unfortunately a moving target.

Options
    • -17
    • +18
    /openacs-4/packages/bootstrap-icons/tcl/resource-init.tcl
9:57 am

gustafn

fixed the path confusion in packaged bootstrap icons files

Unfortunately, the structure of the distributed .zip file of bootrap icons is

version dependent: Versions greater or equal to 1.10.4 and less

than 1.11.0 require a "font" in the path. Also 1.11.2 requires this, but not 1.11.1.

Options
    • -19
    • +15
    /openacs-4/packages/bootstrap-icons/tcl/resource-init.tcl
9:50 am

antoniop

Fix logic to retrieve the Boostrap Icons CSS path:

the situation is even more slippery than thought, as it seems the new "font" path was discontinued for versions 1.11.0 and 1.11.1, then reintroduced in version 1.11.2. We can only speculate what logic will follow the next version, so for now we assume the new path will stay and just skip the two outlier versions.

Options
    • -4
    • +7
    /openacs-4/packages/bootstrap-icons/tcl/resource-init.tcl
9:02 am

antoniop

Update comment

Options
    • -1
    • +1
    /openacs-4/packages/bootstrap-icons/tcl/resource-init.tcl
Thursday 30 Nov 2023
7:07 pm

gustafn

avoid double quoting

Options
    • -2
    • +2
    /openacs-4/packages/xotcl-core/tcl/context-procs.tcl
4:21 pm

antoniop

Fix typo

Options
    • -2
    • +2
    /openacs-4/packages/acs-templating/tcl/widget-procs.tcl
4:13 pm

antoniop

Form widget attributes reform:

- consolidate the logics to merge tag attributes coming from the adp and the tcl definitions of widgets into a private api

- change the previous behavior of having attributes coming from the adp (aka the tag_attributes argument) take over attributes coming from the element

See https://openacs.org/forums/message-view?message_id=5799349

Options
    • -5
    • +4
    /openacs-4/packages/acs-lang/tcl/lang-widget-procs.tcl
    • -26
    • +7
    /openacs-4/packages/acs-templating/tcl/date-procs.tcl
    • -8
    • +8
    /openacs-4/packages/acs-templating/tcl/form-procs.tcl
    • -6
    • +3
    /openacs-4/packages/acs-templating/tcl/richtext-or-file-procs.tcl
    • -5
    • +2
    /openacs-4/packages/acs-templating/tcl/richtext-procs.tcl
    • -5
    • +2
    /openacs-4/packages/acs-templating/tcl/tab-procs.tcl
    • -47
    • +47
    /openacs-4/packages/acs-templating/tcl/widget-procs.tcl
3:14 pm

antoniop

Revert in order to provide a meaningful log message

Options
    • -35
    • +12
    /openacs-4/packages/acs-templating/tcl/widget-procs.tcl
3:13 pm

antoniop

*** empty log message ***

Options
    • -13
    • +36
    /openacs-4/packages/acs-templating/tcl/widget-procs.tcl
11:40 am

antoniop

Cut-off version for the added font folder seems to be 1.11.1, newer versions seem to now provide a minified css

Options
    • -7
    • +12
    /openacs-4/packages/bootstrap-icons/tcl/resource-init.tcl
Wednesday 29 Nov 2023
8:44 pm

gustafn

cluster setup: use qualified location as well for the local host

Options
    • -6
    • +7
    /openacs-4/packages/acs-tcl/tcl/cluster-procs.tcl
4:28 pm

gustafn

improved spelling

Options
    • -3
    • +3
    /openacs-4/packages/xowf/lib/inclass-quiz-answer.wf
2:44 pm

gustafn

reduced verbosity

Options
    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/package-procs.tcl
10:00 am

antoniop

Do not enforce that pictures are always different on desktop screens, as they may be still for longer than the average picture interval

Options
    • -1
    • +8
    /openacs-4/packages/proctoring-support/www/resources/proctoring.js
9:16 am

antoniop

Add type=oneof to Serializer exportMethods

Many thanks to Sebastian Scheder and Günter Ernst

Options
    • -0
    • +1
    /openacs-4/packages/xotcl-core/tcl/01-debug-procs.tcl