OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 6
Total Committers: 146
Last Commit: 21 Nov
Commits this week: 6
Total Lines of Code (LoC): 7,560,943
Net change in LoC this week: 122

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 9 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 12 Oct 2023
12:43 pm

antoniop

Flushing the cache completely is actually the right thing to do if we want to be more robust to cache pollution: see e.g. executing acs-authentication and acs-tcl automated tests during the same request

Options
    • -3
    • +3
    /openacs-4/packages/acs-tcl/tcl/parameter-procs.tcl
12:25 pm

antoniop

For consistency with other apis, cache the updated parameter value immediately and return it

Options
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/parameter-procs.tcl
Wednesday 11 Oct 2023
6:58 pm

antoniop

Don't pollute the cache for other tests

Fixes acs-tcl.parameter__check_procs test when run after this one

Options
    • -0
    • +12
    /openacs-4/packages/acs-authentication/tcl/test/authentication-procs.tcl
3:55 pm

antoniop

Flush the cache only

this will behave as before, because specifying -delete will supersede all other flags and -set would not be applied.

Options
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/parameter-procs.tcl
3:53 pm

antoniop

Improve test for singleton package parameters (aka instance parameters of singleton packages):

- do not choose a parameter at random, test them all instead

- do not test for global parameters. For those, the api will behave differently

- do not test for parameters coming from the configuration file. The parameter::* api does not allow to manipulate those

- do not check for packages that are not mounted. A value would not be found for those

Options
    • -45
    • +73
    /openacs-4/packages/acs-tcl/tcl/test/apm-parameter-test-procs.tcl
3:06 pm

gustafn

fix for versions-dependencis of the distributed .zip file of bootstrap icons

Unfortunately, the structure of the distributed .zip file is version dependent.

Versions greater or equal to 1.10.4 and less than 1.11.0 require a "font" in the path.

Options
    • -2
    • +10
    /openacs-4/packages/bootstrap-icons/tcl/resource-init.tcl
2:03 pm

gustafn

strengthen boolean variables in page contracts

Options
    • -15
    • +13
    /openacs-4/packages/faq/www/admin/q-and-a-new-2.tcl
    • -2
    • +2
    /openacs-4/packages/forums/www/admin/subscribe-others-2.tcl
    • -2
    • +2
    /openacs-4/packages/forums/www/admin/subscribe-others.tcl
    • -2
    • +2
    /openacs-4/packages/forums/www/moderate/message-delete.tcl
    • -1
    • +1
    /openacs-4/packages/forums/www/moderate/message-move.tcl
    • -1
    • +1
    /openacs-4/packages/forums/www/moderate/move-thread-thread.tcl
    • -1
    • +1
    /openacs-4/packages/forums/www/moderate/move-thread.tcl
    • -1
    • +1
    /openacs-4/packages/forums/www/moderate/move.tcl
    • -1
    • +1
    /openacs-4/packages/forums/www/moderate/thread-move-thread.tcl
    • -1
    • +1
    /openacs-4/packages/forums/www/moderate/thread-move.tcl
    • -2
    • +2
    /openacs-4/packages/general-comments/www/comment-add-3.tcl
    • -3
    • +2
    /openacs-4/packages/news/www/preview.tcl
    • -2
    • +2
    /openacs-4/packages/news/www/admin/approve-2.tcl
Friday 06 Oct 2023
2:31 pm

gustafn

harden page contracts

Options
    • -1
    • +1
    /openacs-4/packages/acs-admin/www/auth/batch-job.tcl
    • -2
    • +2
    /openacs-4/packages/acs-api-browser/www/package-view.tcl
    • -2
    • +2
    /openacs-4/packages/acs-api-browser/www/procs-file-view.tcl
    • -2
    • +2
    /openacs-4/packages/acs-automated-testing/www/admin/clear.tcl
    • -5
    • +5
    /openacs-4/packages/acs-automated-testing/www/admin/index.tcl
    • -4
    • +4
    /openacs-4/packages/acs-automated-testing/www/admin/rerun.tcl
    • -3
    • +3
    /openacs-4/packages/acs-automated-testing/www/admin/testcase.tcl
    • -2
    • +2
    /openacs-4/packages/acs-content-repository/www/admin/mime-types/index.tcl
    • -5
    • +3
    /openacs-4/packages/acs-developer-support/www/request-info.tcl
    • -2
    • +2
    /openacs-4/packages/acs-developer-support/www/set.tcl
    • -2
    • +2
    /openacs-4/packages/acs-lang/www/admin/edit-localized-message.tcl
    • -11
    • +3
    /openacs-4/packages/acs-lang/www/admin/locale-delete.tcl
    • -1
    • +1
    /openacs-4/packages/acs-lang/www/admin/locale-set-enabled-p.tcl
    • -5
    • +3
    /openacs-4/packages/acs-lang/www/admin/message-delete.tcl
    • -4
    • +2
    /openacs-4/packages/acs-lang/www/admin/message-undelete.tcl
  16. … 10 more files in changeset.
2:09 pm

gustafn

harden page contracts

Options
    • -2
    • +2
    /openacs-4/packages/acs-admin/www/send-email.tcl
    • -5
    • +5
    /openacs-4/packages/acs-admin/www/apm/index.tcl
    • -9
    • +9
    /openacs-4/packages/acs-admin/www/apm/package-add-2.tcl
    • -3
    • +3
    /openacs-4/packages/acs-admin/www/apm/package-delete-2.tcl
    • -2
    • +2
    /openacs-4/packages/acs-admin/www/apm/package-load-2.tcl
    • -2
    • +2
    /openacs-4/packages/acs-admin/www/apm/packages-install-2.tcl
    • -3
    • +3
    /openacs-4/packages/acs-admin/www/apm/packages-install.tcl
    • -2
    • +2
    /openacs-4/packages/acs-admin/www/apm/version-edit-2.tcl
    • -2
    • +2
    /openacs-4/packages/acs-admin/www/apm/version-generate-info.tcl
    • -3
    • +3
    /openacs-4/packages/acs-admin/www/apm/version-i18n-process-2.tcl
    • -5
    • +5
    /openacs-4/packages/acs-admin/www/apm/version-i18n.tcl
    • -1
    • +1
    /openacs-4/packages/acs-admin/www/auth/authority-set-enabled-p.tcl
    • -1
    • +1
    /openacs-4/packages/acs-admin/www/auth/batch-job.tcl
    • -1
    • +1
    /openacs-4/packages/acs-admin/www/install/install-4.tcl
    • -1
    • +1
    /openacs-4/packages/acs-admin/www/install/install.tcl
  16. … 8 more files in changeset.
11:07 am

gustafn

protect query-parameters against exceptions with empty values

The page_conract filter require a "notnull", otherwise it lets

values like ...?v=&... through, although {v:boolean} was used.

These empty values will cause exceptions, when it is later

assumed that "v" has a proper boolean value.

Options
    • -2
    • +2
    /openacs-4/packages/xotcl-request-monitor/www/index.tcl
    • -2
    • +2
    /openacs-4/packages/xotcl-request-monitor/www/last-requests.tcl
    • -4
    • +4
    /openacs-4/packages/xotcl-request-monitor/www/long-calls.tcl
    • -4
    • +4
    /openacs-4/packages/xotcl-request-monitor/www/stat-details.tcl
    • -2
    • +2
    /openacs-4/packages/xotcl-request-monitor/www/whos-online-today.tcl
    • -2
    • +2
    /openacs-4/packages/xotcl-request-monitor/www/whos-online.tcl
Thursday 05 Oct 2023
5:52 pm

gustafn

added standard parameterizations for Argon2 when supported.

Options
    • -1
    • +1
    /openacs-4/packages/acs-kernel/acs-kernel.info
    • -0
    • +1
    /openacs-4/packages/acs-tcl/tcl/00-icanuse-procs.tcl
    • -1
    • +52
    /openacs-4/packages/acs-tcl/tcl/security-procs.tcl
Wednesday 04 Oct 2023
3:22 pm

antoniop

Quote URLs rendered inside of markup

Options
    • -11
    • +11
    /openacs-4/packages/xowf/lib/inclass-exam.wf
    • -9
    • +9
    /openacs-4/packages/xowf/tcl/test-item-procs.tcl
Tuesday 03 Oct 2023
4:48 pm

antoniop

Fix idiom: the value should be null to not be counted

Options
    • -4
    • +4
    /openacs-4/packages/proctoring-support/lib/proctoring-display.tcl
4:37 pm

antoniop

Provide the id directly to the subquery to improve planning and execution, use quicker json idioms to count review outcomes

Options
    • -12
    • +6
    /openacs-4/packages/proctoring-support/lib/proctoring-display.tcl
4:07 pm

antoniop

Make values optional, as the user should supply them via the form

Options
    • -3
    • +3
    /openacs-4/packages/file-storage/www/simple-add.tcl
Monday 02 Oct 2023
12:06 pm

gustafn

bugfix: provide proper encoding for text phrases in email addresses

Previously, mails to addresses of the form

PHRASE <USER@HOST>

where PHRASE contains UTF-8 were sent without the required encoding.

One many systems, this was perfectly fine, but on some, these

where leading to mangled characters. Now, the "to_addr" adresseses

and the "from_addr" address of acs_mail_lite::send_immediately

are properly encoded. Note, that "to_addr" is a list of addresses.

Many thanks to Franz Penz for reporting this.

Options
    • -2
    • +15
    /openacs-4/packages/acs-mail-lite/tcl/acs-mail-lite-procs.tcl
Wednesday 27 Sep 2023
4:53 pm

antoniop

Prefer the test authority: downstream local authorities may depend on other systems to perform additional checks, which may fail on a test user

Options
    • -6
    • +8
    /openacs-4/packages/acs-authentication/tcl/test/sync-test-procs.tcl
3:29 pm

antoniop

Export catalog via the UI to normalize sorting and quoting

Options
    • -2
    • +2
    /openacs-4/packages/xowiki/xowiki.info
    • -33
    • +30
    /openacs-4/packages/xowiki/catalog/xowiki.de_DE.ISO-8859-1.xml
    • -38
    • +35
    /openacs-4/packages/xowiki/catalog/xowiki.en_US.ISO-8859-1.xml
1:46 pm

antoniop

Export message keys via the UI to normalize sort order and quoting and reduce downstream conflicts

Options
    • -2
    • +2
    /openacs-4/packages/xowf/xowf.info
    • -14
    • +14
    /openacs-4/packages/xowf/catalog/xowf.de_DE.ISO-8859-1.xml
    • -12
    • +12
    /openacs-4/packages/xowf/catalog/xowf.en_US.ISO-8859-1.xml
9:29 am

gustafn

more upstream version updates (font-awesome, bootstrap-icons)

font-awesome 6.4.2 (e.g. twitter -> "x" brand icon change)

https://fontawesome.com/v6/docs/changelog/

Bootstrap Icons v1.11.1 (100 new icons, including brand icon "x")

now including new floppy disk icons, additional brand icons, new person icons,

new emojis, some birthday cake, a few new science icons, and .... in total more than 2,000 icons

https://blog.getbootstrap.com//2023/09/12/bootstrap-icons-1-11-0/

Options
    • -2
    • +2
    /openacs-4/packages/bootstrap-icons/bootstrap-icons.info
    • -1
    • +1
    /openacs-4/packages/bootstrap-icons/tcl/resource-procs.tcl
    • -2
    • +2
    /openacs-4/packages/fa-icons/fa-icons.info
    • -2
    • +2
    /openacs-4/packages/fa-icons/tcl/resource-procs.tcl
9:12 am

gustafn

upgrade to Bootstreap 5.3.2 (package 5.10.1b3)

Options
    • -2
    • +2
    /openacs-4/packages/openacs-bootstrap5-theme/openacs-bootstrap5-theme.info
    • -1
    • +1
    /openacs-4/packages/openacs-bootstrap5-theme/tcl/resource-procs.tcl
Tuesday 26 Sep 2023
4:46 pm

gustafn

improved error handling, when mapped fields are missing

Options
    • -2
    • +5
    /openacs-4/packages/xooauth/tcl/authorize-procs.tcl
Monday 25 Sep 2023
5:44 pm

antoniop

Reintroduce "short_name" list element in the folder-chunk, used in the list format and not exactly equivalent to "name"

Options
    • -1
    • +13
    /openacs-4/packages/file-storage/www/folder-chunk.tcl
11:41 am

antoniop

Provide a Bootstrap-agnostic way to make the iframe "as big as possible"

Options
    • -1
    • +1
    /openacs-4/packages/proctoring-support/lib/proctored-page.adp
    • -1
    • +2
    /openacs-4/packages/proctoring-support/www/resources/proctored-page.js
11:40 am

antoniop

Make btn CSS BS3 and BS5 aware

Many thanks to Monika Andergassen

Options
    • -3
    • +3
    /openacs-4/packages/proctoring-support/lib/proctored-page.adp
    • -4
    • +0
    /openacs-4/packages/proctoring-support/www/resources/proctored-page.css
11:38 am

antoniop

Hide other potentially visible components of the template master

Many thanks to Monika Andergassen

Options
    • -0
    • +2
    /openacs-4/packages/proctoring-support/lib/proctored-page.adp
9:35 am

gustafn

fix typo

Options
    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/upgrade/upgrade.tcl
9:23 am

gustafn

fix typos

Options
    • -2
    • +2
    /openacs-4/packages/xooauth/tcl/ms-procs.tcl
Saturday 23 Sep 2023
8:08 am

gustafn

bugfix for azure content with multibyte characters

This change fixes two bugs:

a) base64decode was used instead of base64urldecode

b) the binary flag is harmful, since this leads to double-encoding

Many thanks to Sebastian Scheder for the fix.

Options
    • -3
    • +6
    /openacs-4/packages/xooauth/tcl/ms-procs.tcl
Tuesday 19 Sep 2023
1:55 pm

gustafn

improved support for Bootstrap5 for composite items

Many thanks to Monika Andergassen for the changes

Options
    • -7
    • +8
    /openacs-4/packages/xowf/tcl/test-item-procs.tcl