• last updated 1 hour ago
Constraints: committers
Constraints: files
Constraints: dates
Make adp_parse_ad_conn_file a private interface: its stated purpose is to be registered via rp_register_extension_handler in acs-templating/tcl/acs-integration-init.tcl and it has no practical use otherwise

Test ad_return_template

Reuse computation

Avoid catch where a more appropriate idiom exists

Improve documentation

Cleanup case

Whitespace cleanup

Harden page contract

Extend regression test

if truncate_len is provided we have to call util_close_html_tags for truncating the string

Fix self-inflicted bug: one should indeed be able to specify the same form var multiple time, test the behavior for the future

Reimplement upload automated test using a real multipart request, as newer naviserver will reject handcrafted .tmpfile parameters

Extend util::http::post_payload and util::http::post to receive form varaibles also in dict form, update documentation

Cleanup leftover arguments

Test ad_return_exception_template

file acs-integration-procs.tcl was initially added on branch oacs-5-10.

Deprecate acs-subsite/www/shared/db-error and move a copy to acs-subsite/lib/shared/db-error, replace occurrences, adjust dependencies

file db-error.adp was initially added on branch oacs-5-10.

Make this template more robust to the casual invocation from the outside

This should actually be moved to the lib directory, as it is intended as an include

Whitespace changes

Test ad_dimensional_sql

Test ad_dimensional

file dimensional-procs.tcl was initially added on branch oacs-5-10.

Make spelling consistent

Quote unallowed HTML according to acs-tcl.documentation__check_proc_doc

Rename proc according to convention enforced in acs-tcl: naming__proc_naming

Reinstate the notnull validation constraint where missing

    • -1
    • +1
    • -2
    • +2
    • -2
    • +2
  1. … 10 more files in changeset.
re-add notnull value constraint on message_id

This constraint was removed about 14 days ago. Without this constraint,

errors like the following will show up....

[30/Aug/2022:14:07:29.820625][3102633.7f152c28d700][-conn:openacs.org:default:0:196214-] Error: rp_handler no-script-abort: errorMsg can't read "message(forum_id)": no such variable while serving GE

T /forums/message-view?message_id HTTP/1.1

: ad_url </forums/message-view> maps to file </var/www/openacs.org/packages/forums/www/message-view.adp>


: can't read "message(forum_id)": no such variable

: while executing

: "forum::get -forum_id $message(forum_id) -array forum"

Probably, in many more cases, the incorrect removal of the notnull constrain performed by [1]

requires the same fix.

[1] https://github.com/openacs/forums/commit/c403e3134ce4e73ba94a80540a8b0f3cb1651ed0#diff-d35c736495ede0174fb39791ab660c5cd1a4ca467db2c4741cfc935167d7e5a8

    • -2
    • +2
handle clases, where "nt_load_end" is not provided

Replace message keys inside message keys. Many thanks to Monika Andergassen.