Activity OpenACS/

Set ad_include_contract's local variables in a way that they are hinted as private by the "__" prefix: this reduces the chance of conflicting with popular variable names to pass to an include such as "context"

- -5
- +5
/openacs-4/packages/acs-tcl/tcl/tcl-documentation-procs.tcl
- History
- Source
- Diff
/openacs-4/.../tcl-documentation-procs.tcl

2:34 pm

gustafn

Change caching of driver keys

There seems to be a bug in "db_driverkey", when OpenACS connects to

multiple databases [1]. The situation with "db_driverkey" is

complicated by the fact that this function is sometimes called with a

database name in its argument "dbn", and sometimes with a database

handle. This is something to look at in the future.

The new version removes the per-thread caching, which was introduced

to reduce the high number of mutex locks caused in busy machines. The

new version is better by a factor of 2 than older versions, but relies

on NaviServer.

[1] https://openacs.org/forums/message-view?message_id=5537865

- -33
- +42
/openacs-4/packages/acs-tcl/tcl/01-database-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../01-database-procs.tcl

2:09 pm

antoniop

More
MAIN:antoniop:20210929120959
deleted 2 files
MAIN

file upgrade-5.10.1d1-5.10.1d2.sql was initially added on branch oacs-5-10.

- -0
- +0
/openacs-4/packages/acs-kernel/sql/oracle/upgrade/upgrade-5.10.1d1-5.10.1d2.sql
- History
- Source
/openacs-4/.../upgrade-5.10.1d1-5.10.1d2.sql
- -0
- +0
/openacs-4/packages/acs-kernel/sql/postgresql/upgrade/upgrade-5.10.1d1-5.10.1d2.sql
- History
- Source
/openacs-4/.../upgrade-5.10.1d1-5.10.1d2.sql

2:09 pm

antoniop

Complete reform introduced in https://cvs.openacs.org/changelog/OpenACS?cs=oacs-5-10%3Agustafn%3A20210928124647

- add datamodel change to the creation script

- refactor algorithm names in a way that the new procs will comply with acs-tcl.naming__proc_naming automated test

- -3
- +3
/openacs-4/packages/acs-kernel/acs-kernel.info
- History
- Source
- Diff
/openacs-4/packages/.../acs-kernel.info
- -2
- +4
/openacs-4/packages/acs-kernel/sql/oracle/community-core-create.sql
- History
- Source
- Diff
/openacs-4/.../community-core-create.sql
- -0
- +9
/openacs-4/packages/acs-kernel/sql/oracle/upgrade/upgrade-5.10.1d1-5.10.1d2.sql
- History
- Source
- Diff
/openacs-4/.../upgrade-5.10.1d1-5.10.1d2.sql
- -2
- +4
/openacs-4/packages/acs-kernel/sql/postgresql/community-core-create.sql
- History
- Source
- Diff
/openacs-4/.../community-core-create.sql
- -0
- +10
/openacs-4/packages/acs-kernel/sql/postgresql/upgrade/upgrade-5.10.1d1-5.10.1d2.sql
- History
- Source
- Diff
/openacs-4/.../upgrade-5.10.1d1-5.10.1d2.sql
- -3
- +3
/openacs-4/packages/acs-tcl/acs-tcl.info
- History
- Source
- Diff
/openacs-4/packages/acs-tcl/acs-tcl.info
- -7
- +7
/openacs-4/packages/acs-tcl/tcl/security-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../security-procs.tcl

1:34 pm

antoniop

Fix typo affecting only a fresh installation of the chat package...

- -1
- +1
/openacs-4/packages/chat/tcl/xotcl-chat-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../xotcl-chat-procs.tcl

10:15 pm

gustafn

revert regression introduced on Aug 07 and factor out common code

- -8
- +16
/openacs-4/packages/xowiki/tcl/xowiki-www-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../xowiki-www-procs.tcl

2:46 pm

gustafn

More
MAIN:gustafn:20210928124648
deleted 2 files
MAIN

file upgrade-5.10.0-5.10.1d1.sql was initially added on branch oacs-5-10.

- -0
- +0
/openacs-4/packages/acs-kernel/sql/oracle/upgrade/upgrade-5.10.0-5.10.1d1.sql
- History
- Source
/openacs-4/.../upgrade-5.10.0-5.10.1d1.sql
- -0
- +0
/openacs-4/packages/acs-kernel/sql/postgresql/upgrade/upgrade-5.10.0-5.10.1d1.sql
- History
- Source
/openacs-4/.../upgrade-5.10.0-5.10.1d1.sql

2:46 pm

gustafn

Stronger password hashes for OpenACS

This change introduces the possibility to use either the classical

OpenACS password hash algorithm "salted-sha1" or the SCRAM passord

function "scram-sha-256". The latter can be used by (a) using the

most recent version of NaviServer (from Sept 28, 2021 or newer) and

(b) by configuring the password hash preferences via Kernel package

parameter "PasswordHashAlgorithm". The package parameter can contain a

list of multiple hash algorithms in preference order. The most

preferred available algorithm is chosen.

By default, the "PasswordHashAlgorithm" is "salted-sha1", and the

behavior is as before. After upgrading to the new version of acs-tcl

and acs-kernel, the preference list can be configured. When a user

logs in and the preferred available algorithm is different from the

previously used algorithm, the upgrade is performed for the user

automatically.

The usage of SHA1 in OpenACS is easily target of security audits (see

[1]). The biggest danger is that if somebody gets full access to the

"users" table (e.g. when decommissioning a hard disk). In this case

the hashes can be attacked with dictionaries by using some crypto

hardware (when someone gets raw access to the DB, one has usually some

other big problems). However, by using the "scram-sha-256" hash

function this danger is substantially reduced. This function computes

a password hash using PBKDF2 (Password-Based Key Derivation Function

2). This function is used to reduce vulnerabilities of brute-force

attacks against password hashes. The hash function of SCRAM is PBKDF2

[RFC2898] with HMAC as the pseudorandom function (PRF) and with dkLen

== output length of HMAC == output length of the digest function. So,

it uses a better hash algorithm (sha-256 vs. sha1) and applies this a

high number of times (15K times for a password hash computation).

NaviServer supports as well the even better SCRYPT algorithm, but this

is only available when NaviServer is compiled with OpenSSL 3.0 or

newer. On the contrary, scram-sha-256 (actually PKCS5_PBKDF2_HMAC) is

available since OpenSSL 1.0.0 (2015).

All the improved hash functions require NaviServer with its tight

integration to the crypto functions of OpenSSL.

[1] https://openacs.org/forums/message-view?message_id=5522562

- -2
- +3
/openacs-4/packages/acs-kernel/acs-kernel.info
- History
- Source
- Diff
/openacs-4/packages/.../acs-kernel.info
- -0
- +57
/openacs-4/packages/acs-kernel/sql/oracle/upgrade/upgrade-5.10.0-5.10.1d1.sql
- History
- Source
- Diff
/openacs-4/.../upgrade-5.10.0-5.10.1d1.sql
- -0
- +47
/openacs-4/packages/acs-kernel/sql/postgresql/upgrade/upgrade-5.10.0-5.10.1d1.sql
- History
- Source
- Diff
/openacs-4/.../upgrade-5.10.0-5.10.1d1.sql
- -3
- +3
/openacs-4/packages/acs-tcl/acs-tcl.info
- History
- Source
- Diff
/openacs-4/packages/acs-tcl/acs-tcl.info
- -0
- +1
/openacs-4/packages/acs-tcl/tcl/00-icanuse-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../00-icanuse-procs.tcl
- -14
- +103
/openacs-4/packages/acs-tcl/tcl/security-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../security-procs.tcl
- -17
- +0
/openacs-4/packages/acs-tcl/tcl/security-procs.xql
- History
- Source
- Diff
/openacs-4/packages/.../security-procs.xql

1:28 pm

antoniop

Add missing argument expansion and comply with automated test

- -3
- +3
/openacs-4/packages/acs-tcl/tcl/request-processor-procs.tcl
- History
- Source
- Diff
/openacs-4/.../request-processor-procs.tcl

1:27 pm

antoniop

Test for ad_register_proc exposing a bug due to missing argument expansion

- -0
- +159
/openacs-4/packages/acs-tcl/tcl/test/request-processor-procs.tcl
- History
- Source
- Diff
/openacs-4/.../request-processor-procs.tcl

OpenACS

Line History

Stats

Commits this week: 34

Commit Activity

52 week commits volume

Commits by day

Commits by hour

Commit calendar

Most active committers (90 days)

antoniop

trenner

antoniop

antoniop

antoniop

antoniop

gustafn

gustafn

gustafn

gustafn

gustafn

gustafn

gustafn

gustafn

gustafn

gustafn

gustafn

gustafn

gustafn

gustafn

antoniop

gustafn

antoniop

antoniop

antoniop

gustafn

gustafn

gustafn

antoniop

antoniop