OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 34
Total Committers: 146
Last Commit: 28 Dec
Commits this week: 34
Total Lines of Code (LoC): 7,561,384
Net change in LoC this week: 37

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 9 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 31 May 2021
4:03 pm

antoniop

Whitespace changes

Options
    • -531
    • +531
    /openacs-4/packages/acs-developer-support/tcl/acs-developer-support-procs.tcl
3:40 pm

antoniop

Split statements into multiple database commands:

issuing multiple sql statements in the same command is a undocumented feature, probably exploited for performance reason, but not officially supported. The dml api will check if the first statement (supposed to be the only one) is actually a DML one. As the first statement in the chain is a select, the command fails.

Fixes xolp automated tests

Options
    • -16
    • +26
    /openacs-4/packages/xolp/tcl/xolp-indicator-procs.tcl
2:40 pm

antoniop

Make test more robust when re-running

Options
    • -0
    • +6
    /openacs-4/packages/proctoring-support/tcl/test/proctoring-test-procs.tcl
2:35 pm

antoniop

Make api public, as this might be called in adp files from other packages

Options
    • -2
    • +2
    /openacs-4/packages/acs-templating/tcl/list-procs.tcl
1:40 pm

hectorr

Add tested procs to test cases

Options
    • -0
    • +17
    /openacs-4/packages/xolp/tcl/test/xolp-test-procs.tcl
Sunday 30 May 2021
9:02 pm

gustafn

reduce verbosity

Options
    • -3
    • +3
    /openacs-4/packages/xotcl-request-monitor/tcl/throttle_mod-procs.tcl
8:52 pm

gustafn

strengthen parameter checking

Options
    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/package-procs.tcl
    • -23
    • +23
    /openacs-4/packages/xowiki/tcl/xowiki-www-procs.tcl
    • -1
    • +1
    /openacs-4/packages/xowf/lib/answer-single-question.wf
    • -7
    • +7
    /openacs-4/packages/xowf/lib/inclass-exam.wf
    • -2
    • +2
    /openacs-4/packages/xowf/tcl/xowf-procs.tcl
7:58 pm

gustafn

fix typo

Options
    • -1
    • +1
    /openacs-4/packages/xolp/tcl/xolp-indicator-procs.tcl
7:57 pm

gustafn

avoid "tuple concurrently updated" errors from PostgreSQL

These errors are produced from PostgreSQL, when multiple

"CREATE OR # REPLACE FUNCTION" SQL are executed..

see e.g.:

https://stackoverflow.com/questions/40525684/tuple-concurrently-updated-when-creating-functions-in-postgresql-pl-pgsql

Options
    • -1
    • +13
    /openacs-4/packages/xolp/tcl/xolp-indicator-procs.tcl
Thursday 27 May 2021
9:08 pm

gustafn

use the right message key

VS: ----------------------------------------------------------------------

Options
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/tcl-documentation-procs.tcl
9:07 pm

gustafn

Fixed a bug in the request processor, when URL is /%3F

The problem was that /%3F corresponds to a URL which is literally '/?'

(question mark is not the separator for query variables). In this case

a "string match" operation to determine the suffix based on this

string will lead to unexpected characters since '?' is a match

character. This lead in turn to a problem with redirects to the

internally redirect of custom error pages. So, in this case (and

probably others) the custom error page was not displayed.

Options
    • -13
    • +27
    /openacs-4/packages/acs-tcl/tcl/request-processor-procs.tcl
Tuesday 25 May 2021
10:08 pm

gustafn

Handling of mutual overwrites in answer workflows

Mutual overwrites occur in answer workflows when a user manages to

open multiple browswer instances/or tabs on the same exam.

In case there was an mutual overwrite, the position as provided by the

instance attributes might deviate from the position, based on which

the actual form data was generated. So, for validating and updating

one has to change the position to the one from the form data (when

this differs). Note that the randomizer depends on property

"position" as well.

The new version avoids that the user might accidencially overwrite his

data and closes on mutual overwrite automatically the older instance

window.

Bumped version number to 5.10.0d38

Options
    • -3
    • +3
    /openacs-4/packages/xowf/xowf.info
    • -6
    • +60
    /openacs-4/packages/xowf/lib/inclass-exam-answer.wf
    • -1
    • +1
    /openacs-4/packages/xowf/tcl/test-item-procs.tcl
9:50 pm

gustafn

Added warning, when (not all) requested forms could not be loaded.

Reduced verbosity.

Options
    • -6
    • +15
    /openacs-4/packages/xowf/tcl/test-item-procs.tcl
9:45 pm

gustafn

add more more option for quick debugging passed in form data

Options
    • -2
    • +3
    /openacs-4/packages/xowf/www/index.vuh
9:43 pm

gustafn

add warning to log file, when a HTML form-data is passed in fro which we have no form-fields defined

Options
    • -1
    • +3
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
9:42 pm

gustafn

More restricted checking for object_ids

This avoids SQL errors in cases, where values are passed in via query variables

which are valid integers but out of range for SQL integer, which are 32-bit

integers. The better solution would even be to define an NSF argument type

"object_id", but unfortunately, this requires a newer version of NSF than

we target for the release.

Options
    • -9
    • +9
    /openacs-4/packages/xowiki/tcl/package-procs.tcl
9:37 pm

gustafn

- Added new method extra_html_fields to provide an easy means to add

extra HTML fields to the form autogenerated for form pages

- bump version number to 5.10.0d79

Options
    • -2
    • +2
    /openacs-4/packages/xowiki/xowiki.info
    • -5
    • +30
    /openacs-4/packages/xowiki/tcl/xowiki-www-procs.tcl
4:29 pm

gernst

Added feature to auto lauch LTI login forms upon page loading. This is especially useful when embedding LTI content using an iframe.

Options
    • -4
    • +17
    /openacs-4/packages/xooauth/tcl/lti-procs.tcl
Sunday 23 May 2021
7:57 pm

gustafn

improved spelling

Options
    • -1
    • +1
    /openacs-4/packages/acs-tcl/tcl/00-icanuse-procs.tcl
    • -3
    • +3
    /openacs-4/packages/acs-tcl/tcl/deprecated-procs.tcl
    • -1
    • +1
    /openacs-4/packages/acs-tcl/tcl/form-processing-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/navigation-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
    • -1
    • +1
    /openacs-4/packages/acs-tcl/tcl/test/proxy-test-procs.tcl
7:56 pm

gustafn

Added page_contract filter "object_id"

This change adds the page_contract filter "object_id", which validates

values whether these are syntactically acceptable as object_ids in

PostgreSQL and Oracle.

Note that before one is able to use the filter, the server has to be

restarted. Otherwise, when e.g. "apm/version_reload.tcl" would be

executed with the new filter, it would fail. So, one has to be careful

on update scripts, when people upgrade from old version not to create

a blocking mutual blocking condition.

Options
    • -2
    • +2
    /openacs-4/packages/acs-tcl/acs-tcl.info
    • -1
    • +2
    /openacs-4/packages/acs-tcl/catalog/acs-tcl.de_DE.ISO-8859-1.xml
    • -0
    • +1
    /openacs-4/packages/acs-tcl/catalog/acs-tcl.en_US.ISO-8859-1.xml
    • -2
    • +30
    /openacs-4/packages/acs-tcl/tcl/tcl-documentation-procs.tcl
    • -1
    • +5
    /openacs-4/packages/acs-tcl/tcl/test/acs-tcl-test-procs.tcl
7:24 pm

gustafn

improve comments

Options
    • -4
    • +19
    /openacs-4/packages/acs-tcl/tcl/request-processor-procs.tcl
Friday 21 May 2021
9:40 am

gustafn

use util::unzip instead of plain "exec unzip" commands

Options
    • -3
    • +3
    /openacs-4/packages/assessment/tcl/as-qti-procs.tcl
    • -1
    • +1
    /openacs-4/packages/assessment/www/asm-admin/unzip-file.tcl
    • -8
    • +8
    /openacs-4/packages/file-storage/www/folder-zip-add.tcl
    • -2
    • +2
    /openacs-4/packages/richtext-ckeditor4/tcl/richtext-procs.tcl
Thursday 20 May 2021
12:04 pm

trenner

add question_info_block to documentation block

Options
    • -0
    • +1
    /openacs-4/packages/xowf/tcl/test-item-procs.tcl
10:49 am

gustafn

new variant of zip_file_contains_valid_filenames independent of "unuip -l"

unfortunately the behavior of "unzip -l" differs not only between

macOS and Linux, but even between different linux families, although

showing the same version.

Options
    • -12
    • +25
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
Wednesday 19 May 2021
5:55 pm

gernst

Refine regular expression used for the detection of Includelets

Options
    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
4:57 pm

trenner

add explicit return to be more human readable

Options
    • -0
    • +2
    /openacs-4/packages/xowf/tcl/test-item-procs.tcl
4:43 pm

trenner

split out question_info_block

Options
    • -7
    • +14
    /openacs-4/packages/xowf/tcl/test-item-procs.tcl
9:04 am

trenner

fix typo

Options
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
Tuesday 18 May 2021
10:26 pm

gustafn

bugfix: pass "-revisions" to "render_proctor_images" since it is needed there

Options
    • -0
    • +6
    /openacs-4/packages/xowf/tcl/test-item-procs.tcl
10:23 pm

gustafn

fix braces for return_url

Options
    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/form-field-procs.tcl