• last updated 21 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Improve visualization of test info

Relax test condition:

make sure potential injections are not rendered on the page response.

Extend test suite

when testing FormPage validation, make sure two distinct behaviors are respected:

1) Rejected values that were part of the request are kept into their original form fields so the user can rework them and resubmit

2) Other parts of the page, such as the page title, are NOT influenced by data that faild to validate

Rationale: displaying unvalidated information as part of the response can be interpreted as a page injection.

In current codebase, that the title was changed indicates, that rejected information made its way into the :title object member of the FormPage.

The potential consequences of the FormPage setting unvalidated information into its members depends on a number of factors such as formfield logics, callbacks and proper page quoting (to name a few).

Extend test: edit a different component of repeated compound 3 to also test that old and new values are stored as expected

Extend and fix xowiki.create_form_with_form_instance automated test with respect to checkbox behavior

- simple checkboxes (normal and repeated): as we do not specify a value for those, the default should be expected, not the last option

- checkboxes in repeated compound fields: upon triavial re-editing, the values should stay the same

This change exposes a bug in acs::test::xpath::get_form_values

Disable tests to check for executables on the system

  1. … 7 more files in changeset.
Cleanup copy paste

Test external command dependencies

  1. … 1 more file in changeset.
Cleanup reference to deprecated api

removed test depending on some internals.

These test are convered by the web-tests, so these seem not necessary

Use signed value for form_parameter "__object_name"

Bumped version number to 5.10.1d40

  1. … 3 more files in changeset.
improve field validation

  1. … 3 more files in changeset.
Test behavior of the omit formfield spec

Preliminary cleanup

In this test we will loop through instances of ::xowiki::Page currently in memory to perform some checks. When multiple tests run in the same request, we cannot guarantee that other tests won't create ::xowiki::Page instances that won't comply with the conditions here. We cleanup any existing object in advance to start from a clean slate.

Extend test: show that even when a field is defined as disabled, a request crafted to carry these fields will get through and the values will be stored

A fix will come shortly, similar to what was done for compound fields

fix warning (including some false positives) in regression test

  1. … 5 more files in changeset.
Document and enforce expected behavior when Forms are deleted: this is forbidden and returns an error as long as they have instances

make regression test more robust with respect to yui rendering

Cleanup dummy commands and objects to avoid cross interactions between tests

  1. … 1 more file in changeset.
Cleanup test for deleted api

Improved Bootrap5 support

- transformed PageInstance->adp_parse_tags into an adp_proc

xowiki::PageInstance->adp_parse_tags to ease usage outside methods.

- made personal-notification proc agonsitic of Boostrap 3

- renamed attribute "-glyphicon" to "-adpicon" in

personal-notification-messages->modal_message_dialog

and use adp:icon instead

- added regression test

- bumped version number to 5.10.1d26

  1. … 5 more files in changeset.
Alignments for Bootstrap 5

Also, use form.form for creating forms from the menubar instead of

old-strle ::xowiki::Forms. Aligned as well regression test to use

form.form.

Bump version number to 5.10.1d24

  1. … 8 more files in changeset.
prefer variable ::acs::rootdir over proc [acs_root_dir]

  1. … 1 more file in changeset.
Fix provide language prefixes for pages in the test

Fix template case

fix bug: tcl clock format %e returns in current versions single digit values with leading whitespace, which are invalid values for the options field.

Since non of the date-component fields is supposed to contain leading (or trailing) white-space,

this is now trimmed.

  1. … 1 more file in changeset.
added regression test for includelet includelet "child-resources"

added private function xowiki::test::require_form_page to ease regression testing

add test cases for three different toc styles

  1. … 1 more file in changeset.
no need to sort already sorted sequence

This problem was introduced via the ns_strcoll support which is not sufficiently clever on numbers.

We should support for numerical sort when needed (which seems rare enough)

  1. … 1 more file in changeset.