• last updated 9 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
remove dependency of general-comments on acs-mail-lite

  1. … 3 more files in changeset.
complete listing of covered procs in test cases

  1. … 14 more files in changeset.
improve spelling

  1. … 1 more file in changeset.
Provide a public general-comments solution to empty messages from a specific package: other xowiki-like packages downstream would otherwise need to call a xowiki private api

  1. … 1 more file in changeset.
Whitespace cleanup

Complete api coverage for general-comments

    • -1
    • +111
    ./test/general-comments-procs.tcl
Cover some more api

Start testing general comments

file general-comments-procs.tcl was initially added on branch oacs-5-10.

    • -0
    • +0
    ./test/general-comments-procs.tcl
use consistently the same prefix "general_comments" (and not singular version)

    • -2
    • +2
    ./general-comments-procs-postgresql.xql
  1. … 1 more file in changeset.
Bring files on oacs-5-10 in sync with HEAD

    • -0
    • +37
    ./general-comments-procs-oracle.xql
    • -0
    • +39
    ./general-comments-procs-postgresql.xql
  1. … 2 more files in changeset.
Bring files on oacs-5-10 in sync with HEAD

  1. … 162 more files in changeset.
Prefer 'person::name' to 'acs_user::get_element ... -name'

  1. … 8 more files in changeset.
Use cached user api to retrieve comment author

file general-comments-procs-oracle.xql was added on branch oacs-5-10 on 2019-02-16 09:33:45 +0000

file general-comments-procs-postgresql.xql was added on branch oacs-5-10 on 2019-02-16 09:33:45 +0000

    • -0
    • +0
    ./general-comments-procs-postgresql.xql
Resurrect xql files lost in previous commit, reduce differences between oracle and postgres codebase

    • -0
    • +37
    ./general-comments-procs-oracle.xql
    • -0
    • +39
    ./general-comments-procs-postgresql.xql
Follow the "ugly" smell

rework of general-comments rendering so that the templating system is used, instead of handcrafted markup. Also, allow theming in the future.

    • -96
    • +0
    ./general-comments-procs-oracle.xql
    • -101
    • +0
    ./general-comments-procs-postgresql.xql
  1. … 1 more file in changeset.
make spelling more consistent

  1. … 3 more files in changeset.
merged changes from the oacs-5-9 branch and resolved conflicts

    • -1
    • +1
    ./general-comments-procs-postgresql.xql
  1. … 7831 more files in changeset.
Fix spelling errors

  1. … 16 more files in changeset.
No need to pass single spaces

Removed RFC822 id generation from acs_message__new stored procedure:

beside being replication of what already available in proc acs_mail_lite::generate_message_id,

it was buggy, because it assumed http protocol (no https) and also broke General Comments

on installations that by chance had an empty SystemURL parameter

    • -1
    • +1
    ./general-comments-procs-postgresql.xql
  1. … 5 more files in changeset.
- prefer ns_quotehtml over ad_quotehtml

  1. … 20 more files in changeset.
- add editor hints to keep spaces/tabs in the future more consistent

  1. … 350 more files in changeset.
- standardize url construction to protect against injection attacks

  1. … 9 more files in changeset.
Merging back to HEAD branch oacs-5-8 (using tag vg-merge-oacs-5-8-from-20141027).

  1. … 2547 more files in changeset.
- new style string expressions

- brace expressions to allow for tcl compilation

- bump version number

  1. … 9 more files in changeset.
- replace deprecated "export_url_vars" by "export_vars -url"

- fix bracing in "export_vars -form"

  1. … 121 more files in changeset.
New version with deletion of comments

    • -0
    • +21
    ./general-comments-callback-procs.tcl
  1. … 9 more files in changeset.