OpenACS / openacs-4 / packages / forums

tcl

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 39
Last Commit: 14 Nov
Commits this week: 0
Total Lines of Code (LoC): 3,775
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 46 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 08 Oct
4:52 pm

antoniop

Prefer unset to array unset when the whole array should be deleted

See https://wiki.tcl-lang.org/page/Dict+VS+Array+Speed

Options
    • -2
    • +2
    ./messages-procs.tcl
Wednesday 11 Sep
8:11 am

gustafn

merge with missing files

Options
    • -0
    • +0
    ./forum-reply-procs.tcl
    • -0
    • +0
    ./forums-callback-procs.tcl
    • -0
    • +0
    ./forums-install-procs.tcl
    • -0
    • +0
    ./forums-procs.tcl
    • -0
    • +0
    ./forums-sc-procs.tcl
    • -0
    • +0
    ./forums-security-procs.tcl
    • -0
    • +0
    ./messages-procs.tcl
    • -0
    • +0
    ./test/forums-procs.tcl
  9. … 1457 more files in changeset.
Tuesday 03 Sep
5:37 pm

gustafn

merge from oacs-5-10

Options
    • -20
    • +27
    ./form-procs.tcl
    • -5
    • +11
    ./forum-reply-procs.tcl
    • -42
    • +0
    ./forums-callback-procs-oracle.xql
    • -43
    • +0
    ./forums-callback-procs-postgresql.xql
    • -13
    • +41
    ./forums-callback-procs.tcl
    • -14
    • +222
    ./forums-install-procs.tcl
    • -20
    • +89
    ./forums-procs.tcl
    • -4
    • +5
    ./forums-procs.xql
    • -16
    • +48
    ./forums-sc-procs.tcl
    • -2
    • +27
    ./forums-security-procs.tcl
    • -21
    • +14
    ./messages-format-procs.tcl
    • -48
    • +0
    ./messages-procs-oracle.xql
    • -44
    • +0
    ./messages-procs-postgresql.xql
    • -84
    • +268
    ./messages-procs.tcl
    • -29
    • +274
    ./test/forums-procs.tcl
  16. … 8085 more files in changeset.
Wednesday 07 Aug
11:54 am

gustafn

Removed useless and hard to track ad_log messages in the forums:

Cannot determine package_id. Returning 0

Options
    • -11
    • +18
    ./messages-procs.tcl
Tuesday 06 Aug
12:16 pm

gustafn

reduce verbosity in the system log

Options
    • -1
    • +12
    ./forums-procs.tcl
Monday 15 Jul
2:07 pm

gustafn

improved spelling consistency

Options
    • -2
    • +2
    ./forums-procs.tcl
Friday 14 Apr 2023
4:03 pm

antoniop

Prefer cached api

Options
    • -3
    • +5
    ./forums-procs.tcl
  2. … 1 more file in changeset.
Thursday 23 Mar 2023
1:47 pm

antoniop

Update uninstall callback:

- avoid convoluted idioms

- improve documentation

- use cross dbms api

Options
    • -11
    • +26
    ./forums-install-procs.tcl
Tuesday 21 Mar 2023
2:52 pm

antoniop

Format code in a way to avoid false positives where a column name is taken as a deprecated proc

Options
    • -9
    • +6
    ./forums-procs.tcl
2:51 pm

antoniop

Cleanup deprecated api from test

Options
    • -3
    • +2
    ./test/forums-procs.tcl
Monday 20 Mar 2023
5:07 pm

antoniop

Use UTF-8 emoji HTML entities instead of static images to convert smileys in the forums package

This has the advantage of not requiring a request to serve the images. It also avoids the need to hardcode the image size, as they will be basically treated as fonts.

Options
    • -19
    • +12
    ./messages-format-procs.tcl
  2. … 1 more file in changeset.
4:35 pm

antoniop

Whitespace cleanup

Options
    • -5
    • +5
    ./messages-format-procs.tcl
4:02 pm

antoniop

Increase proc coverage, deprecate proc in the process

Options
    • -2
    • +11
    ./messages-procs.tcl
    • -6
    • +101
    ./test/forums-procs.tcl
3:15 pm

antoniop

Test cornercase behavior

Options
    • -2
    • +3
    ./test/forums-procs.tcl
2:58 pm

antoniop

Make Service Contract implementations private

Options
    • -5
    • +11
    ./forum-reply-procs.tcl
2:39 pm

antoniop

Deprecate forum::new_questions_allow and forum::new_questions_deny, one should use forum::edit, which will also track the change, or just inline the query instead

Options
    • -2
    • +6
    ./forums-callback-procs.tcl
    • -3
    • +11
    ./forums-procs.tcl
2:28 pm

antoniop

Deprecate forum::new_questions_allowed_p and replace occurrences

Options
    • -2
    • +8
    ./forums-procs.tcl
    • -5
    • +1
    ./test/forums-procs.tcl
  3. … 1 more file in changeset.
2:17 pm

antoniop

Increase proc coverage

Options
    • -9
    • +44
    ./test/forums-procs.tcl
Friday 24 Feb 2023
2:19 pm

antoniop

Give priority to the information provided explicitly to the api (the forum_id) in order to determine the package id and fallback to the connection context only when this is not available

Options
    • -12
    • +37
    ./forums-procs.tcl
Thursday 31 Mar 2022
6:33 pm

antoniop

Replace the lame template::util::get_opts with some homemade utility that will parse arguments reliably, adjust the one upstream use case where arguments other than those documented might be passed to the element creation, introduce a warning when this happens somewhere else

Options
    • -5
    • +4
    ./form-procs.tcl
  2. … 1 more file in changeset.
Monday 03 Jan 2022
1:58 pm

antoniop

Replace reference to long-missing message key

Options
    • -3
    • +3
    ./messages-procs.tcl
Thursday 02 Sep 2021
8:29 pm

gustafn

fix recent editing bug

Options
    • -2
    • +2
    ./messages-procs.tcl
6:40 pm

gustafn

improve spelling

Options
    • -3
    • +3
    ./messages-procs.tcl
  2. … 42 more files in changeset.
Sunday 29 Aug 2021
4:48 pm

gustafn

fixed categorization of test case

Options
    • -2
    • +2
    ./test/forums-procs.tcl
Wednesday 23 Jun 2021
11:24 am

hectorr

Add 'forum_enable_disable' test case, covering 'forum::enable' and 'forum::disable'

Options
    • -1
    • +50
    ./test/forums-procs.tcl
Friday 30 Apr 2021
11:05 am

antoniop

Fix typo

Options
    • -2
    • +2
    ./forums-callback-procs.tcl
Thursday 29 Apr 2021
4:03 pm

antoniop

Handle correctly the indexing of moderated messages in fulltext search:

so far the fulltext search would also include unapproved messages and threads. With this reform we address this by:

- making sure unapproved threads are deleted from the index

- making sure new threads are added to the index only when the are approved

- making sure we unindex or reindex a thread whenever the approval state changes

- not fetching unapproved messages in the datasource callback, hence excluding them from the index

Note that Oracle has not been targeted by the reform. However, the situation improves for Oracle as well, because we won't render unmoderated messages in the datasource callback anymore.

Options
    • -1
    • +4
    ./forums-callback-procs.tcl
  2. … 3 more files in changeset.
Wednesday 31 Mar 2021
3:13 pm

gustafn

improve listing of procs covered by regression test

Options
    • -11
    • +44
    ./test/forums-procs.tcl
  2. … 2 more files in changeset.
Wednesday 03 Mar 2021
3:53 pm

hectorr

Prefer using 'user_info' over 'user_id' when calling 'acs::test::http'

Options
    • -5
    • +5
    ./test/forums-procs.tcl
    • -1
    • +6
    ./test/webtest-procs.tcl
Monday 22 Feb 2021
5:25 pm

antoniop

Skip deprecated api that is neutralized by the next upgrade, reinstate deprecated api just for upgrade purposes, complies with acs-api-browser.graph__bad_calls automated test

Options
    • -2
    • +4
    ./forums-install-procs.tcl
    • -3
    • +5
    ./forums-sc-procs.tcl