• last updated 18 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Move logics to create forum notification type to tcl to:

- reduce code duplication

- make it simpler to extend forums with new notification types

This reform was triggered by a downstream request, where users would like a new kind of notification for forum moderators that triggers also when a forum message has not been approved

    • -118
    • +0
    ./oracle/forums-notifications-init.sql
    • -128
    • +0
    ./oracle/forums-notifications-sanitize.sql
    • -134
    • +0
    ./postgresql/forums-notifications-init.sql
    • -151
    • +0
    ./postgresql/forums-notifications-sanitize.sql
  1. … 1 more file in changeset.
file upgrade-1.3.1d16-1.3.1d17.sql was initially added on branch oacs-5-10.

    • -0
    • +0
    ./postgresql/upgrade/upgrade-1.3.1d16-1.3.1d17.sql
Redefine forum charter as text, therefore without length limit

    • -3
    • +17
    ./postgresql/forums-forums-create.sql
    • -0
    • +27
    ./postgresql/upgrade/upgrade-1.3.1d16-1.3.1d17.sql
  1. … 1 more file in changeset.
Add column 'attachments_allowed_p' to 'forums_forums', to be used to allow/disallow attachments on a per forum basis. Currently, the attachment logic is package instance wise, so if the forums instance has an attachment instance mounted below, then attachments are assumed to be enabled for all forums in that package instance. The idea with this change is to check for both the attachments instance mounted under a particular forum instance, and the 'attachments_allowed_p' column on 'forums_forums', to decide if attachments are enabled or not (both should be true). Next step would be to rewrite the logic to achieve that.

    • -0
    • +10
    ./postgresql/upgrade/upgrade-1.3.1d12-1.3.1d13.sql
  1. … 1 more file in changeset.
file upgrade-1.3.1d12-1.3.1d13.sql was initially added on branch oacs-5-10.

    • -0
    • +0
    ./oracle/upgrade/upgrade-1.3.1d12-1.3.1d13.sql
    • -0
    • +0
    ./postgresql/upgrade/upgrade-1.3.1d12-1.3.1d13.sql
Removed obsolete @arch-tag

  1. … 25 more files in changeset.
improve spelliing

    • -2
    • +2
    ./postgresql/forums-messages-package-create.sql
  1. … 2 more files in changeset.
Fix typos

  1. … 61 more files in changeset.
- fix inconsistency between updated versions and new intallations: check always the message format

- add text/markdown to accepted formats

    • -0
    • +2
    ./postgresql/forums-messages-create.sql
    • -0
    • +11
    ./postgresql/upgrade/upgrade-1.3.1d4-1.3.1d5.sql
  1. … 1 more file in changeset.
Port downstream only usage of reading info api

Also fix such api so that root message is retrieved for every given source message

    • -5
    • +16
    ./oracle/forums-reading-info-package-create.sql
    • -0
    • +163
    ./oracle/upgrade/upgrade-1.3.1d3-1.3.1d4.sql
    • -2
    • +6
    ./postgresql/forums-reading-info-create.sql
    • -0
    • +34
    ./postgresql/upgrade/upgrade-1.3.1d3-1.3.1d4.sql
  1. … 4 more files in changeset.
Fix sql update to populate new forum_id column in existing data

Maintenance of forum reading count feature

- removal of forums_reading_info_user (1Mio rows on Learn@WU).

This materialized view had to be constantly synced with

forums_reading_info table. Reimplemented as view.

- simplify logics in stored procedure due to new datamodel

- fix inconsistencies between oracle and postgres function definition

- re-enabled parameter to decide whether use these stats or not in

administration

TODO: consider further reform of this feature as stats grow very

large on busy sites for probably little value added

    • -17
    • +10
    ./oracle/forums-reading-info-create.sql
    • -143
    • +5
    ./oracle/forums-reading-info-package-create.sql
    • -0
    • +186
    ./oracle/upgrade/upgrade-1.3.1d2-1.3.1d3.sql
    • -195
    • +68
    ./postgresql/forums-reading-info-create.sql
    • -9
    • +4
    ./postgresql/forums-reading-info-drop.sql
    • -0
    • +173
    ./postgresql/upgrade/upgrade-1.3.1d2-1.3.1d3.sql
  1. … 2 more files in changeset.
Implement post anonymously through explicit forum attribute in table

Now moderators can explicitly decide whether a forum will enable posting anonymously or not.

Forum must be in a policy different from closed and the anonymous flag must be set accordingly for this to happen.

Also:

- normalize api in a way it can accomodate all current attributes. In particular,

now edit api will now leave every unspecified attribute unchanged, instead of

setting it to some default.

- fix some usability issues when managing forum parameters (e.g. values not

retrieved in form when editing existing forum)

- introduce missing Oracle upgrade script for the whole forum reform

- fix oracle creation script

    • -0
    • +27
    ./oracle/upgrade/upgrade-1.3.1d1-1.3.1d2.sql
    • -0
    • +13
    ./postgresql/upgrade/upgrade-1.3.1d1-1.3.1d2.sql
  1. … 7 more files in changeset.
Forum reform

- remove hardcoded dependency with registered_users group. Target is to improve suitability in convoluted multi groups/multi subsites context

- in place of previous permission-based machinery, use plain table columns to detect whether user can or cannot post replies/new threads

- remove permission check at the message level in favor of that on forum level

    • -0
    • +18
    ./oracle/upgrade/upgrade-1.3-1.3d1.sql
    • -0
    • +13
    ./postgresql/upgrade/upgrade-1.3-1.3.1d1.sql
  1. … 18 more files in changeset.
merged changes from the oacs-5-9 branch and resolved conflicts

    • -5
    • +3
    ./postgresql/forums-messages-create.sql
    • -5
    • +5
    ./postgresql/forums-messages-package-create.sql
    • -0
    • +1
    ./postgresql/forums-reading-info-create.sql
  1. … 7830 more files in changeset.
- make update script more robust

Alter caveman style booleans (type character(1)) to real SQL boolean types.

    • -5
    • +3
    ./postgresql/forums-messages-create.sql
    • -5
    • +5
    ./postgresql/forums-messages-package-create.sql
  1. … 1 more file in changeset.
file upgrade-1.3d12-1.3d13.sql was initially added on branch oacs-5-9.

    • -0
    • +0
    ./postgresql/upgrade/upgrade-1.3d12-1.3d13.sql
- add function args for completeness

    • -0
    • +1
    ./postgresql/forums-reading-info-create.sql
- add function args missed by earlier upgrades

- bump version numbers

    • -0
    • +21
    ./postgresql/upgrade/upgrade-1.3d10-1.3d11.sql
  1. … 9 more files in changeset.
- fix half-baken dollar quoting

- fix half-baken dollar quoting

- update postgres function to modern style plpgsql definitions, avoid backslash escaping

- add missing function_args

    • -10
    • +11
    ./postgresql/forums-forums-create.sql
    • -16
    • +16
    ./postgresql/forums-forums-drop.sql
    • -32
    • +51
    ./postgresql/forums-forums-package-create.sql
    • -13
    • +13
    ./postgresql/forums-messages-create.sql
    • -82
    • +132
    ./postgresql/forums-messages-package-create.sql
    • -45
    • +53
    ./postgresql/forums-notifications-init.sql
    • -37
    • +52
    ./postgresql/forums-notifications-sanitize.sql
    • -55
    • +116
    ./postgresql/forums-reading-info-create.sql
    • -33
    • +40
    ./postgresql/forums-sc-create.sql
    • -7
    • +14
    ./postgresql/forums-tree-create.sql
    • -44
    • +70
    ./postgresql/upgrade/upgrade-0.1d-0.2d.sql
    • -7
    • +16
    ./postgresql/upgrade/upgrade-0.2d-0.3d.sql
    • -47
    • +76
    ./postgresql/upgrade/upgrade-1.0.6-1.0.7d.sql
    • -23
    • +30
    ./postgresql/upgrade/upgrade-1.0d4-1.0.1d2.sql
  1. … 9 more files in changeset.
1. Merge 2.4.1 to HEAD other than assessment, imsld, lorsm, and views.

2. Bump version numbers to 2.5.0d1.

    • -57
    • +140
    ./oracle/forums-reading-info-package-create.sql
  1. … 377 more files in changeset.
Fixed package forum-reading-info for Oracle.

    • -57
    • +140
    ./oracle/forums-reading-info-package-create.sql
Fix path of the upgrade script to source

Fixed packaged body bug

    • -1
    • +1
    ./oracle/forums-reading-info-package-create.sql
add @forums-reading-info-package-create.sql script

    • -1
    • +2
    ./oracle/upgrade/upgrade-1.3d5-1.3d6.sql
add reading info creation scripts

creation

    • -0
    • +213
    ./oracle/forums-reading-info-package-create.sql