• last updated 4 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Fix typo

Handle correctly the indexing of moderated messages in fulltext search:

so far the fulltext search would also include unapproved messages and threads. With this reform we address this by:

- making sure unapproved threads are deleted from the index

- making sure new threads are added to the index only when the are approved

- making sure we unindex or reindex a thread whenever the approval state changes

- not fetching unapproved messages in the datasource callback, hence excluding them from the index

Note that Oracle has not been targeted by the reform. However, the situation improves for Oracle as well, because we won't render unmoderated messages in the datasource callback anymore.

    • -6
    • +59
    ./sql/postgresql/forums-sc-create.sql
file upgrade-1.4.0d3-1.4.0d4.sql was initially added on branch oacs-5-10.

    • -0
    • +0
    ./sql/postgresql/upgrade/upgrade-1.4.0d3-1.4.0d4.sql
improve listing of procs covered by regression test

  1. … 2 more files in changeset.
Prefer using 'user_info' over 'user_id' when calling 'acs::test::http'

Skip deprecated api that is neutralized by the next upgrade, reinstate deprecated api just for upgrade purposes, complies with acs-api-browser.graph__bad_calls automated test

Whitespace cleanup

improve listing of test coverage

  1. … 17 more files in changeset.
consider subject field restriction from the database also in the ui

improve spelling

  1. … 4 more files in changeset.
Reduce divergency between Oracle and Postgres codebase

make end of options explicit

  1. … 15 more files in changeset.
use bind variables instead of tcl variable substition in xql fullqueries

    • -2
    • +2
    ./www/moderate/move-thread-postgresql.xql
  1. … 14 more files in changeset.
New index on the forums_reading_info table

file upgrade-1.4d2-1.4d3.sql was initially added on branch oacs-5-10.

    • -0
    • +0
    ./sql/postgresql/upgrade/upgrade-1.4d2-1.4d3.sql
Whitespace cleanup

show notification controls only, when the request is not from a bot

Improve sql portability

  1. … 6 more files in changeset.
Improve sql portability

Fix typo

improve spelling

  1. … 15 more files in changeset.
prefer "ns_conn isconnected" over "ad_conn isconnected", since the latter might not notice changes in the connect state

  1. … 16 more files in changeset.
Kill message key translation only when the original user message is included in the notification

Do not kill localization for moderator notifications, as they contain indeed message keys to be localized

Implement a new type of "Moderator" notification type for forums

This notification will be triggered also by unapproved messages. The UI will show the subscription link only to forum moderators, using a different color (customizable via css, vanilla color is red). Message content will always be hidden for such notifications, so user will need to have access to new message.

Make clear where paragraph ends

Step in the direction of implementing a new kind of "moderator notification": move current notification behavior in a private api, remove dependency on message approval in message::new (also avoids a query)

Fix typo

Comment unused computations

Small refactoring