• last updated 2 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Reinstate the notnull validation constraint where missing

  1. … 10 more files in changeset.
re-add notnull value constraint on message_id

This constraint was removed about 14 days ago. Without this constraint,

errors like the following will show up....

[30/Aug/2022:14:07:29.820625][3102633.7f152c28d700][-conn:openacs.org:default:0:196214-] Error: rp_handler no-script-abort: errorMsg can't read "message(forum_id)": no such variable while serving GE

T /forums/message-view?message_id HTTP/1.1

: ad_url </forums/message-view> maps to file </var/www/openacs.org/packages/forums/www/message-view.adp>

: TCL LOOKUP VARNAME message

: can't read "message(forum_id)": no such variable

: while executing

: "forum::get -forum_id $message(forum_id) -array forum"

Probably, in many more cases, the incorrect removal of the notnull constrain performed by [1]

requires the same fix.

[1] https://github.com/openacs/forums/commit/c403e3134ce4e73ba94a80540a8b0f3cb1651ed0#diff-d35c736495ede0174fb39791ab660c5cd1a4ca467db2c4741cfc935167d7e5a8

Deprecate template::util::is_true, implemented as a simple string command oneliner since 2015 and inline occurrences

  1. … 33 more files in changeset.
forum_id is actually optional here

Harden page and include contracts using new acs-tcl feature

  1. … 21 more files in changeset.
harden page contract

passing properties consistently with @....;literal@

  1. … 12 more files in changeset.
passing properties consistently with @....;literal@

  1. … 43 more files in changeset.
passing properties consistently with @....;literal@ and not "noquote", since noquote content is already parsed

  1. … 14 more files in changeset.
add validation for message_id

add minimal permission check

remove "verify" from page contrace, since variables are NOT signed

hardened page contract

Replace the lame template::util::get_opts with some homemade utility that will parse arguments reliably, adjust the one upstream use case where arguments other than those documented might be passed to the element creation, introduce a warning when this happens somewhere else

  1. … 1 more file in changeset.
harden page contract

harden page contract

improving Oracle upgrade scripts

Oracle has no "ALTER TABLE ADD COLUMN ...."

Oracle has no "ALTER TABLE ADD COLUMN if exists .."

    • -1
    • +1
    ./sql/oracle/upgrade/upgrade-1.3-1.3d1.sql
  1. … 7 more files in changeset.
Do the transaction only if necessary

Break overlong lines

Replace reference to long-missing message key

Trap the attempt to retrieve a non-existing forum and return a 404 in this case

this might need to happen in other places and/or be refined

Revert escaped code

Fix default name

  1. … 1 more file in changeset.
improve spelling in .info files

  1. … 5 more files in changeset.
fix release dates in .info files

  1. … 82 more files in changeset.
release work

  1. … 204 more files in changeset.
fix recent editing bug

bump version numbers of 5.9|5.10 packages to 5.10.0b1

adjust dependencies

  1. … 87 more files in changeset.
improve spelling

  1. … 42 more files in changeset.
fixed categorization of test case

Add 'forum_enable_disable' test case, covering 'forum::enable' and 'forum::disable'