• last updated 23 mins ago
Constraints: committers
Constraints: files
Constraints: dates
Make use of new API "ad_mktmpdir" and "ad_opentmpfile" instead of "ad_tmpnam"

  1. … 4 more files in changeset.
Make service contract implementation private and replace foreign occurrences

  1. … 1 more file in changeset.
Whitespace changes

Make service contract implementation private: they are not meant to be invoked directly

Make service contract implementations private

Whitespace cleanup

Deprecate twt::user::create and twt::user::delete, superseded by their acs::test::user:: counterparts

  1. … 11 more files in changeset.
Fix self-inflicted bug: one should indeed be able to specify the same form var multiple time, test the behavior for the future

  1. … 2 more files in changeset.
Reimplement upload automated test using a real multipart request, as newer naviserver will reject handcrafted .tmpfile parameters

Bring test closer to reality

Test the behavior of the file-storage when a malicious user would try to store a pre-existing file on the server as its own

The fix for the file-storage is a simple validation to make sure that the tmpfile exists, however, for the generic case of the file widget, we cannot trust the tmpfile value when this was not generated by the server. This will probably cause regression when one wants to show a "preview" of a form, to be continued.

  1. … 2 more files in changeset.
Whitespace cleanup

acs::test::user::delete: added flag -delete_created_acs_objects and fix regression test for file-storage

  1. … 5 more files in changeset.
Fixes for Oracle 19c: more fixes of handling of Boolean values

ad_conn provides since a long time a fallback when the package_id is queried outside of a connection context, hence no need for these concerning catches

Make fs::get_file_package_id more robust to cases where the package_id is not set on the object itself: climb up the hierarchy

Reduce divergency between oracle and postgres codebase, bring together identical queries, fix typo in the xql file

    • -33
    • +1
    • -34
    • +2
Whitespace cleanup

  1. … 1 more file in changeset.
fix typo

Fix typo, increase api coverage

allow to specify max upload size in configuration file in KB or MB

Fix test category, add tested api

Fix typo, write a basic test for the involved api

  1. … 1 more file in changeset.
Fix typo

Make oacs-dav only a weak dependency for file-storage, if the package is not there, just treat it as if the parameter was disabled

  1. … 2 more files in changeset.
perform proper cleanup after the test

Avoid rollback in web tests

Avoid rollback in 'fs_add_file_to_folder' test in particular

Rollback after tests

fix error message