• last updated 18 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
merge from oacs-5-10

  1. … 8099 more files in changeset.
provide hint for the potential source of the problem

In error cases, sometimes code is executed, although there is no connection

to the client open. In such cases, this code should probable not executed.

fixed misleading documentation

added "button" class for activity links (port from downstream)

use downstream idiom

Simple fixes pointing to insufficient test cases

Many thanks to Franz Penz for the fixes

Quote user provided value in error message to eliminate potential XSS attack vector

Add callback hooks for archive, unarchive and delete. Thanks to Felix Moedritscher

  1. … 1 more file in changeset.
Make api public: uses public api internally and downstream packages use it

Reinstate get_portal_id_not_cached as private, replace occurrences with public api

  1. … 1 more file in changeset.
Make api public, complies with acs-api-browser.graph__bad_calls automated test

  1. … 4 more files in changeset.
overwork get_community_id once more. provide a shortcut is hopless situations, reduce potential warnings and improve comments

make clear that get_community_id_from_url needs connection in case no URL is provided; provide shortcut, when determined package_id is empty

  1. … 2 more files in changeset.
Fix log message, as ad_log supports only one message as argument.

Add "-url" as optional argument to "get_community_id" to ease usage in non-connection threads.

in background threads, get_community_id can be called with either the package_id,

or with the argument. Otherwise, the function is not background-safe

improve spelling

  1. … 4 more files in changeset.
Fix expression logic

Don't be so strict upstream, as here we do not restrict community_key to ltree

Constrain further the characters we allow in the community_key: makes sense upstream as this will become part of a URL, but is even more important downstream, as we implement the community_key as a ltree and therefore we are limited in the type of characters we can allow (See https://www.postgresql.org/docs/current/ltree.html)

Fix typo

Add missing arguments

Rework dotlrn_community::check_community_key_valid_p so that we check also for the community key to not have spaces

Logics have been moved to private api that might or might not become the preferrable api at some point, as it also returns the specific error message together with the boolean

  1. … 1 more file in changeset.
improve spelling

  1. … 6 more files in changeset.
improve spelling: move closer to the linux documentation recommendations

  1. … 7 more files in changeset.
Move rel_segments_* procs in new rel_segment:: namespace to comply with OpenACS naming convention, create deprecated wrappers, replace occurrences

  1. … 10 more files in changeset.
improve spelling

  1. … 3 more files in changeset.
improve spelling

  1. … 21 more files in changeset.
Replace ad_decode idioms

  1. … 2 more files in changeset.
Bring files on oacs-5-10 in sync with HEAD

  1. … 162 more files in changeset.
Fix incorrect default value