• last updated 9 hours ago
Constraints: committers
Constraints: files
Constraints: dates
strengthen boolean parameters in page contracts

  1. … 30 more files in changeset.
regenerated documentation

  1. … 295 more files in changeset.
prefer adp:icon over old-style .gif images

  1. … 11 more files in changeset.
Deprecate template::util::is_true, implemented as a simple string command oneliner since 2015 and inline occurrences

  1. … 33 more files in changeset.
Add include contract

  1. … 1 more file in changeset.
change_locale is actually a property of this master that is supplied by the slaves, not a part of the page contract

regenerated documentation

  1. … 464 more files in changeset.
improve spelling

  1. … 42 more files in changeset.
Final phasing out of acs_named_objects

- remove table creation

- update documentation

- provide an optional upgrade script to delete the table and the object type (commented out by default, as people might have defined object subtypes downstream).

Context: this table and the related machinery were created at a time where acs_objects where not as mature as they are now and would not include the "title" information. To retrieve the object name, the only option was the stored procedure acs_object.name, which was not scalable.

From an excerpt of the Changelog file:


2004-03-31 jeffd


* packages/categories/tcl/category-trees-procs-oracle.xql:

* packages/categories/tcl/category-trees-procs-postgresql.xql:

acs_named_objects superflous now that title is in

acs_objects. need to fix the rest of the occurances though


This tells us that the phasing out has already been decided back in 2004, but delayed. One technical reason, could be that the acs_named_objects table would also materialize the translation, while the title column would store sometimes a message key, that would need to be translated manually. This is helpful when e.g. sorting by name in sql. However, only the faq and categories package would seem to make any use of the table and only the faq package would seem to maintain its values... This would make some UIs in the categories package practically useless since a long time.

  1. … 6 more files in changeset.
Cleanup var, break overlong line

Rework of category UI:

- phase out usage of acs_named_objects, use object title instead

- rework pagination using builtin template::list features

- reduce hardcoded styling and markup

- rework strange database idioms

- remove divergency between oracle and postgres codebase

Formatting change

Refactor of category mapping UI:

- remove reference to obsolete and unmaintained acs_named_objects, which was preventing the UI to work in practice

- rework pagination and other idioms to long standing template::list best practices

- reduce hardcoded styling

    • -23
    • +0
remove dependency on ad_ns_set_keys

improve spelling: move closer to the linux documentation recommendations

  1. … 8 more files in changeset.
improve SQL quoting

  1. … 4 more files in changeset.
bugfix: when the property is set, creating a new category tree results in a error: ... supplied two values for 'locale'

tighten page contracts

  1. … 24 more files in changeset.
add ad_page_contract

Replace deprecated idioms on oacs-5-10

  1. … 1 more file in changeset.
Deprecate value_if_exists proc, replace occurrences with plain tcl idioms

  1. … 7 more files in changeset.
Whitespace cleanup

  1. … 1 more file in changeset.
improve spelling

  1. … 5 more files in changeset.
improve spelling

  1. … 12 more files in changeset.
Pass object_id to the include UI, make the include contract clear

  1. … 1 more file in changeset.
Take advantage of oldie utility template::util::list_to_multirow to refactor and simplify the code

Fix typo

Fix missing variable

Reduce divergency between oracle and postgres codebase

    • -20
    • +0
    • -20
    • +0
  1. … 3 more files in changeset.
Further document why people should not expect many results from this page