• last updated 17 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Check for errors on form before deciding which buttons to display, otherwise it will show the display-mode buttons instead of the edit-mode buttons when there are errors

Added template::widget::block for the new survey system.

Fixed display mode

Added richtext_or_file widget/datatype for use with CR items

    • -0
    • +308
    ./richtext-or-file-procs.tcl
My change to use the richtext API had a bug

Cleaned up richtext datatype, to use core.js and add documentation

Wrap the value in the generated code, so you can have values that contain space (broke when I tried to do a case tag with member_state of 'needs approval').

Refactored template::data::transform::file so the mechanism that gets .tmpfile and .content-type from the page form can be reused.

Made spellcheck use the API for richtext datatype, instead of hardcoding knowledge about its internal representation

merge of changes between oacs-5-0-0b4 and oacs-5-0-0-final to HEAD

  1. … 283 more files in changeset.
Moved setting of ad_conn subsite_id to the ad_conn proc itself, so it'll always be set, and not just for tcl/adp files

  1. … 1 more file in changeset.
wizard::create needs to set wizard:columns variable for template:multirow proc to work

Added provision for sorting in Tcl using template::multirow sort

Fixed bug in template::multirow sort - forgot to set the rownum attribute

Template engine now localizes message strings embedded within @variables@

- Killed the automatic handling of back-buttons in the wizard, since it causes the form to not save changes when you hit back

- Allowed 'wizard get_current_step' to take an optional starting step, which can depend on the state

Added @see comments

Do lc_numeric on group/totals

Added a template::multirow sort command option

- Support for synonyms for richtext properties

- Error when illegal property specified

all TCL's clock clicks always with the -milliseconds option. The TCL manual

explicitly states that without this switch the return result is platform

dependant. The OpenACS code works at the millisecond granulartiy and silently

assumes that 1 millisecond equals 1000 clicks which is not necessarily true.

I used this shell script to automatize the replacing:

#!/bin/bash

for file in `grep -lsr "\[clock clicks\]" /web/openacs-head/packages/ `; do

echo "repairing $file"

sed "s/\[clock clicks\]/\[clock clicks -milliseconds\]/g" $file > fout

mv fout $file

done

And then grepped for

grep -r "expr.*clock clicks" /web/openacs-head/packages/

to manually remove the divisions by 1000.

  1. … 9 more files in changeset.
Make set_ and get_property emit an error instead of silently failing when specifying a non-existing property name. Some api-documentation.

Make set_ and get_property emit an error instead of silently failing when specifying a non-existing property name. Some api-documentation.

Clarifying api-documentation.

Make set_ and get_property emit an error instead of silently failing when specifying a non-existing property name. Some api-documentation.

Wrapping the output of element::render in [string trim] so that it doesn't pre- or append spaces before the output, to avoid borking html layouts that depend on having no spaces in the form, e.g. so that input elements don't get wrapped inside a td tag.

Only trim value in set_property when setting single-value properties, otherwise 0000-01-01 will get munged into -01-01, causing ansi property to fail

- Added 'ansi' to date::get_property

- Fixed error in date::set_property ansi, where the error thrown had a reference to the wrong variable

bugfix in template::element::set_values proc. It should set element(values) to the passed in list of values, not a list containing the passed in list.

- Default multirow to list-template name.

- Throw error if you're providing bulk_actions, but haven't set the key