• last updated 33 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Rework array idioms into dict idioms where appropriate

Prefer unset to array unset when the semantic is to delete the whole array

See https://wiki.tcl-lang.org/page/Dict+VS+Array+Speed

merge with missing files

  1. … 1458 more files in changeset.
merge from oacs-5-10

  1. … 8090 more files in changeset.
fixed cleanup for scheduled emails to avoid interference with immediate send operations

Delete the scheduled email after running the test case

Fix typo in doc

::acs_mail_lite::configured_p: check, if we can connect to the mail server

This new function has the goal to centralize tests to check, whether

the SMTP server is properly configured and ready to accept mail

requests. This is currently just used in the regression test to skip

hopeless tests.

Later, we should extend the regression test to test whether

sending of real emails works.

fixed regression test, when mailserver is not yet set up (nssmtpd only)

bugfix: provide proper encoding for text phrases in email addresses

Previously, mails to addresses of the form

PHRASE <USER@HOST>

where PHRASE contains UTF-8 were sent without the required encoding.

One many systems, this was perfectly fine, but on some, these

where leading to mangled characters. Now, the "to_addr" adresseses

and the "from_addr" address of acs_mail_lite::send_immediately

are properly encoded. Note, that "to_addr" is a list of addresses.

Many thanks to Franz Penz for reporting this.

improved spelling

  1. … 2 more files in changeset.
Basic test of acs_mail_lite::send

file acs-mail-lite-procs.tcl was initially added on branch oacs-5-10.

    • -0
    • +0
    ./test/acs-mail-lite-procs.tcl
Make acs_mail_lite::utils::build_body, replace (commented) references in other packages

  1. … 1 more file in changeset.
improve spelling

Deprecate template::util::is_true, implemented as a simple string command oneliner since 2015 and inline occurrences

  1. … 33 more files in changeset.
replace occurrences of <br/> in api doc strings

  1. … 2 more files in changeset.
Properly escape "<" and ">" in api-doc documentation.

Since all documentation is rendered via HTML, the characters

"<" and ">" have to be HTML-quoted, otherwise strange things

(omission, unintended renderings) might occur.

E.g. the sentence

Define an interface between a page and an

ADP <include> similar to the page_contract.

was rendered as

Define an interface between a page and an

ADP similar to the page_contract.

which is incorrect.

  1. … 11 more files in changeset.
improve spelling

Reduce number of queries, improve documentation

Queries could be made even less e.g. by locking and querying the tuples in one statement. However, it would be trickyer to make the code portable.

Simplify nsv idiom

Simplify documentation

Fix typo in doc

Fixes for Oracle 19c: replaced "limit" by the portable idiom "fetch ... rows only"

This fixes the following bug in Oracle installations:

: SQL:

: select aml_email_id from acs_mail_lite_from_external

: where processed_p <>'1'

: and release_p <>'1'

: order by priority

: !>>>!limit :email_max_ct

: nsoracle.c:1367:OracleSelect: error in `OCIStmtExecute ()': ORA-00933: SQL command not properly ended

Deprecate util_ns_set_to_list: ns_set array is an equivalent oneliner

  1. … 4 more files in changeset.
improve spelling

  1. … 42 more files in changeset.
fix for issue #3463

Many thanks to Tony Kirkham for the fix!

Replace deprecated 'acs_mail_lite::utils::valid_email_p' with 'util_email_valid_p'

Deprecate 'acs_mail_lite::utils::valid_email_p', as it is duplicated by 'util_email_valid_p'. It was not deleted because it was a public proc recently turned to private.

reduce public footprint