OpenACS / openacs-4 / packages

acs-kernel

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 58
Last Commit: 21 Nov
Commits this week: 0
Total Lines of Code (LoC): 90,115
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 5 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 06 Jul 2022
5:37 pm

gustafn

added ADP:ICON to the list of accepted tags (for new instances)

Options
    • -3
    • +3
    ./acs-kernel.info
  2. … 1 more file in changeset.
Wednesday 02 Mar 2022
6:41 pm

gustafn

Improve robustness of upgrade script for legacy applications

In case, an installation has the legacy view (must be from very old installations)

in place, it is necessary to drop it before registered_users, otherwise

PostgreSQL will complain that it cannot drop view registered_users because

other objects depend on it.

Many thanks to Franz Penz to report this potential problem for old sites.

Options
    • -1
    • +7
    ./sql/postgresql/upgrade/upgrade-5.10.0-5.10.1d1.sql
Wednesday 23 Feb 2022
7:24 pm

gustafn

Align names used in utility db functions in Oracle and PostgreSQL

Over the years, the names used in the function for PostgreSQL and

Oracle drifted away, which is a problem when using call-by-name

convention for stored procedures. Furthermore, recent Oracle versions

do not allow attributes named "table" (for table_name). So the longer

version is now used uniformily. Fortunately, nsf allow abbreviation

for named parameters (like Tcl does), such one can use both

"-table_name" and "-table".

Bumped version number to 5.10.1d7.

Options
    • -2
    • +2
    ./acs-kernel.info
    • -6
    • +6
    ./sql/oracle/utilities-create.sql
    • -0
    • +312
    ./sql/oracle/upgrade/upgrade-5.10.1d6-5.10.1d7.sql
    • -158
    • +157
    ./sql/postgresql/utilities-create.sql
    • -0
    • +167
    ./sql/postgresql/upgrade/upgrade-5.10.1d6-5.10.1d7.sql
7:24 pm

gustafn

file upgrade-5.10.1d6-5.10.1d7.sql was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    ./sql/oracle/upgrade/upgrade-5.10.1d6-5.10.1d7.sql
    • -0
    • +0
    ./sql/postgresql/upgrade/upgrade-5.10.1d6-5.10.1d7.sql
Monday 21 Feb 2022
6:57 pm

gustafn

file upgrade-5.10.1d5-5.10.1d6.sql was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    ./sql/postgresql/upgrade/upgrade-5.10.1d5-5.10.1d6.sql
6:53 pm

gustafn

fix broken function_args definition

Options
    • -2
    • +2
    ./acs-kernel.info
    • -2
    • +2
    ./sql/postgresql/security-create.sql
    • -0
    • +2
    ./sql/postgresql/upgrade/upgrade-5.10.1d5-5.10.1d6.sql
  4. … 3 more files in changeset.
Thursday 17 Feb 2022
11:36 am

gustafn

Fixes for Oracle 19c: uppercase consistently in schema queries

All names in the schema data model are in Oracle in uppercase.

Options
    • -8
    • +8
    ./sql/oracle/utilities-create.sql
11:27 am

gustafn

Fixes for Oracle 19c: fixed more cases with Problems with Boolean data types

This fixes e.g. the following problem

[16/Feb/2022:20:55:19][3908.7fa5364fa700][-conn:oacs-5-10-0:default:1:9-] Error: SQL(): nsoracle.c:863:OracleExecPLSQLBind: error in `OCIStmtExecute ()': ORA-06550: line 1, column 13:

: PLS-00382: expression is of wrong type

: ORA-06550: line 1, column 7:

: PL/SQL: Statement ignored

:

: SQL: BEGIN :1 := util.foreign_key_exists(table_name => :table_name,column => :column,reftable => :reftable,refcolumn => :refcolumn); END;

[16/Feb/2022:20:55:19][3908.7fa5364fa700][-conn:oacs-5-10-0:default:1:9-] Notice: ### db_with_handle returned error <nsoracle.c:863:OracleExecPLSQLBind: error in `OCIStmtExecute ()': ORA-06550: line 1, column 13:

: PLS-00382: expression is of wrong type

: ORA-06550: line 1, column 7:

: PL/SQL: Statement ignored

:

Options
    • -173
    • +113
    ./sql/oracle/utilities-create.sql
Wednesday 16 Feb 2022
8:55 pm

gustafn

Fixes for Oracle 19c: output potential errors after command

Options
    • -1
    • +4
    ./sql/oracle/utilities-create.sql
7:45 pm

gustafn

Fixes for Oracle 19c:

- types defined inside an package cannot be used from the outside;

so utility function get_primary_keys() was not usable

- fix various problems with boolean values

Two sample errors raised before the fix:

[16/Feb/2022:16:12:52][20833.7fa027de8940][-main:oacs-5-10-0-] Error: SQL(): nsoracle.c:863:OracleExecPLSQLBind: error in `OCIStmtExecute ()': ORA-06550: line 1, column 13:

: PLS-00382: expression is of wrong type

: ORA-06550: line 1, column 7:

: PL/SQL: Statement ignored

:

: SQL: BEGIN :1 := util.table_column_exists(t_name => :t_name,c_name => :c_name); END;

16/Feb/2022:18:16:39][27419.7fb7a518a940][-main:oacs-5-10-0-] Error: SQL(): nsoracle.c:863:OracleExecPLSQLBind: error in `OCIStmtExecute ()': ORA-06550: line 1, column 13:

: PLS-00382: expression is of wrong type

: ORA-06550: line 1, column 7:

: PL/SQL: Statement ignored

:

: SQL: BEGIN :1 := util.get_primary_keys(table_name => :table_name); END;

[16/Feb/2022:18:16:39][27419.7fb7a518a940][-main:oacs-5-10-0-] Notice: ### db_with_handle returned error <nsoracle.c:863:OracleExecPLSQLBind: error in 'OCIStmtExecute ()': ORA-06550: line 1, column 13:

: PLS-00382: expression is of wrong type

: ORA-06550: line 1, column 7:

: PL/SQL: Statement ignored

:

: SQL: BEGIN :1 := util.get_primary_keys(table_name => :table_name); END;> for statement

: #:log "sql=BEGIN :1 := util.get_primary_keys($sql_args); END;, sql_command=ns_ora exec_plsql_bind $db $sql 1 """

: return [ ns_ora exec_plsql_bind $db $sql 1 "" ]

:

Options
    • -18
    • +21
    ./sql/oracle/utilities-create.sql
Sunday 13 Feb 2022
4:45 pm

gustafn

Fixes for Oracle 19c for membership and composition triggers

Warning: Trigger created with compilation errors.

Errors for TRIGGER MEMBERSHIP_RELS_IN_TR:

LINE/COL ERROR

-------- -----------------------------------------------------------------

14/3 PL/SQL: SQL Statement ignored

16/3 PL/SQL: ORA-00947: not enough values

32/3 PL/SQL: Statement ignored

32/6 PLS-00201: identifier 'V_COMPOSABLE_P' must be declared

Trigger created.

No errors.

Warning: Trigger created with compilation errors.

Errors for TRIGGER COMPOSITION_RELS_IN_TR:

LINE/COL ERROR

-------- -----------------------------------------------------------------

72/21 PL/SQL: SQL Statement ignored

72/48 PL/SQL: ORA-00918: column ambiguously defined

83/7 PL/SQL: Statement ignored

83/47 PLS-00364: loop index variable 'MEMBERS' use is invalid

86/5 PL/SQL: SQL Statement ignored

91/6 PL/SQL: ORA-00918: column ambiguously defined

Trigger created.

No errors.

Options
    • -4
    • +5
    ./sql/oracle/groups-body-create.sql
    • -3
    • +5
    ./sql/oracle/upgrade/upgrade--5.9.1d15-5.9.1d16.sql
2:21 pm

gustafn

The composite_p attribute for acs_object_type.create_type() was missing

This fixes in essence the following errors.

acs_rel_type.create_type (

*

ERROR at line 35:

ORA-06550: line 35, column 2:

PLS-00306: wrong number or types of arguments in call to 'CREATE_TYPE'

ORA-06550: line 35, column 2:

PL/SQL: Statement ignored

ORA-06550: line 54, column 2:

PLS-00306: wrong number or types of arguments in call to 'CREATE_TYPE'

ORA-06550: line 54, column 2:

PL/SQL: Statement ignored

ORA-06550: line 70, column 2:

PLS-00306: wrong number or types of arguments in call to 'CREATE_TYPE'

ORA-06550: line 70, column 2:

PL/SQL: Statement ignored

No errors

insert into group_type_rels

*

ERROR at line 1:

ORA-02291: integrity constraint (OPENACS.GROUP_TYPE_RELS_GROUP_TYPE_FK)

violated - parent key not found

insert into group_type_rels

*

ERROR at line 1:

ORA-02291: integrity constraint (OPENACS.GROUP_TYPE_RELS_GROUP_TYPE_FK)

violated - parent key not found

Options
    • -5
    • +9
    ./sql/oracle/acs-relationships-create.sql
    • -5
    • +5
    ./sql/oracle/groups-create.sql
Saturday 12 Feb 2022
9:13 pm

gustafn

providing compatibility with Oracle 19c

Either these scripts never worked for Oracle, or these Oracle changed over the years

Options
    • -2
    • +2
    ./sql/oracle/acs-relationships-create.sql
    • -24
    • +31
    ./sql/oracle/utilities-create.sql
9:11 pm

gustafn

improving Oracle upgrade scripts

Oracle has no "ALTER TABLE ADD COLUMN ...."

Oracle has no "ALTER TABLE ADD COLUMN if exists .."

Options
    • -1
    • +1
    ./sql/oracle/upgrade/upgrade--5.9.1d15-5.9.1d16.sql
  2. … 8 more files in changeset.
Monday 06 Dec 2021
10:43 am

gustafn

Improve spelling

Options
    • -1
    • +1
    ./sql/postgresql/upgrade/upgrade-5.10.0d3-5.10.0d4.sql
    • -1
    • +1
    ./sql/postgresql/upgrade/upgrade-5.9.1d10-5.9.1d11.sql
10:42 am

gustafn

Fixed update script for applications having the view "upgrade-5.10.0-5.10.1d1.sql" not defined.

This view is a legacy view ancient times, which is no included in standard installations

since ages.... It was however defined on openacs.org.

--

-- Some legacy applications might contain still the VIEW

-- "registered_users_of_package_id", which is defined in

--

-- acs-subsite/sql/postgresql/user-profiles-create.sql

--

-- This file is NOT included in new installations since over 20 years,

-- so it is not maintained and treated as a leftover from ancient

-- times. Therefore, the view registered_users_of_package_id is not

-- recreated by this update script.

Options
    • -7
    • +20
    ./sql/postgresql/upgrade/upgrade-5.10.0-5.10.1d1.sql
Sunday 05 Dec 2021
5:13 pm

gustafn

improve spelling

Options
    • -2
    • +2
    ./acs-kernel.info
    • -1
    • +1
    ./catalog/acs-kernel.de_DE.ISO-8859-1.xml
  3. … 9 more files in changeset.
Wednesday 27 Oct 2021
2:47 pm

gustafn

refresh also "registered_users_of_package_id", which seems required on some (?) sites

Options
    • -0
    • +10
    ./sql/postgresql/upgrade/upgrade-5.10.0-5.10.1d1.sql
Tuesday 12 Oct 2021
11:27 am

hectorr

Fix default name

Options
    • -1
    • +1
    ./acs-kernel.info
  2. … 3 more files in changeset.
Monday 11 Oct 2021
10:11 pm

gustafn

Refactored and streamlined of cluster infrastructure

- base the API new new cluster infrastructure (including memoize-flush, server_cluster_peer_hosts, etc.)

- improved handling for multiple IP addresses and IPv6

- removed assumptions of local vs. global network drivers

- server_cluster_httpget_from_peers not used anymore

Options
    • -1
    • +1
    ./acs-kernel.info
  2. … 5 more files in changeset.
Sunday 03 Oct 2021
8:20 pm

gustafn

improve spelling in .info files

Options
    • -1
    • +1
    ./acs-kernel.info
  2. … 5 more files in changeset.
8:14 pm

gustafn

fix typo

Options
    • -1
    • +1
    ./acs-kernel.info
8:13 pm

gustafn

added support for SCRYPT (RFC 7914) as password hash function.

The use of scrypt requires NaviServer compiled with OpenSSL 3.0 or newer

Options
    • -3
    • +3
    ./acs-kernel.info
  2. … 1 more file in changeset.
Friday 01 Oct 2021
9:30 am

gustafn

file upgrade-5.10.1d2-5.10.1d3.sql was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    ./sql/oracle/upgrade/upgrade-5.10.1d2-5.10.1d3.sql
    • -0
    • +0
    ./sql/postgresql/upgrade/upgrade-5.10.1d2-5.10.1d3.sql
9:30 am

gustafn

stick to the original names with the "-" since this is also the naming convention outside of OpenACS (e.g. "scram-sha-256")

Options
    • -2
    • +2
    ./acs-kernel.info
    • -2
    • +2
    ./sql/oracle/community-core-create.sql
    • -0
    • +9
    ./sql/oracle/upgrade/upgrade-5.10.1d2-5.10.1d3.sql
    • -2
    • +2
    ./sql/postgresql/community-core-create.sql
    • -0
    • +10
    ./sql/postgresql/upgrade/upgrade-5.10.1d2-5.10.1d3.sql
  6. … 3 more files in changeset.
Wednesday 29 Sep 2021
2:09 pm

antoniop

file upgrade-5.10.1d1-5.10.1d2.sql was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    ./sql/oracle/upgrade/upgrade-5.10.1d1-5.10.1d2.sql
    • -0
    • +0
    ./sql/postgresql/upgrade/upgrade-5.10.1d1-5.10.1d2.sql
2:09 pm

antoniop

Complete reform introduced in https://cvs.openacs.org/changelog/OpenACS?cs=oacs-5-10%3Agustafn%3A20210928124647

- add datamodel change to the creation script

- refactor algorithm names in a way that the new procs will comply with acs-tcl.naming__proc_naming automated test

Options
    • -3
    • +3
    ./acs-kernel.info
    • -2
    • +4
    ./sql/oracle/community-core-create.sql
    • -0
    • +9
    ./sql/oracle/upgrade/upgrade-5.10.1d1-5.10.1d2.sql
    • -2
    • +4
    ./sql/postgresql/community-core-create.sql
    • -0
    • +10
    ./sql/postgresql/upgrade/upgrade-5.10.1d1-5.10.1d2.sql
  6. … 2 more files in changeset.
Tuesday 28 Sep 2021
2:46 pm

gustafn

file upgrade-5.10.0-5.10.1d1.sql was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    ./sql/oracle/upgrade/upgrade-5.10.0-5.10.1d1.sql
    • -0
    • +0
    ./sql/postgresql/upgrade/upgrade-5.10.0-5.10.1d1.sql
2:46 pm

gustafn

Stronger password hashes for OpenACS

This change introduces the possibility to use either the classical

OpenACS password hash algorithm "salted-sha1" or the SCRAM passord

function "scram-sha-256". The latter can be used by (a) using the

most recent version of NaviServer (from Sept 28, 2021 or newer) and

(b) by configuring the password hash preferences via Kernel package

parameter "PasswordHashAlgorithm". The package parameter can contain a

list of multiple hash algorithms in preference order. The most

preferred available algorithm is chosen.

By default, the "PasswordHashAlgorithm" is "salted-sha1", and the

behavior is as before. After upgrading to the new version of acs-tcl

and acs-kernel, the preference list can be configured. When a user

logs in and the preferred available algorithm is different from the

previously used algorithm, the upgrade is performed for the user

automatically.

The usage of SHA1 in OpenACS is easily target of security audits (see

[1]). The biggest danger is that if somebody gets full access to the

"users" table (e.g. when decommissioning a hard disk). In this case

the hashes can be attacked with dictionaries by using some crypto

hardware (when someone gets raw access to the DB, one has usually some

other big problems). However, by using the "scram-sha-256" hash

function this danger is substantially reduced. This function computes

a password hash using PBKDF2 (Password-Based Key Derivation Function

2). This function is used to reduce vulnerabilities of brute-force

attacks against password hashes. The hash function of SCRAM is PBKDF2

[RFC2898] with HMAC as the pseudorandom function (PRF) and with dkLen

== output length of HMAC == output length of the digest function. So,

it uses a better hash algorithm (sha-256 vs. sha1) and applies this a

high number of times (15K times for a password hash computation).

NaviServer supports as well the even better SCRYPT algorithm, but this

is only available when NaviServer is compiled with OpenSSL 3.0 or

newer. On the contrary, scram-sha-256 (actually PKCS5_PBKDF2_HMAC) is

available since OpenSSL 1.0.0 (2015).

All the improved hash functions require NaviServer with its tight

integration to the crypto functions of OpenSSL.

[1] https://openacs.org/forums/message-view?message_id=5522562

Options
    • -2
    • +3
    ./acs-kernel.info
    • -0
    • +57
    ./sql/oracle/upgrade/upgrade-5.10.0-5.10.1d1.sql
    • -0
    • +47
    ./sql/postgresql/upgrade/upgrade-5.10.0-5.10.1d1.sql
  4. … 4 more files in changeset.
Thursday 16 Sep 2021
10:27 am

gustafn

fix release dates in .info files

Options
    • -1
    • +1
    ./acs-kernel.info
  2. … 82 more files in changeset.