acs-content-repository

  • last updated 3 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Cleanup of external binaries: always use "util::which" to resolve binaries

Furthermore, this change makes the handling of "identify" consistent

with "convert". Before, the parameter "ImageMagickIdentifyBinary"

could not be modified via the parameter settings, only

"ImageMagickConvertBinary" was defined.

Bump version number to 5.10.1b3 to pick up additional parameter.

Handle differences in data-model between oracle and postgres, where oracle uses an additional filename column in the cr_revisions table when a revision points to a file

Many thanks to Josue Cardona for reporting the regression

Increase proc coverage

    • -1
    • +31
    ./tcl/test/content-revision-test-procs.tcl
Reitroduce missing query clause that should be executed when we retrieve the content of a text/* content item

    • -0
    • +7
    ./tcl/content-item-procs-postgresql.xql
Test that when content::item::get_content is called on a text/* mime typed content-item, an extra "text" attribute should be returned in the result array

This currently fails because of a missing query in the xql

    • -1
    • +10
    ./tcl/test/content-item-test-procs.tcl
Redefine content_item__get_virtual_path so that get_virtual_path__root_folder_id argument is not ignored

file upgrade-5.10.1b1-5.10.1b2.sql was initially added on branch oacs-5-10.

    • -0
    • +0
    ./sql/postgresql/upgrade/upgrade-5.10.1b1-5.10.1b2.sql
Test content::item::get_virtual_path

This will expose a logn standing bug where the root_folder_id argument is ignored

    • -1
    • +26
    ./tcl/test/content-item-test-procs.tcl
Extend test suite

    • -1
    • +14
    ./tcl/test/content-item-test-procs.tcl
Test content::item::get_root_folder

    • -1
    • +27
    ./tcl/test/content-item-test-procs.tcl
Remove broken line (non-existing arguments)

Increase api coverage, this uncovered a bug in content::item::unpublish

    • -1
    • +24
    ./tcl/test/content-item-test-procs.tcl
Test content::item::get_publish_date

    • -4
    • +34
    ./tcl/test/content-item-test-procs.tcl
Extend test to include content::item::get_path

    • -4
    • +27
    ./tcl/test/content-item-test-procs.tcl
Whitespace cleanup

    • -3
    • +3
    ./tcl/test/content-item-test-procs.tcl
Test content::item::get_descendants

    • -1
    • +115
    ./tcl/test/content-item-test-procs.tcl
harden page contracts

  1. … 24 more files in changeset.
bumped version numbers to 5.10.1b1

  1. … 85 more files in changeset.
regenerated documentation

  1. … 281 more files in changeset.
Disable tests to check for executables on the system

    • -16
    • +20
    ./tcl/test/acs-content-repository-procs.tcl
  1. … 7 more files in changeset.
Prefer binary from parameter as everywhere else

Test external command line dependencies

    • -1
    • +17
    ./tcl/test/acs-content-repository-procs.tcl
fix incorrect names in .xql files

Fixed missing update_content-lob.set_content

Added missing set_content SQL statement for updating revisions stored in LOBs.

This statement was already missing in the release of OpenACS 5.10.0.

LOBs are for PostgreSQL somewhat depreacted and these are just there for

legacy applications.

    • -2
    • +9
    ./tcl/content-revision-procs-postgresql.xql
improve spelling

  1. … 9 more files in changeset.
Replaced "ns_mktemp" by "ad_tmpnam" to ease code maintenance

The underlying C library API for "ns_mktemp" is deprecated

for security reasons, we will have to do something about it.

    • -2
    • +2
    ./tcl/test/content-image-test-procs.tcl
    • -2
    • +2
    ./tcl/test/content-item-test-procs.tcl
  1. … 5 more files in changeset.
Add vtt mime type to CR

    • -0
    • +45
    ./sql/oracle/upgrade/upgrade-5.10.1d4-5.10.1d5.sql
file upgrade-5.10.1d4-5.10.1d5.sql was initially added on branch oacs-5-10.

    • -0
    • +0
    ./sql/oracle/upgrade/upgrade-5.10.1d4-5.10.1d5.sql
    • -0
    • +0
    ./sql/postgresql/upgrade/upgrade-5.10.1d4-5.10.1d5.sql
Deprecate content::revision::update_attribute_index

Fix doc