OpenACS / openacs-4 / packages / acs-bootstrap-installer

tcl

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 22
Last Commit: 20 Dec
Commits this week: 0
Total Lines of Code (LoC): 4,118
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 13 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 01 Mar 2021
11:43 am

gustafn

reduce the number of locks (nsv-accesses) for OACS_FULLQUERIES by a factor of 3 when NaviServer is used.

OACS_FULLQUERIES is one of the 3 most intensively locked nsv arrays for

busy implementation

Options
    • -20
    • +52
    ./40-db-query-dispatcher-procs.tcl
11:12 am

gustafn

improve test coverage

Options
    • -3
    • +41
    ./test/00-proc-procs.tcl
11:11 am

gustafn

reduce visibility of internal functions

Options
    • -4
    • +4
    ./40-db-query-dispatcher-procs.tcl
10:26 am

gustafn

move function db_current_rdbms to acs-bootstrap installer to improve code locality

Options
    • -2
    • +6
    ./40-db-query-dispatcher-procs.tcl
  2. … 1 more file in changeset.
10:19 am

gustafn

Cleanup of low-level DB-interace: use dict instead of list with fixed positions

VS: ----------------------------------------------------------------------

Options
    • -28
    • +48
    ./40-db-query-dispatcher-procs.tcl
  2. … 3 more files in changeset.
Saturday 27 Feb 2021
11:25 pm

gustafn

Added support for trailing non-positional arguments

The change makes the old hack with the own trailing-argument-parser

"ad_arg_parser" obsolete by using directly the c-level argument parser

which is anyhow capable of handling trailing arguments. A few changes

were necessary for api doc to handle there trailing arguments as well.

The proc "db_string" is already converted to use native arguments.

Options
    • -7
    • +16
    ./00-proc-procs.tcl
  2. … 7 more files in changeset.
7:03 pm

gustafn

added a comment about the usefulness of ad_arg_parser

Options
    • -1
    • +10
    ./00-proc-procs.tcl
6:48 pm

gustafn

Fix for issue #3442 to support range types in .xql files

PostgreSQL supports range types since 9.5. When using range types,

square braces have to be used in SQL statements. Since OpenACS uses

always Tcl substitution in .xql files, and OpenACS does NOT allow

backslash substitution in these files, square brackets could not be

escaped and therefore not be used in .xql files so far. This change

allows now a developer to deactivate the substitution by passing

e.g. "-subst none" to the db_* command using the .xql file. Valid

values for "-subst" are "all", "none", "vars", and "commands", default

is "all" which is exactly the behavior of before. Therefore, this

change is fully backward compatible.

Options
    • -3
    • +19
    ./40-db-query-dispatcher-procs.tcl
  2. … 3 more files in changeset.
Wednesday 24 Feb 2021
5:00 am

gustafn

reduce the size of the public interface

Options
    • -4
    • +4
    ./00-proc-procs.tcl
    • -1
    • +1
    ./20-db-bootstrap-procs.tcl
    • -10
    • +10
    ./40-db-query-dispatcher-procs.tcl
Monday 22 Feb 2021
6:13 pm

gustafn

whitespace changes: break overlong lines

Options
    • -150
    • +176
    ./40-db-query-dispatcher-procs.tcl
5:56 pm

gustafn

make clear from the name that db_qd_prepare_queryfile_content is intended to be used in different packages

Options
    • -7
    • +6
    ./40-db-query-dispatcher-procs.tcl
  2. … 2 more files in changeset.
4:19 pm

antoniop

Make api public, complies with acs-api-browser.graph__bad_calls automated test

Options
    • -1
    • +1
    ./20-db-bootstrap-procs.tcl
  2. … 4 more files in changeset.
4:08 pm

antoniop

Make api public, complies with acs-api-browser.graph__bad_calls automated test

Options
    • -3
    • +3
    ./30-apm-load-procs.tcl
  2. … 3 more files in changeset.
3:14 pm

antoniop

Make proc public (it is used in a test is acs-tcl)

Complies with acs-api-browser.callgraph__bad_calls

Options
    • -2
    • +2
    ./40-db-query-dispatcher-procs.tcl
3:05 pm

antoniop

Whitespace cleanup

Options
    • -69
    • +69
    ./40-db-query-dispatcher-procs.tcl
Friday 19 Feb 2021
11:14 am

gustafn

include package key in proc info

Options
    • -1
    • +6
    ./00-proc-procs.tcl
Thursday 18 Feb 2021
3:41 pm

gustafn

mark functions called only internally as private

Options
    • -2
    • +2
    ./00-proc-procs.tcl
  2. … 15 more files in changeset.
Tuesday 16 Feb 2021
3:31 am

gustafn

just avoid tilde substitution, do not perform sanitizing

sanitizing can lead to file name clashes in case the names

without tilde exists, and they are OS specific. The intention

of "ad_file" is just to be a tilde-proof "file" replacement

Options
    • -2
    • +4
    ./00-proc-procs.tcl
    • -5
    • +42
    ./test/00-proc-procs.tcl
Monday 15 Feb 2021
3:23 pm

antoniop

Sanitize all trailing tildes from the filename, mapping them to the current folder

Fixes acs-bootstrap-installer.ad_file automated test

Options
    • -4
    • +2
    ./00-proc-procs.tcl
3:13 pm

hectorr

Make 'ad_file' test case deterministic

Options
    • -1
    • +1
    ./test/00-proc-procs.tcl
2:47 pm

antoniop

Automated test for ad_file exposing a blind spot with files starting with the '~' character

Options
    • -0
    • +27
    ./test/00-proc-procs.tcl
2:47 pm

antoniop

file 00-proc-procs.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    ./test/00-proc-procs.tcl
Sunday 14 Feb 2021
10:08 pm

gustafn

improve spelling

Options
    • -1
    • +10
    ./00-proc-procs.tcl
    • -4
    • +8
    ./30-apm-load-procs.tcl
    • -10
    • +12
    ./40-db-query-dispatcher-procs.tcl
  4. … 2 more files in changeset.
Saturday 21 Nov 2020
6:39 pm

gustafn

allow value checkers in ad_procs

Options
    • -7
    • +25
    ./00-proc-procs.tcl
Wednesday 28 Oct 2020
4:39 pm

hectorr

Prefer 'namespace which' over 'info commands', as it is faster (on local tests, around 2x) and returns a single value. Many thanks to Nathan Coulter.

Options
    • -3
    • +3
    ./00-proc-procs.tcl
    • -2
    • +2
    ./30-apm-load-procs.tcl
    • -4
    • +4
    ./40-db-query-dispatcher-procs.tcl
  4. … 56 more files in changeset.
Wednesday 12 Aug 2020
3:31 pm

antoniop

Treat callback hooks and implementations as private api

Options
    • -1
    • +9
    ./00-proc-procs.tcl
Friday 24 Jul 2020
1:50 pm

antoniop

Reduce acs-tcl.documentation__check_deprecated_see test warnings

Options
    • -1
    • +5
    ./00-proc-procs.tcl
  2. … 2 more files in changeset.
Monday 13 Jul 2020
2:02 pm

gustafn

introduced "ad_file" as a means to avoid unexpected tilde substitution in file names

Options
    • -5
    • +26
    ./00-proc-procs.tcl
    • -1
    • +1
    ./20-db-bootstrap-procs.tcl
    • -23
    • +29
    ./30-apm-load-procs.tcl
    • -2
    • +2
    ./40-db-query-dispatcher-procs.tcl
  5. … 47 more files in changeset.
Saturday 11 Jul 2020
1:56 pm

gustafn

deprecate unused function

Options
    • -2
    • +2
    ./00-proc-procs.tcl
Friday 31 Jan 2020
7:23 pm

hectorr

Restrict switches to not negative Tcl numbers, and avoid non-printable characters as well

Options
    • -3
    • +7
    ./00-proc-procs.tcl