• last updated 21 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Reduce divergency between oracle and postgres

  1. … 3 more files in changeset.
Reduce divergency between oracle and postgres codebase

provide a default for pass_through option

add comment and sanity check

fix fresh installation of dotlrn by adding a pass-through parameter to member-state-change

  1. … 3 more files in changeset.
make clear, that just portrait_title is used

pull out 2 queries from .xql to tcl improve readability

fix invalid HTML (closing INPUT tag is not allowed)

  1. … 4 more files in changeset.
Ehm.. revert previous commit: search would use service contract to get the search form, so we should no assume local-search to be used...

  1. … 4 more files in changeset.
Removal of obsolete user search includes

Rationale:

- no mention to these pages anywhere in upstream packages

- local-search fails files__page_contracts automated test

- weird code in local-search (where is authority_id used to filter users?...)

- acs-admin/users/complex-search is a working replacement and duplicates their intended features

- as for TIP#125, in case complex-search was not reusable, probably a minor rework would do

  1. … 4 more files in changeset.
improve rowcount expressions

  1. … 75 more files in changeset.
Fix proc and contract doc elements, so they are properly parsed by apidoc::api_*_documentation.

- @cvs_id -> @cvs-id

- @version -> @cvs-id

- @creation_date -> @creation-date

- @date -> @creation-date

- Different variations of $Id$

- Remove wrong @param entry

- Fix typos

  1. … 368 more files in changeset.
Prefer on-spot api for user-only info

Prefer on-spot api as it is quicker

acs_user::get will not fail anymore with non-existing user

Prefer person-only api to generic user one as is quicker and now properly cached

Prefer on-spot api rather than full-blown acs_user::get

permission check reform (part 1): provide API for permission cache

  1. … 16 more files in changeset.
Remove leftover xql files

    • -23
    • +0
    ./modify-admin-privileges-oracle.xql
    • -23
    • +0
    ./modify-admin-privileges-postgresql.xql
Simplify code: set defaults for proc parameters, which are de facto optional, avoiding unnecesary existence checks.

  1. … 2 more files in changeset.
Fix regression when checking member state

removing uncalled pages based on non-existing tables and on deprecated calls

Exploit cached api to simplify and remove queries. Note that user attributes this page manipulates won't come from the cache to avoid nasty side effects. Reduce divergency between oracle and postgres codebase

    • -16
    • +0
    ./member-state-change-postgresql.xql
Exploit cached api

Reduce divergencies between oracle and postgres codebase... this file was for some reason deleted in 2001, but sql in it is portable

    • -19
    • +0
    ./registration-history-postgresql.xql
Remove (again) this almost 20 years old program

Remove unneded xql

Use more API when retrieving user info

Use more API

  1. … 2 more files in changeset.
Rework adp boolean expressions

  1. … 25 more files in changeset.