• last updated 19 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
- Changed create scripts to add per-category custom fields support.

- Fixed bug in package drop scripts. Don't think all is solved yet.

- Wrote Tcl callback to allow for per-category custom fields.

- Fixed left-over from reversing widget-procs.tcl

- Moved attribute instantiation to a Tcl callback (because we now

support per-category custom fields)

- Working on www/index.tcl

    • -6
    • +6
    ./packages/classified-ads/tcl/widget-procs.tcl
    • -4
    • +38
    ./packages/classified-ads/www/index.tcl
    • -7
    • +28
    ./packages/classified-ads/www/admin/ad-one.tcl
- Updated TODO.

    • -1
    • +1
    ./packages/classified-ads/www/doc/index.adp
- Thanks to the invaluable help from daveb, custom fields now working,

including updating of values, which wasn't working in the original version,

so fixed that bug too.

    • -13
    • +13
    ./packages/classified-ads/www/admin/ad-one.tcl
- Thanks to the invaluable help from daveb, custom fields now working,

including updating of values, which wasn't working in the original version,

so fixed that bug too.

- Revert widget-procs.tcl to generating template::element calls instead

of an ad_form -extend block, because that gives users customizing the

package (in the future) to have their own -validate block in the

ad_forms present.

    • -2
    • +1
    ./packages/classified-ads/tcl/ads-procs.tcl
    • -45
    • +26
    ./packages/classified-ads/tcl/widget-procs.tcl
- Problems with ad_form (custom element not visible)

- Modified get_widget_param to generate ad_form statements instead of

template::element::create in attempt to fix the problem. Worked partially.

- Modified ad-one accordingly.

Now the problem seems to be that a custom element is available in the

-edit_request block, but for some reaons that element (which was

added through ad_form -extend) is not available in the -edit_data block.

Does anyone know why??

    • -3
    • +5
    ./packages/classified-ads/tcl/ads-procs.tcl
    • -27
    • +46
    ./packages/classified-ads/tcl/widget-procs.tcl
    • -8
    • +16
    ./packages/classified-ads/www/admin/ad-one.tcl
- Remove unneeded query.

    • -7
    • +2
    ./packages/classified-ads/tcl/ads-procs.tcl
    • -21
    • +0
    ./packages/classified-ads/tcl/ads-procs.xql
- Fixed bug I introduced in ::ads::get

- Per-category custom field support added.

- ad-one and ad-new doing the right thing with custom fields.

    • -5
    • +19
    ./packages/classified-ads/tcl/ads-procs.tcl
    • -26
    • +49
    ./packages/classified-ads/tcl/widget-procs.tcl
    • -1
    • +1
    ./packages/classified-ads/tcl/widget-procs.xql
    • -2
    • +6
    ./packages/classified-ads/www/admin/ad-new.tcl
    • -3
    • +7
    ./packages/classified-ads/www/admin/ad-one.tcl
- Added support for per-category custom fields.

- Modified create files accordingly.

- No update scripts yet.

- Can't remember what I fixed here.

- Changed ns_log notice -> Debug

- Reformatted a bit for legibility.

- Continuing to improve UI

- ad-delete now ad_form with confirmation

- ad-one handles deletion correctly

- Updated TODO.

    • -12
    • +10
    ./packages/classified-ads/tcl/ads-procs.tcl
    • -6
    • +4
    ./packages/classified-ads/www/index.tcl
    • -0
    • +6
    ./packages/classified-ads/www/admin/ad-delete.adp
    • -1
    • +1
    ./packages/classified-ads/www/admin/ad-one.adp
    • -16
    • +17
    ./packages/classified-ads/www/admin/ad-one.tcl
    • -0
    • +1
    ./packages/classified-ads/www/doc/index.adp
- Updated user categories page. Not final.

- Moved posgresql-specific queries to field-addedit-postgresql.xql

- Update TODO in documentation.

    • -47
    • +120
    ./packages/classified-ads/www/categories.adp
    • -4
    • +8
    ./packages/classified-ads/www/categories.tcl
    • -2
    • +15
    ./packages/classified-ads/www/doc/index.adp
- Added procs to get context trail for ads.

- ad_one displays and edits ads.

- ad-delete with confirmation (still needs work).

- categories.* now link ads to ad-one

- Everything ad_form'ized.

    • -3
    • +46
    ./packages/classified-ads/tcl/ads-procs.tcl
    • -0
    • +10
    ./packages/classified-ads/tcl/ads-procs.xql
    • -0
    • +6
    ./packages/classified-ads/www/admin/ad-one.adp
    • -0
    • +83
    ./packages/classified-ads/www/admin/ad-one.tcl
- Fixing ads::new

- Reformatted classified-ads-procs.tcl for legibility

- ad-new will be merged into ad-one which will take care of adding,

editing and displaying ads.

- Improved category administration.

    • -5
    • +16
    ./packages/classified-ads/tcl/ads-procs.tcl
    • -2
    • +32
    ./packages/classified-ads/tcl/ads-procs.xql
    • -2
    • +2
    ./packages/classified-ads/tcl/widget-procs.tcl
    • -1
    • +10
    ./packages/classified-ads/www/ad-new.tcl
    • -6
    • +13
    ./packages/classified-ads/www/admin/ad-new.tcl
    • -11
    • +11
    ./packages/classified-ads/www/admin/categories.adp
- Updated .info file

- Converted category-new and ad-new to use ad_form, hence getting rid of

a couple FIXME's.

    • -61
    • +41
    ./packages/classified-ads/www/ad-new.tcl
    • -58
    • +25
    ./packages/classified-ads/www/admin/ad-new.tcl
- Made assigned and unassigned ads return published date.

- Placing new ads now lets you know which category it's going into.

- More improvements to field-addedit

- Updated TODO

- Removed category-assign-2, since it had no point and to have

consistent behavior with category-remove

- Much better admin UI to manage categories and ads.

    • -4
    • +15
    ./packages/classified-ads/tcl/ads-procs.tcl
    • -2
    • +4
    ./packages/classified-ads/tcl/ads-procs.xql
    • -3
    • +27
    ./packages/classified-ads/www/admin/ad-new.tcl
    • -24
    • +80
    ./packages/classified-ads/www/admin/categories.adp
    • -1
    • +1
    ./packages/classified-ads/www/doc/index.adp
- Improving categories UI.

- Improved documentation.

- Improved how ads are assigned to categories.

    • -10
    • +48
    ./packages/classified-ads/www/admin/categories.adp
    • -57
    • +27
    ./packages/classified-ads/www/admin/category-new.tcl
- Improved categories page (still need a prettier UI)

- Improved documentation to filed-addedit

- Added proc to verify ISBN numbers.

    • -23
    • +29
    ./packages/classified-ads/www/categories.adp
made the -name optional, forgot to commit this latest change

- Initial revision of the classified-ads package written by Deds Castillo

and Paul Doerwalds.

- Some modifications and improvements by Roberto Mello.

- Added Bugs and Features to the www/doc/index page.

- Will be committing more changes soon.

    • -0
    • +120
    ./packages/classified-ads/classified-ads.info
    • -0
    • +67
    ./packages/classified-ads/sql/postgresql/ads-create.sql
    • -0
    • +54
    ./packages/classified-ads/sql/postgresql/ads-drop.sql
    • -0
    • +8
    ./packages/classified-ads/sql/postgresql/ads-package-drop.sql
    • -0
    • +102
    ./packages/classified-ads/sql/postgresql/attributes-create.sql
    • -0
    • +11
    ./packages/classified-ads/sql/postgresql/attributes-drop.sql
  1. … 63 more files in changeset.
Remove old file.

Remove comment-edit files, add replacement add-edit files.

Remove generic xql file, move to database specific xql. Comment-add-edit now

works for add and edit.

modified wizard-procs of the templating system, added multi level wizard support, visited step, additional docs, etc.

    • -0
    • +199
    ./misc/wizard-procs-doc.html
    • -0
    • +604
    ./misc/wizard-procs.tcl
Added xql file. Fixed datamodel to reflect general_comments subtype of

content_item. Added plsql api for adding a new revision of a comment.

General_comments references cr_items. None of the attributes in general_comments should be versioned.

Fix noquote problems. Move comment-edit.xql to comment-add-edit.xql

    • -2
    • +2
    ./packages/general-comments/www/index.adp
Recover lost file.

Adding missing adp file.