• last updated 36 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
fix a couple broken links

5.0 merge

merge of all changes on oacs-5-0 branch between tag openacs-5-0-0-final and jcd-merge-pre503 (except those in lars-blogger).

  1. … 2 more files in changeset.
- adding ad-one to view/edit/delete Ads. Need to take its functionality

and move to /lib as a template so it can be used in www and www/admin.

file ad-one.adp was initially added on branch oacs-5-0.

file ad-one.tcl was initially added on branch oacs-5-0.

- Fixed bug in caterogies where it gathered custom fields belonging

to children of a category, when it should get from itself and any

parent category.

- Fixed noquote bug in index.

- Fixed bug in categories cookie trail.

- Updated documentation.

- Added -limit switch to get_assigned and get_unassigned ads to allow

for restricted number of ads to pull.

- Index page now uses list-builder (thanks Lars!!). I have to figure out

how to have dynamically-built -elements for LB.

merge of changes between oacs-5-0-0b4 and oacs-5-0-0-final to HEAD

  1. … 283 more files in changeset.
- Fixed bug in ads query

- Fixed wrong call to Tcl functions

- Fixed link in index.adp

Many of these problems exist because I lost code in a hard drive crash

a few months ago when developing the package.

Got rid of spaces after / in lines. Fixes #1348.

merge of changes on oacs-5-0 branch to oacs-5-0-0b4 tag

  1. … 598 more files in changeset.
clean up some of the summary and description data.

  1. … 14 more files in changeset.
Removing comma, typo.

    • -2
    • +2
    ./sql/postgresql/attributes-create.sql
- Added missing files.

- Can't remember what I changed. It's been a month or so since I touched

the package. Promise I'll get back to it.

- Bumped package version

- Fixed create scripts

- Fixed callback function

- Fixed field-addedit and field-delete

    • -12
    • +7
    ./sql/postgresql/attributes-create.sql
    • -2
    • +2
    ./tcl/classified-ads-procs-postgresql.xql
- Many fixes.

- More API refactoring (needs more).

- ad-new not working because I need to figure out a problem with default

values.

    • -1
    • +3
    ./sql/postgresql/attributes-create.sql
    • -2
    • +25
    ./tcl/categories-procs-postgresql.xql
    • -1
    • +9
    ./tcl/classified-ads-procs-postgresql.xql
- Fixed bug in Tcl callback

- Added Price custom site-wide field.

- TODO: Need to make the widgets table probe the templating system.

- More per-category fields changes.

- Get rid of fields.xql and use API.

    • -0
    • +41
    ./tcl/classified-ads-procs-postgresql.xql
- Realized I made a boo-boo by adding the keyword_id column that allows

per-category custom fields to the wrong table. Moved it to ca_attributes

and changed pl/pgsql and tcl api's accordingly.

- Create index in ca_attributes to improve speed. Still need to assess

where else we need indices.

- Changed API a bit. A couple functions named _exists_p were not boolean

at all, hence confusing.

- Updated user/admin files to reflect changes.

- Adding of custom fields now lets site-wide admin add site-wide custom

fields, otherwise only package-wise custom-fields.

- Improved fields UI. Needs more work.

- Updated Tcl callbacks.

    • -12
    • +14
    ./sql/postgresql/attributes-create.sql
    • -4
    • +20
    ./tcl/categories-procs-postgresql.xql
    • -225
    • +236
    ./tcl/categories-procs.tcl
    • -2
    • +1
    ./tcl/classified-ads-procs-postgresql.xql
  1. … 6 more files in changeset.
- Retrieving ads now returns all the custom fields for the category

asked for.

- New proc categories::get_custom_fields to return list of custom fields.

- Adding of custom fields now completely integrated with per-category

custom fields, plus improved UI.

    • -0
    • +22
    ./tcl/categories-procs-postgresql.xql
    • -2
    • +61
    ./www/admin/field-addedit-postgresql.xql
- Adding per-category custom fields modifications to admin UI.

- Improved UI for adding fields (still needs some work).

- Improved help texts.

- Added other options to ease adding of custom fields.

- Still need to add keyword_id.

- Changed create scripts to add per-category custom fields support.

- Fixed bug in package drop scripts. Don't think all is solved yet.

- Wrote Tcl callback to allow for per-category custom fields.

    • -1
    • +19
    ./sql/postgresql/ads-package-drop.sql
    • -3
    • +4
    ./sql/postgresql/attributes-create.sql
    • -73
    • +27
    ./tcl/classified-ads-procs-postgresql.xql
- Fixed left-over from reversing widget-procs.tcl

- Moved attribute instantiation to a Tcl callback (because we now

support per-category custom fields)

- Working on www/index.tcl

    • -0
    • +86
    ./tcl/classified-ads-procs-postgresql.xql
- Updated TODO.

- Thanks to the invaluable help from daveb, custom fields now working,

including updating of values, which wasn't working in the original version,

so fixed that bug too.

- Thanks to the invaluable help from daveb, custom fields now working,

including updating of values, which wasn't working in the original version,

so fixed that bug too.

- Revert widget-procs.tcl to generating template::element calls instead

of an ad_form -extend block, because that gives users customizing the

package (in the future) to have their own -validate block in the

ad_forms present.

- Problems with ad_form (custom element not visible)

- Modified get_widget_param to generate ad_form statements instead of

template::element::create in attempt to fix the problem. Worked partially.

- Modified ad-one accordingly.

Now the problem seems to be that a custom element is available in the

-edit_request block, but for some reaons that element (which was

added through ad_form -extend) is not available in the -edit_data block.

Does anyone know why??