OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 21
Total Committers: 146
Last Commit: 10:23
Commits this week: 21
Total Lines of Code (LoC): 7,560,944
Net change in LoC this week: 123

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 52 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 11 Mar 2021
3:51 pm

hectorr

Whitespace changes

Options
    • -2
    • +2
    /openacs-4/packages/acs-subsite/www/members/member-invite.tcl
    • -5
    • +1
    /openacs-4/packages/acs-subsite/www/register/recover-password.tcl
3:40 pm

hectorr

Use the new 'url' and 'email' input type widgets

Options
    • -2
    • +2
    /openacs-4/packages/acs-subsite/lib/user-info.tcl
    • -2
    • +2
    /openacs-4/packages/acs-subsite/www/members/member-invite.tcl
3:26 pm

hectorr

Use the new 'url' and 'email' input type widgets

Options
    • -2
    • +3
    /openacs-4/packages/acs-authentication/acs-authentication.info
    • -3
    • +3
    /openacs-4/packages/acs-authentication/tcl/authentication-procs.tcl
3:24 pm

hectorr

Remove duplicated code

Options
    • -18
    • +1
    /openacs-4/packages/acs-templating/tcl/widget-procs.tcl
3:23 pm

hectorr

Add new ad_form input types

Options
    • -2
    • +2
    /openacs-4/packages/acs-templating/acs-templating.info
    • -6
    • +77
    /openacs-4/packages/acs-templating/tcl/widget-procs.tcl
2:22 pm

hectorr

Use the 'search' input type in the search widget

Options
    • -5
    • +5
    /openacs-4/packages/acs-templating/tcl/widget-procs.tcl
11:51 am

hectorr

Whitespace changes

Options
    • -21
    • +12
    /openacs-4/packages/calendar/www/cal-item-create-recurrence.tcl
11:48 am

hectorr

Use the new ad_form 'number' input field. Bump version number for dependency.

Options
    • -5
    • +5
    /openacs-4/packages/calendar/calendar.info
    • -3
    • +5
    /openacs-4/packages/calendar/www/cal-item-create-recurrence.tcl
    • -2
    • +2
    /openacs-4/packages/calendar/www/view-list-display.tcl
11:46 am

antoniop

Use naviserver api to parse URL variables

Options
    • -12
    • +5
    /openacs-4/packages/acs-tcl/tcl/http-client-procs.tcl
    • -2
    • +1
    /openacs-4/packages/xooauth/www/admin/lti-test.tcl
11:28 am

hectorr

Whitespace changes, breaking overlong lines, and removal of old *SQL*

Options
    • -40
    • +89
    /openacs-4/packages/faq/www/admin/q-and-a-add-edit.tcl
11:14 am

antoniop

Use naviserver api to parse URL variables

Options
    • -7
    • +3
    /openacs-4/packages/acs-datetime/tcl/acs-calendar-procs.tcl
    • -3
    • +1
    /openacs-4/packages/xooauth/tcl/oauth-client-procs.tcl
    • -4
    • +2
    /openacs-4/packages/xooauth/tcl/oauth-procs.tcl
    • -3
    • +2
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
Wednesday 10 Mar 2021
4:18 pm

antoniop

Final phasing out of acs_named_objects

- remove table creation

- update documentation

- provide an optional upgrade script to delete the table and the object type (commented out by default, as people might have defined object subtypes downstream).

Context: this table and the related machinery were created at a time where acs_objects where not as mature as they are now and would not include the "title" information. To retrieve the object name, the only option was the stored procedure acs_object.name, which was not scalable.

From an excerpt of the Changelog file:

.....

2004-03-31 jeffd

......

* packages/categories/tcl/category-trees-procs-oracle.xql:

* packages/categories/tcl/category-trees-procs-postgresql.xql:

acs_named_objects superflous now that title is in

acs_objects. need to fix the rest of the occurances though

......

This tells us that the phasing out has already been decided back in 2004, but delayed. One technical reason, could be that the acs_named_objects table would also materialize the translation, while the title column would store sometimes a message key, that would need to be translated manually. This is helpful when e.g. sorting by name in sql. However, only the faq and categories package would seem to make any use of the table and only the faq package would seem to maintain its values... This would make some UIs in the categories package practically useless since a long time.

Options
    • -2
    • +2
    /openacs-4/packages/categories/categories.info
    • -35
    • +0
    /openacs-4/packages/categories/sql/oracle/categories-init.sql
    • -0
    • +12
    /openacs-4/packages/categories/sql/oracle/upgrade/upgrade-1.1.5d3-1.1.5d4.sql
    • -2
    • +0
    /openacs-4/packages/categories/sql/postgresql/categories-drop.sql
    • -37
    • +0
    /openacs-4/packages/categories/sql/postgresql/categories-init.sql
    • -0
    • +10
    /openacs-4/packages/categories/sql/postgresql/upgrade/upgrade-1.1.5d3-1.1.5d4.sql
    • -78
    • +6
    /openacs-4/packages/categories/www/doc/o.adp
    • -88
    • +10
    /openacs-4/packages/categories/www/doc/o.html
4:18 pm

antoniop

file upgrade-1.1.5d3-1.1.5d4.sql was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/categories/sql/oracle/upgrade/upgrade-1.1.5d3-1.1.5d4.sql
    • -0
    • +0
    /openacs-4/packages/categories/sql/postgresql/upgrade/upgrade-1.1.5d3-1.1.5d4.sql
2:45 pm

antoniop

Phase out usage of obsolete acs_named_objects table

Options
    • -4
    • +2
    /openacs-4/packages/faq/www/admin/faq-delete.tcl
    • -2
    • +0
    /openacs-4/packages/faq/www/admin/q-and-a-add-edit.tcl
2:41 pm

antoniop

Whitespace cleanup

Options
    • -13
    • +13
    /openacs-4/packages/faq/www/admin/q-and-a-add-edit.tcl
2:21 pm

antoniop

Cleanup var, break overlong line

Options
    • -4
    • +8
    /openacs-4/packages/categories/www/categories-browse.tcl
2:16 pm

antoniop

Rework of category UI:

- phase out usage of acs_named_objects, use object title instead

- rework pagination using builtin template::list features

- reduce hardcoded styling and markup

- rework strange database idioms

- remove divergency between oracle and postgres codebase

Options
    • -30
    • +0
    /openacs-4/packages/categories/www/categories-browse-oracle.xql
    • -24
    • +0
    /openacs-4/packages/categories/www/categories-browse-postgresql.xql
    • -35
    • +2
    /openacs-4/packages/categories/www/categories-browse.adp
    • -104
    • +83
    /openacs-4/packages/categories/www/categories-browse.tcl
    • -46
    • +8
    /openacs-4/packages/categories/www/categories-browse.xql
12:11 pm

gustafn

include "topic-assignment.wf" in list of displayed workflow types

Options
    • -1
    • +1
    /openacs-4/packages/xowf/www/prototypes/assessment-index.page
12:08 pm

gustafn

prefer using API over query in package for common data model

Options
    • -4
    • +6
    /openacs-4/packages/oacs-dav/tcl/oacs-dav-procs.tcl
    • -6
    • +0
    /openacs-4/packages/oacs-dav/tcl/oacs-dav-procs.xql
11:56 am

gustafn

Use built-in "ns_parsequery" instead of manual parsing of query parameters

Options
    • -6
    • +6
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
11:45 am

gustafn

Use built-in "ns_parsequery" instead of manual parsing of query parameters

Options
    • -5
    • +3
    /openacs-4/packages/xotcl-core/tcl/30-widget-procs.tcl
    • -4
    • +3
    /openacs-4/packages/richtext-ckeditor4/tcl/ckfinder-procs.tcl
Tuesday 09 Mar 2021
10:27 pm

gustafn

Use built-in "ns_parsequery" instead of manual parsing of query parameters.

Note, that this change might alter query processing, since previously

query parameter without explicit values were treated as boolean values

(like in HTML), now these are treated like "x=" before. The new version is

about 10x faster.

Furthermore, new tests of the regression tests were added for query parameter

processing.

Options
    • -38
    • +21
    /openacs-4/packages/xotcl-core/tcl/context-procs.tcl
    • -0
    • +80
    /openacs-4/packages/xotcl-core/tcl/test/api-test-procs.tcl
10:27 pm

gustafn

file api-test-procs.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/xotcl-core/tcl/test/api-test-procs.tcl
10:11 pm

gustafn

fixed description of test file

Options
    • -3
    • +2
    /openacs-4/packages/xotcl-core/tcl/test/xotcl-core-db-tutorial-procs.tcl
3:25 pm

antoniop

Formatting change

Options
    • -2
    • +30
    /openacs-4/packages/categories/www/categories-browse.tcl
2:53 pm

antoniop

Refactor of category mapping UI:

- remove reference to obsolete and unmaintained acs_named_objects, which was preventing the UI to work in practice

- rework pagination and other idioms to long standing template::list best practices

- reduce hardcoded styling

Options
    • -25
    • +0
    /openacs-4/packages/categories/www/cadmin/category-usage-oracle.xql
    • -23
    • +0
    /openacs-4/packages/categories/www/cadmin/category-usage-postgresql.xql
    • -33
    • +1
    /openacs-4/packages/categories/www/cadmin/category-usage.adp
    • -48
    • +46
    /openacs-4/packages/categories/www/cadmin/category-usage.tcl
11:24 am

hectorr

Whitespace changes

Options
    • -31
    • +62
    /openacs-4/packages/file-storage/www/simple-add.tcl
    • -13
    • +36
    /openacs-4/packages/file-storage/www/simple-edit.tcl
11:13 am

hectorr

Use the new 'url' input type

Options
    • -2
    • +2
    /openacs-4/packages/file-storage/www/simple-add.tcl
    • -2
    • +2
    /openacs-4/packages/file-storage/www/simple-edit.tcl
11:11 am

hectorr

Add new 'url' input type to 'ad_form'

Options
    • -1
    • +19
    /openacs-4/packages/acs-templating/tcl/widget-procs.tcl
10:45 am

hectorr

Whitespace changes

Options
    • -23
    • +20
    /openacs-4/packages/file-storage/www/admin/upload-size-limit.tcl