• last updated 1 hour ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
improve test coverage

small performance improvement

Provide a cached public api, reinstate uncached api as private, replace occurrences

Do not invoke service contract implementations directly, use the public interface

    • -13
    • +18
    /openacs-4/packages/acs-tcl/tcl/install-procs.tcl
Replace deprecated api

- Rework acs-api-browser.callgraph__bad_calls automated test so that acs-service-contract calling contract implementation is considered OK

- Reinstate authentication service contracts as private

- Move test authority implementation to acs-authentication to remove intra-package dependency

acs-api-browser.callgraph__bad_call still fails because proc acs-tcl.install::xml::action::create-user calls private acs-authentication.auth::local::registration::Register... to be continued

file test-authority-procs.tcl was initially added on branch oacs-5-10.

Reinstate apis as public, as they hold the current definition of an all-day event

avoid setting of unneeded function, reduce access to nsvs

    • -3
    • +2
    /openacs-4/packages/search/tcl/search-procs.tcl
provide a flushing interface to apm_package_id cache to avoid the need to call the uncached code directly

whitespace changes: break overlong lines

Reinstate proc as private, remove dependency to such proc in external package

    • -1
    • +2
    /openacs-4/packages/search/www/search.tcl
make clear from the name that db_qd_prepare_queryfile_content is intended to be used in different packages

Whitespace cleanup

    • -13
    • +13
    /openacs-4/packages/acs-tcl/tcl/apm-xml-procs.tcl
Make api public, complies with acs-api-browser.graph__bad_calls automated test

Skip deprecated api that is neutralized by the next upgrade, reinstate deprecated api just for upgrade purposes, complies with acs-api-browser.graph__bad_calls automated test

Whitespace cleanup

Make api deprecated, complies with acs-api-browser.graph__bad_calls automated test

Make api deprecated, complies with acs-api-browser.graph__bad_calls automated test

Make api public, complies with acs-api-browser.graph__bad_calls automated test

Whitespace cleanup

    • -7
    • +7
    /openacs-4/packages/dotlrn/tcl/dotlrn-procs.tcl
Make api public, complies with acs-api-browser.graph__bad_calls automated test

    • -1
    • +1
    /openacs-4/packages/dotlrn/tcl/dotlrn-procs.tcl
Make api public, complies with acs-api-browser.graph__bad_calls automated test

Make api public, complies with acs-api-browser.graph__bad_calls automated test

Make api deprecated, complies with acs-api-browser.graph__bad_calls automated test

Make api public, complies with acs-api-browser.graph__bad_calls automated test

Make api public, complies with acs-api-browser.graph__bad_calls

Make proc public (it is used in a test is acs-tcl)

Complies with acs-api-browser.callgraph__bad_calls

Whitespace cleanup

Make service contract implementation public

Complies with acs-api-browser.callgraph__bad_calls