OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 18
Total Committers: 146
Last Commit: 12:28
Commits this week: 18
Total Lines of Code (LoC): 7,560,946
Net change in LoC this week: 3

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 7 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 30 Jul
3:42 pm

antoniop

Whitespace cleanup

Options
    • -2
    • +2
    /openacs-4/packages/acs-subsite/www/permissions/perm-modify.tcl
3:34 pm

antoniop

Harden page contract

Options
    • -3
    • +3
    /openacs-4/packages/dotlrn/www/register.tcl
    • -2
    • +2
    /openacs-4/packages/file-storage/www/file-upload-confirm.tcl
    • -3
    • +3
    /openacs-4/packages/dotlrn/www/deregister.tcl
1:41 pm

antoniop

Cleanup smelly comments and behavior that would be better implemented in xowiki when we will get rid of the ckeditor4 dependency (post 5.10.1 release)

Options
    • -16
    • +0
    /openacs-4/packages/richtext-ckeditor4/tcl/richtext-init.tcl
    • -23
    • +0
    /openacs-4/packages/richtext-tinymce/tcl/richtext-init.tcl
    • -16
    • +0
    /openacs-4/packages/richtext-xinha/tcl/richtext-init.tcl
1:41 pm

antoniop

Cleanup smelly comments and behavior that would be better implemented in xowiki when we will get rid of the ckeditor4 dependency (post 5.10.1 release)

Options
    • -15
    • +5
    /openacs-4/packages/richtext-ckeditor5/tcl/richtext-init.tcl
1:27 pm

antoniop

Use ns_parseurl to validate the URL and to determine the hostname

Options
    • -5
    • +7
    /openacs-4/packages/acs-tcl/tcl/http-client-procs.tcl
1:22 pm

antoniop

Latest released NaviServer still requires for servers using SNI that the -hostname flag is specified with ns_http, while it seems that in latest code we can omit it

The wrapper utility already takes care of this

Options
    • -3
    • +3
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
12:25 pm

gustafn

Ease management of external js packages to automate admin tasks

- provide explicit information about optional package paramters

- make these accessible from site-wide admin pages

- provide information, how the configuration of the version number happend

- improve design of site-wide admin pages with action items

- further streamlined handling of external js packages

Options
    • -8
    • +16
    /openacs-4/packages/acs-tcl/lib/check-installed.adp
    • -3
    • +39
    /openacs-4/packages/acs-tcl/lib/check-installed.tcl
    • -3
    • +4
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
    • -16
    • +21
    /openacs-4/packages/boomerang/tcl/boomerang-procs.tcl
    • -1
    • +1
    /openacs-4/packages/boomerang/www/sitewide-admin/compress.tcl
    • -4
    • +4
    /openacs-4/packages/boomerang/www/sitewide-admin/index.tcl
    • -2
    • +3
    /openacs-4/packages/bootstrap-icons/tcl/resource-init.tcl
    • -16
    • +17
    /openacs-4/packages/bootstrap-icons/tcl/resource-procs.tcl
    • -1
    • +1
    /openacs-4/packages/bootstrap-icons/www/sitewide-admin/index.adp
    • -2
    • +3
    /openacs-4/packages/bootstrap-icons/www/sitewide-admin/sample.tcl
    • -10
    • +16
    /openacs-4/packages/cookie-consent/tcl/cookie-consent-procs.tcl
    • -10
    • +18
    /openacs-4/packages/fa-icons/tcl/resource-procs.tcl
    • -1
    • +2
    /openacs-4/packages/fa-icons/www/sitewide-admin/index.adp
    • -14
    • +19
    /openacs-4/packages/highcharts/tcl/resource-procs.tcl
    • -7
    • +1
    /openacs-4/packages/openacs-bootstrap5-theme/tcl/resource-init.tcl
  16. … 4 more files in changeset.
11:21 am

antoniop

Fix typos, improve translations

Options
    • -2
    • +2
    /openacs-4/packages/acs-subsite/acs-subsite.info
    • -2
    • +2
    /openacs-4/packages/acs-subsite/catalog/acs-subsite.it_IT.ISO-8859-1.xml
11:06 am

antoniop

Fix untested change

Options
    • -4
    • +4
    /openacs-4/packages/richtext-tinymce/richtext-tinymce.info
10:57 am

antoniop

Fix parameter name in doc

Options
    • -4
    • +4
    /openacs-4/packages/acs-datetime/tcl/acs-calendar-procs.tcl
10:55 am

antoniop

Fix typo in doc

Options
    • -2
    • +2
    /openacs-4/packages/acs-mail-lite/tcl/acs-mail-lite-procs.tcl
10:25 am

antoniop

Fix typo reported by test case acs_api_browser_api_get_body

Options
    • -1
    • +1
    /openacs-4/packages/evaluation-portlet/tcl/test/tclwebtest-procs.tcl
Monday 29 Jul
4:27 pm

gustafn

Reworked of richtext-tinymce

- follow same resource-info structure as for other packages

- added full site-wide admin info

- support download via site-wide-admin interface

- do not require app-key

- support styles from CDN and/local

Options
    • -0
    • +13
    /openacs-4/packages/richtext-tinymce/tcl/richtext-init.tcl
    • -121
    • +102
    /openacs-4/packages/richtext-tinymce/tcl/richtext-procs.tcl
    • -3
    • +5
    /openacs-4/packages/richtext-tinymce/www/sitewide-admin/download.tcl
    • -0
    • +2
    /openacs-4/packages/richtext-tinymce/www/sitewide-admin/index.adp
    • -4
    • +2
    /openacs-4/packages/richtext-tinymce/www/sitewide-admin/index.tcl
4:00 pm

gustafn

renamed misnomer "ad_parameter_from_file"

- removed hints on "*.ini" files

- provided a name that points to the configuration file ("ad_parameter_from_configuration_file")

- deprecated old name

- updated documentation with examples

Options
    • -8
    • +35
    /openacs-4/packages/acs-tcl/tcl/defs-procs.tcl
    • -5
    • +5
    /openacs-4/packages/acs-tcl/tcl/parameter-procs.tcl
    • -1
    • +1
    /openacs-4/packages/acs-tcl/tcl/test/apm-parameter-test-procs.tcl
    • -4
    • +4
    /openacs-4/packages/acs-tcl/tcl/test/defs-procs.tcl
2:55 pm

gustafn

amend to last commit (dirty editor buffer)

Options
    • -1
    • +1
    /openacs-4/packages/acs-subsite/catalog/acs-subsite.it_IT.ISO-8859-1.xml
2:52 pm

gustafn

improve message key

- The message was confusing, especially to novices:

There is no "OpenACS parameter file", but a "NaviServer configuraiton file"

- bumped version number to 5.10.1b7

Options
    • -2
    • +2
    /openacs-4/packages/acs-subsite/acs-subsite.info
    • -1
    • +1
    /openacs-4/packages/acs-subsite/catalog/acs-subsite.ar_LB.utf-8.xml
    • -1
    • +1
    /openacs-4/packages/acs-subsite/catalog/acs-subsite.ch_zh.utf-8.xml
    • -1
    • +1
    /openacs-4/packages/acs-subsite/catalog/acs-subsite.da_DK.ISO-8859-1.xml
    • -1
    • +0
    /openacs-4/packages/acs-subsite/catalog/acs-subsite.de_DE.ISO-8859-1.xml
    • -1
    • +2
    /openacs-4/packages/acs-subsite/catalog/acs-subsite.el_GR.utf-8.xml
    • -1
    • +1
    /openacs-4/packages/acs-subsite/catalog/acs-subsite.en_AU.ISO-8859-1.xml
    • -3
    • +2
    /openacs-4/packages/acs-subsite/catalog/acs-subsite.en_US.ISO-8859-1.xml
    • -1
    • +2
    /openacs-4/packages/acs-subsite/catalog/acs-subsite.es_CO.ISO-8859-1.xml
    • -1
    • +3
    /openacs-4/packages/acs-subsite/catalog/acs-subsite.es_ES.ISO-8859-1.xml
    • -1
    • +1
    /openacs-4/packages/acs-subsite/catalog/acs-subsite.es_GT.ISO-8859-1.xml
    • -1
    • +1
    /openacs-4/packages/acs-subsite/catalog/acs-subsite.fr_FR.ISO-8859-1.xml
    • -1
    • +3
    /openacs-4/packages/acs-subsite/catalog/acs-subsite.gl_ES.ISO-8859-1.xml
    • -1
    • +1
    /openacs-4/packages/acs-subsite/catalog/acs-subsite.ko_KR.utf-8.xml
    • -1
    • +1
    /openacs-4/packages/acs-subsite/catalog/acs-subsite.ms_MY.utf-8.xml
  16. … 9 more files in changeset.
2:01 pm

gustafn

js-libraries: improved naming of variables

Changed name "installedVersion" to "configuredVersion", since

the former might lead to the impression, that it refers only

to the locally installed version. Instead, this refers as well

to a CDN version (when available)

Options
    • -14
    • +14
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
    • -1
    • +1
    /openacs-4/packages/boomerang/tcl/boomerang-procs.tcl
    • -1
    • +1
    /openacs-4/packages/boomerang/www/sitewide-admin/index.tcl
    • -1
    • +1
    /openacs-4/packages/bootstrap-icons/tcl/resource-procs.tcl
    • -1
    • +1
    /openacs-4/packages/bootstrap-icons/www/sitewide-admin/index.tcl
    • -2
    • +2
    /openacs-4/packages/cookie-consent/tcl/cookie-consent-procs.tcl
    • -1
    • +1
    /openacs-4/packages/cookie-consent/www/sitewide-admin/index.tcl
    • -2
    • +2
    /openacs-4/packages/fa-icons/tcl/resource-procs.tcl
    • -1
    • +1
    /openacs-4/packages/fa-icons/www/sitewide-admin/index.tcl
    • -1
    • +1
    /openacs-4/packages/highcharts/tcl/resource-procs.tcl
    • -1
    • +1
    /openacs-4/packages/highcharts/www/sitewide-admin/index.tcl
    • -1
    • +1
    /openacs-4/packages/openacs-bootstrap3-theme/tcl/init-procs.tcl
    • -1
    • +1
    /openacs-4/packages/openacs-bootstrap3-theme/www/sitewide-admin/index.tcl
    • -1
    • +1
    /openacs-4/packages/openacs-bootstrap5-theme/tcl/resource-procs.tcl
    • -1
    • +1
    /openacs-4/packages/openacs-bootstrap5-theme/www/sitewide-admin/index.tcl
  16. … 4 more files in changeset.
1:56 pm

gustafn

reduced verbosity

Options
    • -1
    • +1
    /openacs-4/packages/acs-tcl/lib/check-installed.tcl
Sunday 28 Jul
7:41 pm

gustafn

js-libraries: removed variable "resourceUrl"

The variable "resourceUrl" was always used in a single branch but set

for all branches before. To ease maintenance and simplify

comprehension, it was removed.

Options
    • -2
    • +1
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
    • -3
    • +2
    /openacs-4/packages/boomerang/tcl/boomerang-procs.tcl
    • -2
    • +1
    /openacs-4/packages/bootstrap-icons/tcl/resource-procs.tcl
    • -2
    • +1
    /openacs-4/packages/cookie-consent/tcl/cookie-consent-procs.tcl
    • -2
    • +1
    /openacs-4/packages/fa-icons/tcl/resource-procs.tcl
    • -2
    • +1
    /openacs-4/packages/highcharts/tcl/resource-procs.tcl
    • -3
    • +2
    /openacs-4/packages/openacs-bootstrap3-theme/tcl/init-procs.tcl
    • -7
    • +4
    /openacs-4/packages/openacs-bootstrap5-theme/tcl/resource-procs.tcl
    • -6
    • +2
    /openacs-4/packages/richtext-ckeditor4/tcl/richtext-procs.tcl
    • -2
    • +1
    /openacs-4/packages/richtext-xinha/tcl/richtext-procs.tcl
    • -3
    • +2
    /openacs-4/packages/xowiki/tcl/resource-info-procs.tcl
7:08 pm

gustafn

tdom: "dom parse -html" implies the "simple" parser

The flag "-simple" is not needed when parsing with the flag "-html". This meanse

that

dom parse -simple -html ...

is equivalent with

dom parse -html ...

Options
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/apm-install-procs.tcl
    • -1
    • +1
    /openacs-4/packages/xowf/tcl/test-item-procs.tcl
    • -5
    • +5
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/xowiki-www-procs.tcl
7:00 pm

gustafn

Always use "--" in "dom parse" when document is interpolated

This is a safety measure to make sure that the document parsed is

never confused with an option, when the document starts with a "-". In

the best case, the error message provided by "dom parse" might be

misleading. This might be a problem for user contributed documents

(passed as variables, or return values from functions).

The double dash is supported in tdom since version 0.9.0.

Options
    • -2
    • +2
    /openacs-4/packages/acs-api-browser/tcl/acs-api-documentation-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-automated-testing/tcl/aa-test-procs.tcl
    • -1
    • +1
    /openacs-4/packages/acs-lang/tcl/test/acs-lang-test-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/30-xml-utils-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/apm-install-procs.tcl
    • -1
    • +1
    /openacs-4/packages/acs-tcl/tcl/html-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/text-html-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/test/http-client-procs.tcl
    • -2
    • +2
    /openacs-4/packages/assessment/tcl/as-qti-procs.tcl
    • -2
    • +2
    /openacs-4/packages/caldav/tcl/caldav-procs.tcl
    • -2
    • +2
    /openacs-4/packages/caldav/tcl/test/caldav-test-procs.tcl
    • -2
    • +2
    /openacs-4/packages/categories/tcl/category-xml-procs.tcl
    • -3
    • +3
    /openacs-4/packages/oacs-dav/tcl/tDAV-procs.tcl
    • -1
    • +1
    /openacs-4/packages/xowf/tcl/test-item-procs.tcl
    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/form-field-procs.tcl
  16. … 4 more files in changeset.
6:27 pm

gustafn

In essence, this change renames "version_dir" to "version_segment" as

well as "versionDir" to "versionSegment" to reflect the fact, that

this variable does not denote a directory, but a part of the path

appended to path "resourceDir".

Options
    • -4
    • +4
    /openacs-4/packages/acs-tcl/lib/check-installed.tcl
    • -27
    • +27
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
    • -2
    • +2
    /openacs-4/packages/cookie-consent/tcl/cookie-consent-procs.tcl
    • -3
    • +3
    /openacs-4/packages/highcharts/tcl/resource-procs.tcl
    • -4
    • +4
    /openacs-4/packages/openacs-bootstrap5-theme/tcl/resource-procs.tcl
2:15 pm

gustafn

various small fixes for js libraries

- fixed page contract in case a non-default version is downloaded

- provide always an argument "-version" to resource_info procs

- obtain current version number always via resource_info.installedVersion

(it refers to CDN and locally installed version)

- pass always versionDir via resource_info to ::util::resources::download

- always obtain version_dir from resource_info

Options
    • -4
    • +1
    /openacs-4/packages/acs-tcl/lib/check-installed.tcl
    • -25
    • +19
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
    • -1
    • +2
    /openacs-4/packages/boomerang/tcl/boomerang-procs.tcl
    • -1
    • +1
    /openacs-4/packages/boomerang/www/sitewide-admin/compress.tcl
    • -2
    • +2
    /openacs-4/packages/boomerang/www/sitewide-admin/index.tcl
    • -5
    • +3
    /openacs-4/packages/bootstrap-icons/tcl/resource-procs.tcl
    • -1
    • +1
    /openacs-4/packages/bootstrap-icons/www/sitewide-admin/download.tcl
    • -1
    • +1
    /openacs-4/packages/bootstrap-icons/www/sitewide-admin/index.tcl
    • -6
    • +2
    /openacs-4/packages/cookie-consent/www/sitewide-admin/download.tcl
    • -1
    • +1
    /openacs-4/packages/cookie-consent/www/sitewide-admin/index.tcl
    • -6
    • +6
    /openacs-4/packages/fa-icons/tcl/resource-procs.tcl
    • -1
    • +1
    /openacs-4/packages/fa-icons/www/sitewide-admin/download.tcl
    • -1
    • +1
    /openacs-4/packages/fa-icons/www/sitewide-admin/index.tcl
    • -13
    • +7
    /openacs-4/packages/highcharts/tcl/resource-procs.tcl
    • -1
    • +1
    /openacs-4/packages/highcharts/www/sitewide-admin/download.tcl
  16. … 11 more files in changeset.
1:57 pm

gustafn

add "--" to separate argument list from potentially confusing (and externaly provided) content

Options
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/json-procs.tcl
Friday 26 Jul
1:24 pm

antoniop

Port of downstream feature request:

when filtering for not graded questions, if the entire exam has not ungraded questions, hide the entire exam block. The purpose is to reduce distractions in the UI.

Options
    • -7
    • +12
    /openacs-4/packages/xowf/www/resources/inclass-exam.js
12:00 pm

gustafn

added handling of literal object "arraycontainer"

Options
    • -6
    • +5
    /openacs-4/packages/acs-tcl/tcl/json-procs.tcl
    • -0
    • +8
    /openacs-4/packages/acs-tcl/tcl/test/json-test-procs.tcl
Thursday 25 Jul
4:24 pm

gustafn

Improved resource information for external libraries

- added vulnerability check for a particular version

- centralized URL generation for cdnjs URLS (will reduce maintenance work, when external URL changes)

- improve behavior when running without an Internet connection

Options
    • -1
    • +6
    /openacs-4/packages/acs-tcl/lib/check-installed.adp
    • -1
    • +39
    /openacs-4/packages/acs-tcl/lib/check-installed.tcl
    • -11
    • +47
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
    • -1
    • +0
    /openacs-4/packages/bootstrap-icons/tcl/resource-procs.tcl
    • -3
    • +2
    /openacs-4/packages/cookie-consent/tcl/cookie-consent-procs.tcl
    • -1
    • +0
    /openacs-4/packages/fa-icons/tcl/resource-procs.tcl
    • -2
    • +1
    /openacs-4/packages/highcharts/tcl/resource-procs.tcl
    • -1
    • +1
    /openacs-4/packages/openacs-bootstrap3-theme/tcl/init-procs.tcl
    • -2
    • +1
    /openacs-4/packages/openacs-bootstrap5-theme/tcl/resource-procs.tcl
    • -2
    • +2
    /openacs-4/packages/richtext-ckeditor4/tcl/richtext-procs.tcl
    • -3
    • +2
    /openacs-4/packages/richtext-tinymce/tcl/richtext-procs.tcl
    • -3
    • +1
    /openacs-4/packages/xowiki/tcl/resource-info-procs.tcl
4:18 pm

gustafn

improved description of parameter

Options
    • -1
    • +1
    /openacs-4/packages/acs-kernel/acs-kernel.info
3:24 pm

mischa

Fix permission::write_permission_p. Before, the check if the user was the creation_user was always made against the currently logged in user, not the party given by the caller.

Options
    • -6
    • +9
    /openacs-4/packages/acs-tcl/tcl/acs-permissions-procs.tcl
3:08 pm

mischa

Dont fail when pk_formatted is empty.

Options
    • -1
    • +2
    /openacs-4/packages/acs-subsite/tcl/package-procs.tcl