OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 6
Total Committers: 146
Last Commit: 21 Nov
Commits this week: 6
Total Lines of Code (LoC): 7,560,943
Net change in LoC this week: 122

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 1 hour ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 12 Aug 2022
7:17 pm

antoniop

Preliminary cleanup

In this test we will loop through instances of ::xowiki::Page currently in memory to perform some checks. When multiple tests run in the same request, we cannot guarantee that other tests won't create ::xowiki::Page instances that won't comply with the conditions here. We cleanup any existing object in advance to start from a clean slate.

Options
    • -0
    • +9
    /openacs-4/packages/xowiki/tcl/test/xowiki-admin-tests-procs.tcl
6:41 pm

gustafn

reduce number of anonymous arrays, improve error message and double check for package initialization

Options
    • -2
    • +4
    /openacs-4/packages/xowf/tcl/xowf-form-field-procs.tcl
    • -5
    • +19
    /openacs-4/packages/xowf/tcl/xowf-procs.tcl
Thursday 11 Aug 2022
8:22 pm

antoniop

Skip processing for all formfields that are defined as disabled:

the browser should not send us these data in the first place.

Options
    • -21
    • +29
    /openacs-4/packages/xowiki/tcl/xowiki-www-procs.tcl
8:16 pm

antoniop

Extend test: show that even when a field is defined as disabled, a request crafted to carry these fields will get through and the values will be stored

A fix will come shortly, similar to what was done for compound fields

Options
    • -3
    • +15
    /openacs-4/packages/xowiki/tcl/test/xowiki-test-procs.tcl
3:51 pm

gustafn

added download support

many thanks for the help of Maonika Andergassen

Options
    • -3
    • +3
    /openacs-4/packages/openacs-bootstrap5-theme/openacs-bootstrap5-theme.info
    • -39
    • +43
    /openacs-4/packages/openacs-bootstrap5-theme/tcl/resource-procs.tcl
    • -1
    • +0
    /openacs-4/packages/openacs-bootstrap5-theme/www/sitewide-admin/download.tcl
3:49 pm

gustafn

Generalized "version_dir" handling a little for download specs

The problem was that bootstrap5 uses a version directory, which

consists of the version plus an extra string element. The previous

version assumed that the version is always used as a directory name.

Whe track now the versionDir information in the resource_info dict and

use this, when available (otherwise the version number is used as before).

The resource_info dict contains now the following path components:

# Provide paths for loading either via /resources/ or CDN

#

# "resourceDir" is the absolute path in the filesystem

# "resourceUrl" is the URL path provided to the request processor

# "versionDir" is the version-specific element both in the

# URL and in the filesystem.

#

bumped acs-tcl to 5.10.1d19

Options
    • -2
    • +2
    /openacs-4/packages/acs-tcl/acs-tcl.info
    • -2
    • +8
    /openacs-4/packages/acs-tcl/lib/check-installed.tcl
    • -1
    • +27
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
1:05 pm

gustafn

whitespace changes

Options
    • -50
    • +50
    /openacs-4/packages/acs-templating/tcl/tag-init.tcl
1:01 pm

gustafn

added new generic icon name: add-new-item

Options
    • -1
    • +5
    /openacs-4/packages/acs-templating/tcl/tag-init.tcl
1:00 pm

gustafn

prefer parameter::get_from_package_key over fetching package_id first

Options
    • -7
    • +9
    /openacs-4/packages/acs-templating/tcl/template-init.tcl
Wednesday 10 Aug 2022
9:58 am

antoniop

Fix leftover jquery dependency

Options
    • -1
    • +1
    /openacs-4/packages/xowf/tcl/test-item-procs.tcl
Monday 08 Aug 2022
4:48 pm

gustafn

fix several bugs in "acs_object_type::supertype" and improve code sanity

Options
    • -8
    • +8
    /openacs-4/packages/acs-tcl/tcl/object-type-procs-postgresql.xql
    • -8
    • +8
    /openacs-4/packages/acs-tcl/tcl/object-type-procs.tcl
    • -1
    • +10
    /openacs-4/packages/acs-tcl/tcl/test/object-test-case-procs.tcl
3:15 pm

antoniop

Fix localization idiom

Options
    • -1
    • +1
    /openacs-4/packages/faq/www/admin/one-faq.tcl
2:56 pm

antoniop

Tighten page contracts

Options
    • -6
    • +2
    /openacs-4/packages/faq/lib/faq-add-edit.tcl
    • -2
    • +2
    /openacs-4/packages/faq/www/one-faq.tcl
    • -5
    • +2
    /openacs-4/packages/faq/www/one-question.tcl
    • -1
    • +1
    /openacs-4/packages/faq/www/admin/faq-add-edit.tcl
    • -3
    • +2
    /openacs-4/packages/faq/www/admin/faq-delete.tcl
    • -7
    • +3
    /openacs-4/packages/faq/www/admin/faq-disable.tcl
    • -1
    • +1
    /openacs-4/packages/faq/www/admin/faq-edit-2.tcl
    • -1
    • +1
    /openacs-4/packages/faq/www/admin/faq-edit.tcl
    • -6
    • +2
    /openacs-4/packages/faq/www/admin/faq-enable.tcl
    • -1
    • +1
    /openacs-4/packages/faq/www/admin/faq-new-2.tcl
    • -2
    • +1
    /openacs-4/packages/faq/www/admin/one-faq.tcl
    • -1
    • +1
    /openacs-4/packages/faq/www/admin/one-question.tcl
    • -3
    • +3
    /openacs-4/packages/faq/www/admin/q-and-a-add-edit.tcl
    • -1
    • +1
    /openacs-4/packages/faq/www/admin/q-and-a-delete.tcl
    • -1
    • +1
    /openacs-4/packages/faq/www/admin/q-and-a-edit-2.tcl
  16. … 7 more files in changeset.
1:01 pm

antoniop

Replace not portable sql idiom with existing api, improve caching, extend regression test

Options
    • -26
    • +32
    /openacs-4/packages/acs-tcl/tcl/object-procs.tcl
    • -4
    • +7
    /openacs-4/packages/acs-tcl/tcl/object-type-procs.tcl
    • -1
    • +19
    /openacs-4/packages/acs-tcl/tcl/test/object-test-case-procs.tcl
Sunday 07 Aug 2022
3:01 pm

gustafn

upgrade to CKeditor 4.19.1

Changes: https://ckeditor.com/cke4/release-notes

Options
    • -2
    • +2
    /openacs-4/packages/richtext-ckeditor4/richtext-ckeditor4.info
    • -3
    • +3
    /openacs-4/packages/richtext-ckeditor4/tcl/richtext-procs.tcl
2:56 pm

gustafn

Update to Boostrap 5.2.0

Bootstrap 5.2.0 was release on July 19, 2022

For changes in the new release, see

https://blog.getbootstrap.com/2022/07/19/bootstrap-5-2-0/

Options
    • -2
    • +2
    /openacs-4/packages/openacs-bootstrap5-theme/openacs-bootstrap5-theme.info
    • -3
    • +3
    /openacs-4/packages/openacs-bootstrap5-theme/tcl/resource-procs.tcl
2:47 pm

gustafn

upgrade to boostrap icons 1.9.1

Version 1.9.0 introduces 140+ new icons. For details, see:

https://blog.getbootstrap.com/2022/07/13/bootstrap-icons-1-9-0/

Options
    • -2
    • +2
    /openacs-4/packages/bootstrap-icons/bootstrap-icons.info
    • -2
    • +2
    /openacs-4/packages/bootstrap-icons/tcl/resource-procs.tcl
Tuesday 02 Aug 2022
11:05 am

gustafn

add missing page contract filter

... was missing since 22 years...

Options
    • -1
    • +1
    /openacs-4/packages/faq/www/admin/faq-edit-2.tcl
Monday 01 Aug 2022
5:33 pm

hectorr

Make 'source_feeds_ok' test case 'production_safe'

Options
    • -0
    • +1
    /openacs-4/packages/news-aggregator/tcl/test/news-aggregator-test-procs.tcl
Saturday 30 Jul 2022
2:00 pm

gustafn

file upgrade-5.10.1d9-5.10.1d10.sql was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/acs-kernel/sql/postgresql/upgrade/upgrade-5.10.1d9-5.10.1d10.sql
2:00 pm

gustafn

Adjust legacy data types of acs_object_types.object_type and acs_objects.object_type

This change addresses the problem mentioned in

https://cvs.openacs.org/changelog/OpenACS?cs=oacs-5-10%3Agustafn%3A20220729185340

https://github.com/openacs/openacs-core/commit/be44691f06627678122bd913bc3c95c80e93f403

which happens in some legacy applications (such as

e.g. openacs.org) where the data types of the following two

attributes are different.

acs_object_types.object_type

acs_objects.object_type

On new installations (at least concerning the last 10 years) these

data types are the same. So, probably an update script was missing

ages ago.

Since this change affects the basic object structure, MANY views

depend on this datatype and have to be dropped and recreate to

allow the correction of the datatype.

Therefore, we do not want to run this script on all sites, but

only on those where it is necessary.

Options
    • -2
    • +2
    /openacs-4/packages/acs-kernel/acs-kernel.info
    • -0
    • +340
    /openacs-4/packages/acs-kernel/sql/postgresql/upgrade/upgrade-5.10.1d9-5.10.1d10.sql
Friday 29 Jul 2022
8:54 pm

gustafn

whitespace fixes

Options
    • -10
    • +10
    /openacs-4/packages/acs-tcl/tcl/object-procs.tcl
8:53 pm

gustafn

Quick fix for problems with recursive query for type hierarchy on openacs.org

On OpenACS.org, the types for object_type in acs_objects and acs_object_types differs,

leading to a hard error in PostgreSQL. This is just a quick fix, the proper

fix is to investigate, why the types differ (other sites might be as well

affected by this) and to provide a proper update script.

Furthermore, the query is not Oracle compliant.

Options
    • -3
    • +3
    /openacs-4/packages/acs-tcl/tcl/object-procs.tcl
7:27 pm

gustafn

fix testcase as indicated by hector, extend regression test

Options
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/01-database-procs.tcl
    • -6
    • +20
    /openacs-4/packages/acs-tcl/tcl/test/db-proc-test-procs.tcl
Wednesday 27 Jul 2022
3:54 pm

hectorr

Extend 'db__db_foreach' test case, exposing a regression in 'db_foreach' with an uneven number of columns

Options
    • -0
    • +14
    /openacs-4/packages/acs-tcl/tcl/test/db-proc-test-procs.tcl
Friday 22 Jul 2022
7:37 pm

gustafn

Added membership "expired" to membership states. "expired" can be

used for "dormant" accounts, which are neither "banned" nor "deleted".

Options
    • -2
    • +2
    /openacs-4/packages/acs-kernel/acs-kernel.info
    • -2
    • +2
    /openacs-4/packages/acs-kernel/sql/oracle/groups-create.sql
    • -0
    • +9
    /openacs-4/packages/acs-kernel/sql/oracle/upgrade/upgrade-5.10.1d8-5.10.1d9.sql
    • -2
    • +2
    /openacs-4/packages/acs-kernel/sql/postgresql/groups-create.sql
    • -0
    • +9
    /openacs-4/packages/acs-kernel/sql/postgresql/upgrade/upgrade-5.10.1d8-5.10.1d9.sql
7:37 pm

gustafn

file upgrade-5.10.1d8-5.10.1d9.sql was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/acs-kernel/sql/oracle/upgrade/upgrade-5.10.1d8-5.10.1d9.sql
    • -0
    • +0
    /openacs-4/packages/acs-kernel/sql/postgresql/upgrade/upgrade-5.10.1d8-5.10.1d9.sql
10:05 am

gustafn

fix linebreak with bad consquences (error on page)

Options
    • -5
    • +4
    /openacs-4/packages/acs-core-docs/www/individual-programs.adp
Wednesday 20 Jul 2022
1:50 pm

gustafn

added memory units to default values

Options
    • -1
    • +1
    /openacs-4/packages/acs-tcl/tcl/acs-cache-init.tcl
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/acs-permissions-init.tcl
    • -24
    • +24
    /openacs-4/packages/acs-tcl/tcl/community-core-init.tcl
1:46 pm

gustafn

deactivate useless warning

Options
    • -4
    • +8
    /openacs-4/packages/acs-tcl/tcl/test/db-proc-test-procs.tcl