OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 5
Total Committers: 146
Last Commit: 20 Dec
Commits this week: 5
Total Lines of Code (LoC): 7,561,347
Net change in LoC this week: 335

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 4 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 29 Jul
2:01 pm

gustafn

js-libraries: improved naming of variables

Changed name "installedVersion" to "configuredVersion", since

the former might lead to the impression, that it refers only

to the locally installed version. Instead, this refers as well

to a CDN version (when available)

Options
    • -14
    • +14
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
    • -1
    • +1
    /openacs-4/packages/boomerang/tcl/boomerang-procs.tcl
    • -1
    • +1
    /openacs-4/packages/boomerang/www/sitewide-admin/index.tcl
    • -1
    • +1
    /openacs-4/packages/bootstrap-icons/tcl/resource-procs.tcl
    • -1
    • +1
    /openacs-4/packages/bootstrap-icons/www/sitewide-admin/index.tcl
    • -2
    • +2
    /openacs-4/packages/cookie-consent/tcl/cookie-consent-procs.tcl
    • -1
    • +1
    /openacs-4/packages/cookie-consent/www/sitewide-admin/index.tcl
    • -2
    • +2
    /openacs-4/packages/fa-icons/tcl/resource-procs.tcl
    • -1
    • +1
    /openacs-4/packages/fa-icons/www/sitewide-admin/index.tcl
    • -1
    • +1
    /openacs-4/packages/highcharts/tcl/resource-procs.tcl
    • -1
    • +1
    /openacs-4/packages/highcharts/www/sitewide-admin/index.tcl
    • -1
    • +1
    /openacs-4/packages/openacs-bootstrap3-theme/tcl/init-procs.tcl
    • -1
    • +1
    /openacs-4/packages/openacs-bootstrap3-theme/www/sitewide-admin/index.tcl
    • -1
    • +1
    /openacs-4/packages/openacs-bootstrap5-theme/tcl/resource-procs.tcl
    • -1
    • +1
    /openacs-4/packages/openacs-bootstrap5-theme/www/sitewide-admin/index.tcl
  16. … 4 more files in changeset.
1:56 pm

gustafn

reduced verbosity

Options
    • -1
    • +1
    /openacs-4/packages/acs-tcl/lib/check-installed.tcl
Sunday 28 Jul
7:41 pm

gustafn

js-libraries: removed variable "resourceUrl"

The variable "resourceUrl" was always used in a single branch but set

for all branches before. To ease maintenance and simplify

comprehension, it was removed.

Options
    • -2
    • +1
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
    • -3
    • +2
    /openacs-4/packages/boomerang/tcl/boomerang-procs.tcl
    • -2
    • +1
    /openacs-4/packages/bootstrap-icons/tcl/resource-procs.tcl
    • -2
    • +1
    /openacs-4/packages/cookie-consent/tcl/cookie-consent-procs.tcl
    • -2
    • +1
    /openacs-4/packages/fa-icons/tcl/resource-procs.tcl
    • -2
    • +1
    /openacs-4/packages/highcharts/tcl/resource-procs.tcl
    • -3
    • +2
    /openacs-4/packages/openacs-bootstrap3-theme/tcl/init-procs.tcl
    • -7
    • +4
    /openacs-4/packages/openacs-bootstrap5-theme/tcl/resource-procs.tcl
    • -6
    • +2
    /openacs-4/packages/richtext-ckeditor4/tcl/richtext-procs.tcl
    • -2
    • +1
    /openacs-4/packages/richtext-xinha/tcl/richtext-procs.tcl
    • -3
    • +2
    /openacs-4/packages/xowiki/tcl/resource-info-procs.tcl
7:08 pm

gustafn

tdom: "dom parse -html" implies the "simple" parser

The flag "-simple" is not needed when parsing with the flag "-html". This meanse

that

dom parse -simple -html ...

is equivalent with

dom parse -html ...

Options
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/apm-install-procs.tcl
    • -1
    • +1
    /openacs-4/packages/xowf/tcl/test-item-procs.tcl
    • -5
    • +5
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/xowiki-www-procs.tcl
7:00 pm

gustafn

Always use "--" in "dom parse" when document is interpolated

This is a safety measure to make sure that the document parsed is

never confused with an option, when the document starts with a "-". In

the best case, the error message provided by "dom parse" might be

misleading. This might be a problem for user contributed documents

(passed as variables, or return values from functions).

The double dash is supported in tdom since version 0.9.0.

Options
    • -2
    • +2
    /openacs-4/packages/acs-api-browser/tcl/acs-api-documentation-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-automated-testing/tcl/aa-test-procs.tcl
    • -1
    • +1
    /openacs-4/packages/acs-lang/tcl/test/acs-lang-test-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/30-xml-utils-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/apm-install-procs.tcl
    • -1
    • +1
    /openacs-4/packages/acs-tcl/tcl/html-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/text-html-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/test/http-client-procs.tcl
    • -2
    • +2
    /openacs-4/packages/assessment/tcl/as-qti-procs.tcl
    • -2
    • +2
    /openacs-4/packages/caldav/tcl/caldav-procs.tcl
    • -2
    • +2
    /openacs-4/packages/caldav/tcl/test/caldav-test-procs.tcl
    • -2
    • +2
    /openacs-4/packages/categories/tcl/category-xml-procs.tcl
    • -3
    • +3
    /openacs-4/packages/oacs-dav/tcl/tDAV-procs.tcl
    • -1
    • +1
    /openacs-4/packages/xowf/tcl/test-item-procs.tcl
    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/form-field-procs.tcl
  16. … 4 more files in changeset.
6:27 pm

gustafn

In essence, this change renames "version_dir" to "version_segment" as

well as "versionDir" to "versionSegment" to reflect the fact, that

this variable does not denote a directory, but a part of the path

appended to path "resourceDir".

Options
    • -4
    • +4
    /openacs-4/packages/acs-tcl/lib/check-installed.tcl
    • -27
    • +27
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
    • -2
    • +2
    /openacs-4/packages/cookie-consent/tcl/cookie-consent-procs.tcl
    • -3
    • +3
    /openacs-4/packages/highcharts/tcl/resource-procs.tcl
    • -4
    • +4
    /openacs-4/packages/openacs-bootstrap5-theme/tcl/resource-procs.tcl
2:15 pm

gustafn

various small fixes for js libraries

- fixed page contract in case a non-default version is downloaded

- provide always an argument "-version" to resource_info procs

- obtain current version number always via resource_info.installedVersion

(it refers to CDN and locally installed version)

- pass always versionDir via resource_info to ::util::resources::download

- always obtain version_dir from resource_info

Options
    • -4
    • +1
    /openacs-4/packages/acs-tcl/lib/check-installed.tcl
    • -25
    • +19
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
    • -1
    • +2
    /openacs-4/packages/boomerang/tcl/boomerang-procs.tcl
    • -1
    • +1
    /openacs-4/packages/boomerang/www/sitewide-admin/compress.tcl
    • -2
    • +2
    /openacs-4/packages/boomerang/www/sitewide-admin/index.tcl
    • -5
    • +3
    /openacs-4/packages/bootstrap-icons/tcl/resource-procs.tcl
    • -1
    • +1
    /openacs-4/packages/bootstrap-icons/www/sitewide-admin/download.tcl
    • -1
    • +1
    /openacs-4/packages/bootstrap-icons/www/sitewide-admin/index.tcl
    • -6
    • +2
    /openacs-4/packages/cookie-consent/www/sitewide-admin/download.tcl
    • -1
    • +1
    /openacs-4/packages/cookie-consent/www/sitewide-admin/index.tcl
    • -6
    • +6
    /openacs-4/packages/fa-icons/tcl/resource-procs.tcl
    • -1
    • +1
    /openacs-4/packages/fa-icons/www/sitewide-admin/download.tcl
    • -1
    • +1
    /openacs-4/packages/fa-icons/www/sitewide-admin/index.tcl
    • -13
    • +7
    /openacs-4/packages/highcharts/tcl/resource-procs.tcl
    • -1
    • +1
    /openacs-4/packages/highcharts/www/sitewide-admin/download.tcl
  16. … 11 more files in changeset.
1:57 pm

gustafn

add "--" to separate argument list from potentially confusing (and externaly provided) content

Options
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/json-procs.tcl
Friday 26 Jul
1:24 pm

antoniop

Port of downstream feature request:

when filtering for not graded questions, if the entire exam has not ungraded questions, hide the entire exam block. The purpose is to reduce distractions in the UI.

Options
    • -7
    • +12
    /openacs-4/packages/xowf/www/resources/inclass-exam.js
12:00 pm

gustafn

added handling of literal object "arraycontainer"

Options
    • -6
    • +5
    /openacs-4/packages/acs-tcl/tcl/json-procs.tcl
    • -0
    • +8
    /openacs-4/packages/acs-tcl/tcl/test/json-test-procs.tcl
Thursday 25 Jul
4:24 pm

gustafn

Improved resource information for external libraries

- added vulnerability check for a particular version

- centralized URL generation for cdnjs URLS (will reduce maintenance work, when external URL changes)

- improve behavior when running without an Internet connection

Options
    • -1
    • +6
    /openacs-4/packages/acs-tcl/lib/check-installed.adp
    • -1
    • +39
    /openacs-4/packages/acs-tcl/lib/check-installed.tcl
    • -11
    • +47
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
    • -1
    • +0
    /openacs-4/packages/bootstrap-icons/tcl/resource-procs.tcl
    • -3
    • +2
    /openacs-4/packages/cookie-consent/tcl/cookie-consent-procs.tcl
    • -1
    • +0
    /openacs-4/packages/fa-icons/tcl/resource-procs.tcl
    • -2
    • +1
    /openacs-4/packages/highcharts/tcl/resource-procs.tcl
    • -1
    • +1
    /openacs-4/packages/openacs-bootstrap3-theme/tcl/init-procs.tcl
    • -2
    • +1
    /openacs-4/packages/openacs-bootstrap5-theme/tcl/resource-procs.tcl
    • -2
    • +2
    /openacs-4/packages/richtext-ckeditor4/tcl/richtext-procs.tcl
    • -3
    • +2
    /openacs-4/packages/richtext-tinymce/tcl/richtext-procs.tcl
    • -3
    • +1
    /openacs-4/packages/xowiki/tcl/resource-info-procs.tcl
4:18 pm

gustafn

improved description of parameter

Options
    • -1
    • +1
    /openacs-4/packages/acs-kernel/acs-kernel.info
3:24 pm

mischa

Fix permission::write_permission_p. Before, the check if the user was the creation_user was always made against the currently logged in user, not the party given by the caller.

Options
    • -6
    • +9
    /openacs-4/packages/acs-tcl/tcl/acs-permissions-procs.tcl
3:08 pm

mischa

Dont fail when pk_formatted is empty.

Options
    • -1
    • +2
    /openacs-4/packages/acs-subsite/tcl/package-procs.tcl
2:50 pm

mischa

Fix default https port in security::configured_driver_info

Options
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/security-procs.tcl
11:19 am

gustafn

Extended json2dict to cover literal objects named "objectcontainer"

Extended regression test as well

Options
    • -13
    • +20
    /openacs-4/packages/acs-tcl/tcl/json-procs.tcl
    • -0
    • +8
    /openacs-4/packages/acs-tcl/tcl/test/json-test-procs.tcl
Wednesday 24 Jul
7:15 pm

gustafn

use everywhere util::json2dict

Options
    • -285
    • +0
    /openacs-4/packages/ajaxhelper/tcl/json-procs.tcl
    • -5
    • +2
    /openacs-4/packages/richtext-ckeditor4/tcl/richtext-procs.tcl
    • -4
    • +1
    /openacs-4/packages/xooauth/tcl/rest-procs.tcl
7:07 pm

gustafn

bump version numbers to reflect the updated resource-info API in acs-tcl

Options
    • -3
    • +4
    /openacs-4/packages/bootstrap-icons/bootstrap-icons.info
    • -3
    • +4
    /openacs-4/packages/fa-icons/fa-icons.info
    • -3
    • +4
    /openacs-4/packages/highcharts/highcharts.info
    • -3
    • +3
    /openacs-4/packages/openacs-bootstrap5-theme/openacs-bootstrap5-theme.info
    • -3
    • +3
    /openacs-4/packages/richtext-ckeditor4/richtext-ckeditor4.info
    • -3
    • +3
    /openacs-4/packages/richtext-tinymce/richtext-tinymce.info
    • -4
    • +5
    /openacs-4/packages/xowiki/xowiki.info
6:34 pm

gustafn

Improved consistency of resource-info for the cookieconsentlibraries, added vulnarability info

In addition, this change makes the package variable "Version" more consistent with

other occurences, where version is just the version number. Here, it was the version path.

Options
    • -7
    • +8
    /openacs-4/packages/cookie-consent/cookie-consent.info
    • -1
    • +37
    /openacs-4/packages/cookie-consent/tcl/callback-procs.tcl
    • -2
    • +8
    /openacs-4/packages/cookie-consent/tcl/cookie-consent-procs.tcl
6:31 pm

gustafn

Improved consistency of resource-info for javascript libraries, added vulnarability info

Tested the following cases:

download check

- bootstrap

- bootstrap-icons

- bootstrap-treeview

- ckeditor4

- font-awesome

- highcharts

- cookieconsent2 3.0.3

- cookieconsent2 3.1.1

CDN check

- bootstrap

- bootstrap-icons

- bootstrap-treeview

- font-awesome

- highcharts

- cookieconsent2 3.0.3

- cookieconsent2 3.1.1

Options
    • -1
    • +1
    /openacs-4/packages/bootstrap-icons/www/sitewide-admin/index.tcl
    • -1
    • +1
    /openacs-4/packages/fa-icons/www/sitewide-admin/index.adp
    • -1
    • +1
    /openacs-4/packages/fa-icons/www/sitewide-admin/index.tcl
    • -8
    • +1
    /openacs-4/packages/highcharts/tcl/resource-procs.tcl
    • -0
    • +1
    /openacs-4/packages/openacs-bootstrap3-theme/tcl/init-procs.tcl
    • -8
    • +10
    /openacs-4/packages/openacs-bootstrap5-theme/tcl/resource-procs.tcl
    • -1
    • +1
    /openacs-4/packages/richtext-ckeditor4/www/sitewide-admin/index.tcl
    • -1
    • +2
    /openacs-4/packages/richtext-tinymce/tcl/richtext-procs.tcl
    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/resource-info-procs.tcl
    • -1
    • +1
    /openacs-4/packages/xowiki/www/sitewide-admin/index.tcl
3:38 pm

gustafn

Don't set result variables for "header_stuff"

The method "header_stuff" was changes ages ago to

side-effect via the standard OpenACS template::head

interface rather than outputting to a variable, which

has to be passed around. This change removes some

leftover of this time.

Options
    • -1
    • +1
    /openacs-4/packages/xowiki/resources/templates/view-book-no-ajax.tcl
    • -3
    • +3
    /openacs-4/packages/xowiki/tcl/package-procs.tcl
3:25 pm

gustafn

Include available version number and vulnerability check on swa pages

This eases the use of external JavaScript libraries by adding

the available version number and a link for vulnerability checks

on the site-wide admin pages (when this information is available)

- bumped version number to 5.10.1b6

Options
    • -2
    • +2
    /openacs-4/packages/acs-tcl/acs-tcl.info
    • -3
    • +4
    /openacs-4/packages/acs-tcl/lib/check-installed.adp
    • -5
    • +14
    /openacs-4/packages/acs-tcl/lib/check-installed.tcl
    • -11
    • +54
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
12:01 pm

gustafn

fix broken variable name

Options
    • -3
    • +3
    /openacs-4/packages/acs-tcl/tcl/tcl-documentation-procs.tcl
11:06 am

gustafn

Do not allow unusual schemas like base64 and json as local URLs

This case was flagged by a vulnerability scan, but at least at the found instance

it was a false positive...

Options
    • -5
    • +9
    /openacs-4/packages/acs-tcl/tcl/tcl-documentation-procs.tcl
10:05 am

gustafn

Extended json2dict to cover arraycontainer

Many thank to Rolf for his feedback!

Options
    • -3
    • +9
    /openacs-4/packages/acs-tcl/tcl/json-procs.tcl
    • -1
    • +8
    /openacs-4/packages/acs-tcl/tcl/test/json-test-procs.tcl
Tuesday 23 Jul
6:10 pm

gustafn

Extended resource info dict with explicit version number and an API call to obtain the newest version number

The two new optional resource info fields are

- versionCheckAPI

- installedVersion

These fields are necessary to provide an admin page to check

whether the installed versions are the most recent ones.

Options
    • -2
    • +3
    /openacs-4/packages/bootstrap-icons/tcl/resource-procs.tcl
    • -5
    • +8
    /openacs-4/packages/cookie-consent/tcl/cookie-consent-procs.tcl
    • -1
    • +4
    /openacs-4/packages/fa-icons/tcl/resource-procs.tcl
    • -1
    • +3
    /openacs-4/packages/highcharts/tcl/resource-procs.tcl
    • -1
    • +3
    /openacs-4/packages/openacs-bootstrap3-theme/tcl/init-procs.tcl
    • -1
    • +3
    /openacs-4/packages/openacs-bootstrap5-theme/tcl/resource-procs.tcl
    • -4
    • +48
    /openacs-4/packages/richtext-ckeditor4/tcl/richtext-procs.tcl
    • -2
    • +4
    /openacs-4/packages/richtext-tinymce/tcl/richtext-procs.tcl
    • -2
    • +5
    /openacs-4/packages/xowiki/tcl/resource-info-procs.tcl
5:57 pm

gustafn

made spelling more consistent

Options
    • -1
    • +1
    /openacs-4/packages/acs-kernel/acs-kernel.info
5:56 pm

gustafn

New parameter "scroll_to" for parameter page

The new parameter allows the code to jump to a named parameter in the

parameter editing page. This is very useful for pages with a high

number of parameters, if just one parameter should be changed.

Options
    • -1
    • +9
    /openacs-4/packages/acs-subsite/www/shared/parameters.tcl
5:53 pm

gustafn

improve page title

The index page list not only the "system" test cases, but as well the

test cases from the application packages

Options
    • -3
    • +3
    /openacs-4/packages/acs-automated-testing/www/admin/index.tcl
5:26 pm

antoniop

Make parameter optional

Options
    • -1
    • +1
    /openacs-4/packages/dotlrn-bootstrap3-theme/lib/themes/bootstrap3-theme.tcl