• last updated 1 hour ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Prefer NaviServer API directly

Rework idiom

Rework idiom

Exploit page contract, rework idioms

Don't run the spiel when we are not connected

Streamline idiom

Streamline idiom

Whitespace cleanup

Modernize api

Inline rp_getform usage

rp_getform will never return the empty string, small cleanup

Remove no_alarms_until column

Rationale: the column or the related api is never used in upstream code to check whether notifications should be sent or not or not. The UI to manage the column's value was not linked anywhere. On the instances accessible by me downstream, no tuple was found where this column had a value.

  1. … 4 more files in changeset.
file upgrade-5.10.1d17-5.10.1d18.sql was initially added on branch oacs-5-10.

Avoid fetching the request forum manually

Whitespace and comment cleanup

Cleanup redundant parameter fetching

Fix typo

Update documentation

put the notification creation in a db_transaction to ensure same subscription is created only once (e.g. double-clicks)

improve input validation

Apply downstream fixes

Test of the calendar portlet, admin and regular, for all views

The tests exposes typos and forgottent variables in upstream code

Test bm_portlet::show, but then make it private: it is not supposed to be invoked on its own, but via the Service Contract API

Claim additional coverage

Basic test of acs_mail_lite::send

file acs-mail-lite-procs.tcl was initially added on branch oacs-5-10.

Make acs_mail_lite::utils::build_body, replace (commented) references in other packages

    • -2
    • +0
    /openacs-4/packages/xowf/tcl/xowf-procs.tcl
Complete coverage for the package

file lang-widget-procs.tcl was initially added on branch oacs-5-10.

    • -0
    • +0
    /openacs-4/packages/acs-lang/tcl/test/lang-widget-procs.tcl
State new dependencies