• last updated 1 hour ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Deprecate export_entire_form

Deprecate util_AnsiDatetoPrettyDate

    • -2
    • +2
    /openacs-4/packages/survey/www/admin/one.tcl
Deprecate util_report_library_entry

Formatting changes

Deprecate util::string_check_urlsafe

Simplify implementation

After some experiments, reinstate the faster version of util_sets_equal_p: this wins (~20% faster) in particular when the sets to be compared are larger

Cleanup duplicated and slower proc definition

Small improvements:

- use "string is space" instead of trimming the string and checking if empty, at least 2x faster on development, wherever we don't need the trimmed value

- modernize leftover foreach trick with lassign

Use faster idiom to tell if a string is only space

Fall back to en_US also when a value for nls_language is there, but empty

Use api to determine whether a field is disabled, as the "disabled" variable will always be set now

    • -1
    • +1
    /openacs-4/packages/xowiki/tcl/repeat-procs.tcl
Claim additional coverage

Count already exisring handlers before introducing new ones

Improve acs::test::form_reply so that when the attributes of a file upload (*.tmpfile or *.content-type) are part of the update argument, it will switch automatically to a multipart request and implement a "real" file upload

This is important on newer NaviServer versions that will reject any *.tmpfile parameter in a request that was not produced internally after a file upload

add the amount of questions from the exam in the title

Test also nonce rendering

Make test more precise

Test a bunch more api

Test template::adp_level, fix test coverage declaration

Test template::adp_parse_string

Deprecate template::adp_levels, found nowhere in the upstream codebase and superseded by template::adp_level

Increase proc coverage

State additional proc coverage, improve documentation

Make template::head::prepare_multirows a private interface: its stated purpose is to be used inside of the blank-master and it has no practical use otherwise

Make adp_parse_ad_conn_file a private interface: its stated purpose is to be registered via rp_register_extension_handler in acs-templating/tcl/acs-integration-init.tcl and it has no practical use otherwise

Test ad_return_template

Reuse computation

Avoid catch where a more appropriate idiom exists

Improve documentation