Activity OpenACS/

5:57 pm

antoniop

After some experiments, reinstate the faster version of util_sets_equal_p: this wins (~20% faster) in particular when the sets to be compared are larger

- -15
- +2
/openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../utilities-procs.tcl

5:19 pm

antoniop

Cleanup duplicated and slower proc definition

- -13
- +1
/openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../utilities-procs.tcl

5:07 pm

antoniop

Small improvements:

- use "string is space" instead of trimming the string and checking if empty, at least 2x faster on development, wherever we don't need the trimmed value

- modernize leftover foreach trick with lassign

- -2
- +2
/openacs-4/packages/acs-lang/tcl/lang-message-procs.tcl
- History
- Source
- Diff
/openacs-4/.../lang-message-procs.tcl
- -2
- +2
/openacs-4/packages/acs-subsite/www/pvt/alerts.tcl
- History
- Source
- Diff
/openacs-4/packages/.../pvt/alerts.tcl
- -2
- +2
/openacs-4/packages/acs-tcl/tcl/text-html-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../text-html-procs.tcl
- -11
- +8
/openacs-4/packages/acs-templating/tcl/list-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../tcl/list-procs.tcl
- -2
- +2
/openacs-4/packages/acs-templating/tcl/parse-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../tcl/parse-procs.tcl
- -3
- +3
/openacs-4/packages/xotcl-core/tcl/03-doc-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../tcl/03-doc-procs.tcl
- -2
- +4
/openacs-4/packages/xowiki/tcl/xowiki-form-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../xowiki-form-procs.tcl

4:48 pm

antoniop

Use faster idiom to tell if a string is only space

- -2
- +2
/openacs-4/packages/acs-automated-testing/www/admin/testcase.tcl
- History
- Source
- Diff
/openacs-4/packages/.../admin/testcase.tcl

4:10 pm

antoniop

Fall back to en_US also when a value for nls_language is there, but empty

- -2
- +5
/openacs-4/packages/xowiki/tcl/xowiki-form-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../xowiki-form-procs.tcl

1:31 pm

antoniop

Use api to determine whether a field is disabled, as the "disabled" variable will always be set now

- -1
- +1
/openacs-4/packages/xowiki/tcl/repeat-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../tcl/repeat-procs.tcl

4:15 pm

antoniop

Claim additional coverage

- -1
- +4
/openacs-4/packages/acs-templating/tcl/test/parse-test-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../parse-test-procs.tcl

4:14 pm

antoniop

Count already exisring handlers before introducing new ones

- -4
- +11
/openacs-4/packages/acs-templating/tcl/test/parse-test-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../parse-test-procs.tcl

3:18 pm

Improve acs::test::form_reply so that when the attributes of a file upload (*.tmpfile or *.content-type) are part of the update argument, it will switch automatically to a multipart request and implement a "real" file upload

This is important on newer NaviServer versions that will reject any *.tmpfile parameter in a request that was not produced internally after a file upload

- -14
- +45
/openacs-4/packages/acs-automated-testing/tcl/aa-test-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../tcl/aa-test-procs.tcl
- -31
- +0
/openacs-4/packages/acs-templating/tcl/test/file-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../test/file-procs.tcl

1:15 pm

trenner

add the amount of questions from the exam in the title

- -1
- +1
/openacs-4/packages/xowf/tcl/test-item-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../test-item-procs.tcl

10:46 am

antoniop

Test also nonce rendering

- -1
- +7
/openacs-4/packages/acs-templating/tcl/test/parse-test-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../parse-test-procs.tcl

10:31 am

antoniop

Make test more precise

- -9
- +12
/openacs-4/packages/acs-templating/tcl/test/parse-test-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../parse-test-procs.tcl

6:56 pm

antoniop

Test a bunch more api

- -1
- +146
/openacs-4/packages/acs-templating/tcl/test/parse-test-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../parse-test-procs.tcl

6:19 pm

antoniop

Test template::adp_level, fix test coverage declaration

- -3
- +36
/openacs-4/packages/acs-templating/tcl/test/parse-test-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../parse-test-procs.tcl

6:10 pm

antoniop

Test template::adp_parse_string

- -1
- +16
/openacs-4/packages/acs-templating/tcl/test/parse-test-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../parse-test-procs.tcl

6:04 pm

antoniop

Deprecate template::adp_levels, found nowhere in the upstream codebase and superseded by template::adp_level

- -2
- +3
/openacs-4/packages/acs-templating/tcl/parse-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../tcl/parse-procs.tcl

5:52 pm

antoniop

Increase proc coverage

- -39
- +62
/openacs-4/packages/acs-templating/tcl/test/parse-test-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../parse-test-procs.tcl

5:32 pm

antoniop

State additional proc coverage, improve documentation

- -2
- +4
/openacs-4/packages/acs-templating/tcl/parse-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../tcl/parse-procs.tcl
- -0
- +1
/openacs-4/packages/acs-templating/tcl/test/file-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../test/file-procs.tcl
- -1
- +2
/openacs-4/packages/acs-templating/tcl/test/parse-test-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../parse-test-procs.tcl

5:03 pm

antoniop

Make template::head::prepare_multirows a private interface: its stated purpose is to be used inside of the blank-master and it has no practical use otherwise

- -1
- +1
/openacs-4/packages/acs-templating/tcl/head-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../tcl/head-procs.tcl

4:50 pm

antoniop

Make adp_parse_ad_conn_file a private interface: its stated purpose is to be registered via rp_register_extension_handler in acs-templating/tcl/acs-integration-init.tcl and it has no practical use otherwise