OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 6
Total Committers: 146
Last Commit: 21 Nov
Commits this week: 6
Total Lines of Code (LoC): 7,560,943
Net change in LoC this week: 122

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 3 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 18 Dec 2018
5:13 pm

antoniop

Put event handler inline so is attached at element creation, fix URLencoding of image deletion

Options
    • -1
    • +8
    /openacs-4/packages/xowiki/www/ckeditor-images/thumb-view.adp
    • -9
    • +6
    /openacs-4/packages/xowiki/www/ckeditor-images/thumb-view.tcl
4:42 pm

antoniop

Bring event handler inline to force it being attached after the upload button is added to the page

Options
    • -2
    • +5
    /openacs-4/packages/xowiki/www/ckeditor-images/upload_image.adp
4:26 pm

antoniop

Add missing parameter in calc_wiki_image_links_to_image_tags

See bug tracker #3372

Options
    • -2
    • +2
    /openacs-4/packages/xowiki/www/resources/ckeip.js
3:22 pm

gustafn

add message key

Options
    • -0
    • +1
    /openacs-4/packages/xowiki/catalog/xowiki.en_US.ISO-8859-1.xml
Monday 17 Dec 2018
9:47 pm

gustafn

whitespace changes

Options
    • -53
    • +53
    /openacs-4/packages/acs-templating/tcl/tag-init.tcl
    • -35
    • +34
    /openacs-4/packages/acs-templating/tcl/tag-procs.tcl
9:46 pm

gustafn

add error, when we are running out of handles

Options
    • -3
    • +7
    /openacs-4/packages/acs-tcl/tcl/00-database-procs.tcl
9:17 pm

gustafn

reduce verbosity, deactivate usage 'ns_db currenthandles' for now

Options
    • -13
    • +13
    /openacs-4/packages/acs-tcl/tcl/00-database-procs.tcl
7:12 pm

gustafn

reveive dotlrn community includelet

Options
    • -0
    • +222
    /openacs-4/packages/xowiki/tcl/dotlrn-portal-procs.tcl
7:00 pm

gustafn

modernize code

Options
    • -5
    • +5
    /openacs-4/packages/xowiki/tcl/chat-procs.tcl
6:58 pm

gustafn

prefer "array size" over llength of names

Options
    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/import-procs.tcl
6:58 pm

gustafn

prefer "-base" parameter of export_vars

Options
    • -1
    • +1
    /openacs-4/packages/xowiki/tcl/test/test-procs.tcl
6:54 pm

gustafn

add quotes for nicer editor rendering

Options
    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/form-field-procs.tcl
    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/package-procs.tcl
3:35 pm

gustafn

fix typo

Options
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/00-database-procs.tcl
3:29 pm

gustafn

db_handle reform

Use "ns_db currenthandles" (when available) to implement "db_with_handle"

instead of the old approach based on the global db_state variables.

The enws approach has the advantantge that it is

- more robust (deletion and creation of the per-request variables,

no coherency problem),

- simpler, and

- faster (less overhead per db_with_handle call, simple queries up to 20% faster)

time {db_string . {select object_id from acs_objects limit 1}} 1000

old: 200-230 microseconds per iteration

new: 160-180 microseconds per iteration

Options
    • -113
    • +334
    /openacs-4/packages/acs-tcl/tcl/00-database-procs.tcl
11:39 am

antoniop

Replace single quotes wuith double quotes in javascript expressions involving acs_ListBulkActionClick

this is really needed only for the URL part, but was done on the name as well for consistency. The reason

is even a properly encoded URL could still contain single quotes, therefore breaking the expression,

while double quotes are expected to be encoded in valid, urlencoded URLs. This relies on trusting the developer

to properly encode URLs, which should be expected. An alternative could involve active escaping of

javascript special characters by e.g. ad_js_escape.

Options
    • -1
    • +1
    /openacs-4/packages/acs-templating/resources/lists/courses.adp
    • -1
    • +1
    /openacs-4/packages/acs-templating/resources/lists/table-2third.adp
    • -1
    • +1
    /openacs-4/packages/acs-templating/resources/lists/table.adp
    • -1
    • +1
    /openacs-4/packages/openacs-bootstrap3-theme/resources/lists/table-2third.adp
    • -1
    • +1
    /openacs-4/packages/openacs-bootstrap3-theme/resources/lists/table.adp
    • -2
    • +2
    /openacs-4/packages/xotcl-core/tcl/30-widget-procs.tcl
    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/bootstrap-procs.tcl
10:48 am

gustafn

[PostgreSQL 11] Change 'with (iscachable)' to IMMUTABLE for PG11

Options
    • -2
    • +2
    /openacs-4/packages/soap-gateway/sql/postgresql/soap-gateway-create.sql
10:13 am

michaela

[PostgreSQL 11] Change 'with (iscachable)' to IMMUTABLE for PG11

Options
    • -1
    • +1
    /openacs-4/packages/acs-kernel/sql/postgresql/postgresql.sql
Saturday 15 Dec 2018
7:07 pm

gustafn

backport from oacs-5-9, which might avoid problems with oacs 5-8 when used with recent versions of nsf

Options
    • -0
    • +9
    /openacs-4/packages/xotcl-core/tcl/01-debug-procs.tcl
6:46 pm

gustafn

fix typo

Options
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/text-html-procs.tcl
Friday 14 Dec 2018
9:15 pm

gustafn

perform javascript escaping with more regular semantics

Options
    • -9
    • +11
    /openacs-4/packages/acs-tcl/tcl/text-html-procs.tcl
    • -4
    • +11
    /openacs-4/packages/acs-tcl/tcl/test/text-html-procs.tcl
4:11 pm

antoniop

Introduce new ad_js_escape with the purpose of sanitizing tcl strings used inside javascript code from escape sequences and from quotes in particular and provide some test cases

TODO: consider its usage into templates when e.g. we are putting a URL into javascript functions such as acs_ListBulkActionClick. URLs might in fact contain single and double quotes.

Options
    • -1
    • +22
    /openacs-4/packages/acs-tcl/tcl/text-html-procs.tcl
    • -0
    • +19
    /openacs-4/packages/acs-tcl/tcl/test/text-html-procs.tcl
Wednesday 12 Dec 2018
7:20 pm

antoniop

Provide some basic way to create subgroups via the UI

Options
    • -2
    • +3
    /openacs-4/packages/acs-subsite/www/admin/groups/one.adp
    • -2
    • +7
    /openacs-4/packages/acs-subsite/www/admin/groups/one.tcl
Tuesday 11 Dec 2018
5:48 pm

antoniop

Actually store the group name in the UI by intercepting the right form var

Options
    • -2
    • +3
    /openacs-4/packages/acs-subsite/www/admin/groups/new.tcl
5:23 pm

antoniop

Fix test test by considering that group pretty name is automatically localized

Options
    • -3
    • +10
    /openacs-4/packages/acs-subsite/tcl/test/acs-subsite-procs.tcl
5:21 pm

antoniop

Don't quote some function defaults that are meant to be evaluated literally

Options
    • -7
    • +17
    /openacs-4/packages/acs-subsite/tcl/plpgsql-utility-procs.tcl
3:35 pm

antoniop

New automated test doing the roundrtrip of group-type related API

Note that this is currently failing due to a bug in package_instantiate_object, which triggered the creation of this test.

Options
    • -1
    • +53
    /openacs-4/packages/acs-subsite/tcl/test/acs-subsite-procs.tcl
3:14 pm

antoniop

Move logics to delete a group type into the API

Options
    • -1
    • +34
    /openacs-4/packages/acs-subsite/tcl/group-type-procs-oracle.xql
    • -1
    • +31
    /openacs-4/packages/acs-subsite/tcl/group-type-procs-postgresql.xql
    • -1
    • +71
    /openacs-4/packages/acs-subsite/tcl/group-type-procs.tcl
    • -79
    • +0
    /openacs-4/packages/acs-subsite/www/admin/group-types/delete-2-oracle.xql
    • -85
    • +0
    /openacs-4/packages/acs-subsite/www/admin/group-types/delete-2-postgresql.xql
    • -62
    • +6
    /openacs-4/packages/acs-subsite/www/admin/group-types/delete-2.tcl
    • -14
    • +0
    /openacs-4/packages/acs-subsite/www/admin/group-types/delete-2.xql
2:25 pm

antoniop

Fix quoting of group type

Options
    • -1
    • +1
    /openacs-4/packages/acs-subsite/www/admin/group-types/delete-2-postgresql.xql
12:26 pm

antoniop

Remove unneeded variable

Options
    • -7
    • +1
    /openacs-4/packages/acs-subsite/tcl/subsite-procs.tcl
12:20 pm

antoniop

Add (trivial) ad_include_contract

Options
    • -1
    • +5
    /openacs-4/packages/acs-subsite/lib/subsites.tcl