• last updated 20 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Removed duplicate requirement for notifications. Bug #1469 ...

Added get_url proc so that notifications work properly.

Added notifications as a required package.

Removed unused functions

    • -53
    • +1
    ./sql/postgresql/cal-item-create.sql
Links to days outside of the current month did not work.

ul.action-links

Added some paragraphs. Want them to be backed up.

Removed a lot of crap (this time by me)

Rmoved - it is either obvious nor not true anymore.

Removed crufty old code, fixed package creation

    • -181
    • +1
    ./sql/oracle/calendar-create.sql
Fixed the queries for Oracle

Require notifications.

Added notifications to Oracle. It's currently broken because acs-mail-lite is broken, but my code works syntactically at least.

    • -0
    • +56
    ./sql/oracle/calendar-notifications-init.sql
Added a newline

Removed open message key. (Typo)

    • -1
    • +0
    ./catalog/calendar.en_US.ISO-8859-1.xml
Added notifications to calendar. Currently works only for PostgreSQL, will do the port to Oracle in the next 4 weeks.

    • -0
    • +3
    ./catalog/calendar.en_US.ISO-8859-1.xml
    • -0
    • +64
    ./sql/postgresql/calendar-notifications-init.sql
Removed large chunks of commented-out Oracle code.

Removed unused pgplsql procs - that looked very broken and haven't been used in over two years.

    • -613
    • +5
    ./sql/postgresql/calendar-create.sql
Updated the info file

Removed unnecessary comment

Removed a broken query

    • -20
    • +0
    ./www/view-week-display-postgresql.xql
Lumped all the different view-pages' query into one thus drastically slashing the amount of code that looks subtly different but effectively always retrieves calendar items for a particular interval.

    • -39
    • +0
    ./www/view-list-display-postgresql.xql
    • -33
    • +0
    ./www/view-month-display-oracle.xql
    • -34
    • +0
    ./www/view-month-display-postgresql.xql
    • -79
    • +0
    ./www/view-one-day-display-oracle.xql
    • -79
    • +0
    ./www/view-one-day-display-postgresql.xql
    • -13
    • +3
    ./www/view-week-display-postgresql.xql
    • -0
    • +53
    ./www/views-oracle.xql
    • -0
    • +49
    ./www/views-postgresql.xql
The date format string is constant - it is always the ANSI date format. There is no need to create a variable in TCL and then pass it on as a bind variable to the database. Instead I have hard-wired the format string into the database which means less code and maybe even slightly more efficiency.

    • -2
    • +2
    ./www/view-list-display-postgresql.xql
    • -4
    • +4
    ./www/view-month-display-postgresql.xql
    • -6
    • +6
    ./www/view-one-day-display-postgresql.xql
    • -6
    • +6
    ./www/view-week-display-postgresql.xql
Moved cal-item-2-procs stuff into cal-item-procs. i

Moved all procs into calendar::item namespace.

Removed unused queries.

    • -105
    • +0
    ./tcl/cal-item-2-procs-oracle.xql
    • -101
    • +0
    ./tcl/cal-item-2-procs-postgresql.xql
    • -20
    • +116
    ./tcl/cal-item-procs-oracle.xql
    • -17
    • +111
    ./tcl/cal-item-procs-postgresql.xql
    • -1
    • +1
    ./www/cal-item-delete-all-occurrences.tcl
removed unused proc calendar_public_p

removed proc calendar_update which did exactly the same as rename - but wasn't that aptly named

moved calendar_get_name into calendar namespace

removed queries that were duplicated both in tcl and in xql files.

removed obviously unnecessary comments

Removing unused files. The calendar admin interface was completely broken and replaced during the Hamburg bug bash (kudos to Lars). Most of the code in the removed files basically duplicated OpenACS code from somewhere else. Now that calendar is making proper use of OpenACS this stuff is a) not necessary anymore and b) has never worked anyway.

    • -40
    • +0
    ./www/admin/cal-item-permissions-oracle.xql
    • -50
    • +0
    ./www/admin/cal-item-permissions-postgresql.xql
    • -142
    • +0
    ./www/admin/cal-item-permissions.adp
    • -146
    • +0
    ./www/admin/cal-item-permissions.tcl
    • -28
    • +0
    ./www/admin/cal-item-permissions.xql
    • -28
    • +0
    ./www/admin/calendar-permissions-oracle.xql
    • -28
    • +0
    ./www/admin/calendar-permissions-postgresql.xql
    • -94
    • +0
    ./www/admin/calendar-permissions.adp
    • -125
    • +0
    ./www/admin/calendar-permissions.tcl
    • -28
    • +0
    ./www/admin/calendar-permissions.xql
    • -46
    • +0
    ./www/admin/calendar-preferences-oracle.xql
    • -28
    • +0
    ./www/admin/calendar-preferences-postgresql.xql
    • -103
    • +0
    ./www/admin/calendar-preferences.adp
    • -80
    • +0
    ./www/admin/calendar-preferences.tcl
  1. … 3 more files in changeset.
Removed unused queries calendar_create_private.get_user_name,calendar_public_p.check_calendar_permission

    • -79
    • +40
    ./tcl/calendar-procs-postgresql.xql
Moved to calendar-2-procs.tcl to calendar-procs.tcl and removed unused procs calendar_make_date, calendar_create_private, calendar_update

    • -30
    • +0
    ./tcl/calendar-2-procs-postgresql.xql
    • -0
    • +24
    ./tcl/calendar-procs-postgresql.xql
Spiffed up month display

merge of changes on oacs-5-0 branch to oacs-5-0-0b4 tag

    • -0
    • +2
    ./catalog/calendar.en_US.ISO-8859-1.xml
    • -12
    • +7
    ./sql/postgresql/calendar-create.sql
    • -0
    • +11
    ./sql/postgresql/upgrade/upgrade-2.0d1-2.0b2.sql
    • -46
    • +56
    ./tcl/cal-item-2-procs-oracle.xql
    • -3
    • +15
    ./tcl/cal-item-2-procs-postgresql.xql
    • -3
    • +16
    ./tcl/calendar-2-procs-postgresql.xql
    • -195
    • +258
    ./tcl/calendar-2-procs.tcl
  1. … 584 more files in changeset.
Added automated test

  1. … 3 more files in changeset.