• last updated 5 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Ooops, forgot to rename a variable

Reodered the steps to build the message parts first, then add the headers using mime::setheaders (except To, From, CC and BCC). Retrieve the message as a string only if delivery mode is not set to default (smtp). Tested successfully with tcllib 1.8 and 1.10 (unless I missed something)

After discussion in the OCT, rolled this back. And leave it rolled back.

Fixed problem with complex send not knowing about the new valid_email_p procedure. additionally made sure that no empty header could be passed, as this breaks smtp::sendmail

Bumped version numbers ...

  1. … 21 more files in changeset.
Bumped info files, which I forgot to do before putting up the beta tarball.

  1. … 21 more files in changeset.
Bumped version numbers to 5.4.0

  1. … 21 more files in changeset.
Fix bug in subject encoding proc

A variety of things ...

1. maturity level of acs-mail-lite/notifications set to 2 until final release

2. intermedia bumped to 5.4.0b1 (missed this earlier) and maturity to 3

3. tsearch2-driver maturity set to 3

  1. … 4 more files in changeset.
Bumped version numbers...

  1. … 20 more files in changeset.
Added an explicit blank body to two callbacks added by Malte, so automated

tests will pass. This is about the third release in which I've had to do

this. Simply adding "-" after the empty doc comment block is sufficient,

ad_proc treats that as an empty body.

    • -3
    • +3
    ./tcl/acs-mail-lite-callback-procs.tcl
Fixed oracle syntax - add doesn't allow "column", unlike PG

Removed these two procs entirely, since a search of packages and contrib shows

that nothing in our tree uses them (and no package outside of acs-mail-lite

should've used them in the first place).

Use DCC header instead of the BCC one in call to ::smtp::sendmessage

Move complex_smtp to smtp. Mark ::sendmail and ::deliver_mail as deprecated

Forgot to rename a column in my previous commit

Upgrade scripts and fix datamodel consistency

    • -17
    • +27
    ./sql/oracle/acs-mail-lite-create.sql
    • -0
    • +29
    ./sql/oracle/upgrade/upgrade-5.4.0d2-5.4.0d3.sql
    • -15
    • +23
    ./sql/postgresql/acs-mail-lite-create.sql
    • -0
    • +24
    ./sql/postgresql/upgrade/upgrade-5.4.0d2-5.4.0d3.sql
    • -3
    • +3
    ./tcl/acs-mail-lite-procs-postgresql.xql
Join upgrade scripts into one with correct

version number.

    • -0
    • +59
    ./sql/oracle/upgrade/upgrade-5.4.0d1-5.4.0d2.sql
    • -4
    • +4
    ./sql/postgresql/acs-mail-lite-create.sql
    • -38
    • +0
    ./sql/postgresql/upgrade/upgrade-1.3b7-1.3b8.sql
    • -0
    • +51
    ./sql/postgresql/upgrade/upgrade-5.4.0d1-5.4.0d2.sql
Move complex stuff to separated scripts

    • -40
    • +2
    ./sql/oracle/acs-mail-lite-create.sql
    • -0
    • +47
    ./sql/oracle/complex-create.sql
    • -0
    • +9
    ./sql/oracle/complex-drop.sql
    • -33
    • +2
    ./sql/postgresql/acs-mail-lite-create.sql
    • -2
    • +3
    ./sql/postgresql/acs-mail-lite-drop.sql
    • -0
    • +39
    ./sql/postgresql/complex-create.sql
    • -0
    • +9
    ./sql/postgresql/complex-drop.sql
Remove duplicated proc

Remove unused queries. Remove from generic xql queries that are different for each db and already in the appropriate xql

Ooops! forgot to add the after_upgrade callback in the info file

Ooops! forgot to add the after_upgrade callback in the info file

Remove sendmail procs to use smtp only. Remove SendmailBin parameter (not used anymore)

    • -0
    • +34
    ./tcl/apm-callback-procs.tcl
Replace send procs with a refactored version of complex_send, allowing cc, bcc and attachments

    • -23
    • +52
    ./tcl/acs-mail-lite-callback-procs.tcl
    • -25
    • +47
    ./tcl/acs-mail-lite-procs-oracle.xql
    • -25
    • +48
    ./tcl/acs-mail-lite-procs-postgresql.xql
    • -202
    • +269
    ./tcl/acs-mail-lite-procs.tcl
Update calls to utils procs adding the namespace

Move helper procs for sending email to acs-mail-lite

    • -0
    • +157
    ./tcl/utils-procs.tcl
  1. … 1 more file in changeset.
Removed the MMEncodeBin parameter, which is no longer used.

Rolling back to the working version (decided during informal OCT in IRC today)

    • -316
    • +334
    ./tcl/complex-send-procs.tcl
  1. … 1 more file in changeset.
Add missing join