• last updated 14 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Added an explicit blank body to two callbacks added by Malte, so automated

tests will pass. This is about the third release in which I've had to do

this. Simply adding "-" after the empty doc comment block is sufficient,

ad_proc treats that as an empty body.

    • -3
    • +3
    ./tcl/acs-mail-lite-callback-procs.tcl
Fixed oracle syntax - add doesn't allow "column", unlike PG

Removed these two procs entirely, since a search of packages and contrib shows

that nothing in our tree uses them (and no package outside of acs-mail-lite

should've used them in the first place).

Use DCC header instead of the BCC one in call to ::smtp::sendmessage

Move complex_smtp to smtp. Mark ::sendmail and ::deliver_mail as deprecated

Forgot to rename a column in my previous commit

Upgrade scripts and fix datamodel consistency

    • -17
    • +27
    ./sql/oracle/acs-mail-lite-create.sql
    • -0
    • +29
    ./sql/oracle/upgrade/upgrade-5.4.0d2-5.4.0d3.sql
    • -15
    • +23
    ./sql/postgresql/acs-mail-lite-create.sql
    • -0
    • +24
    ./sql/postgresql/upgrade/upgrade-5.4.0d2-5.4.0d3.sql
    • -3
    • +3
    ./tcl/acs-mail-lite-procs-postgresql.xql
Join upgrade scripts into one with correct

version number.

    • -0
    • +59
    ./sql/oracle/upgrade/upgrade-5.4.0d1-5.4.0d2.sql
    • -4
    • +4
    ./sql/postgresql/acs-mail-lite-create.sql
    • -38
    • +0
    ./sql/postgresql/upgrade/upgrade-1.3b7-1.3b8.sql
    • -0
    • +51
    ./sql/postgresql/upgrade/upgrade-5.4.0d1-5.4.0d2.sql
Move complex stuff to separated scripts

    • -40
    • +2
    ./sql/oracle/acs-mail-lite-create.sql
    • -0
    • +47
    ./sql/oracle/complex-create.sql
    • -0
    • +9
    ./sql/oracle/complex-drop.sql
    • -33
    • +2
    ./sql/postgresql/acs-mail-lite-create.sql
    • -2
    • +3
    ./sql/postgresql/acs-mail-lite-drop.sql
    • -0
    • +39
    ./sql/postgresql/complex-create.sql
    • -0
    • +9
    ./sql/postgresql/complex-drop.sql
Remove duplicated proc

Remove unused queries. Remove from generic xql queries that are different for each db and already in the appropriate xql

Ooops! forgot to add the after_upgrade callback in the info file

Ooops! forgot to add the after_upgrade callback in the info file

Remove sendmail procs to use smtp only. Remove SendmailBin parameter (not used anymore)

    • -0
    • +34
    ./tcl/apm-callback-procs.tcl
Replace send procs with a refactored version of complex_send, allowing cc, bcc and attachments

    • -23
    • +52
    ./tcl/acs-mail-lite-callback-procs.tcl
    • -25
    • +47
    ./tcl/acs-mail-lite-procs-oracle.xql
    • -25
    • +48
    ./tcl/acs-mail-lite-procs-postgresql.xql
    • -202
    • +269
    ./tcl/acs-mail-lite-procs.tcl
Update calls to utils procs adding the namespace

Move helper procs for sending email to acs-mail-lite

    • -0
    • +157
    ./tcl/utils-procs.tcl
  1. … 1 more file in changeset.
Removed the MMEncodeBin parameter, which is no longer used.

Rolling back to the working version (decided during informal OCT in IRC today)

    • -316
    • +334
    ./tcl/complex-send-procs.tcl
  1. … 1 more file in changeset.
Add missing join

Import of message keys from translation server for core and .LRN packages.

This catalogs have no package version info. Check http://openacs.org/forums/message-view?message%5fid=1007666

    • -1
    • +1
    ./catalog/acs-mail-lite.ca_ES.ISO-8859-1.xml
    • -1
    • +1
    ./catalog/acs-mail-lite.de_DE.ISO-8859-1.xml
    • -1
    • +1
    ./catalog/acs-mail-lite.en_US.ISO-8859-1.xml
    • -1
    • +1
    ./catalog/acs-mail-lite.gl_ES.ISO-8859-1.xml
    • -1
    • +1
    ./catalog/acs-mail-lite.nl_NL.ISO-8859-1.xml
    • -1
    • +1
    ./catalog/acs-mail-lite.pl_PL.utf-8.xml
    • -1
    • +1
    ./catalog/acs-mail-lite.pt_BR.ISO-8859-1.xml
  1. … 1295 more files in changeset.
Fix typo, llength spelled incorrectly.

Cleaned up complex_send, broke it down into multiple parts, refactored repetitive things into foreach loops, made sure rollout support is handled in complex_smtp, thopugh I have no idea how to do the filters there.... This is in need of testing and should only act as a commit for the OCT to decide if this is going in the right direction.

    • -333
    • +315
    ./tcl/complex-send-procs.tcl
Fix message initialization. Was failing in case the message has no alternative and no attachament. In case the message has an alternative and no attachment, it was initialized twice.

I think I fixed the problem with multipart/mixed of e-mails with no attachments. This should be tested though. I am putting this out to see if I might have a mismatch in my train of thought.

Fixed the confusion about single_email_p in complex_send_immediately using the defaults which make most sense. Fixed documentation accordingly

Fix malformed date and encode subject (using helper procs). Set the charset for message body (utf-8)

Turn ds_comment into ns_log debug

Indent code

    • -5
    • +5
    ./tcl/acs-mail-lite-callback-procs.tcl
    • -389
    • +389
    ./tcl/acs-mail-lite-procs.tcl
    • -562
    • +562
    ./tcl/complex-send-procs.tcl
HTML 4.01 Strict cleanup

  1. … 27 more files in changeset.