• last updated 23 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Added link to developer-support home

- Design improvements

- Fixed problems caused by untrusted_user_id as mentioned in forums thread

    • -19
    • +20
    ./acs-developer-support-procs.tcl
all TCL's clock clicks always with the -milliseconds option. The TCL manual

explicitly states that without this switch the return result is platform

dependant. The OpenACS code works at the millisecond granulartiy and silently

assumes that 1 millisecond equals 1000 clicks which is not necessarily true.

I used this shell script to automatize the replacing:

#!/bin/bash

for file in `grep -lsr "\[clock clicks\]" /web/openacs-head/packages/ `; do

echo "repairing $file"

sed "s/\[clock clicks\]/\[clock clicks -milliseconds\]/g" $file > fout

mv fout $file

done

And then grepped for

grep -r "expr.*clock clicks" /web/openacs-head/packages/

to manually remove the divisions by 1000.

  1. … 10 more files in changeset.
merge of changes on oacs-5-0 branch to oacs-5-0-0b4 tag

  1. … 597 more files in changeset.
allow variable subst in query on errno 2 (return)

adding ability watch whole packages on server startup with the PackageWatchList parameter

dont bind sql in ds_collect_db_call if errno nonzero since it messes up the traceback sometimes

    • -28
    • +31
    ./acs-developer-support-procs.tcl
close tr tag bug 1061 patch 335 Randy o'Meara

make some Notices either warnings or debug and made them more descriptive by generally including the proc name as well bug #1032

  1. … 74 more files in changeset.
changed Notice to Debug or warning in ns_log commands

Allow flipping the database-statistics without a server restart

    • -18
    • +36
    ./acs-developer-support-procs.tcl
  1. … 2 more files in changeset.
More for bug #814.

  1. … 6 more files in changeset.
Part of the fix for bug #814. I will proceed in a per-package fashion.

Use apm_package_url_from_key

merge of 4.6.3b1 to HEAD

    • -67
    • +67
    ./acs-developer-support-procs.tcl
  1. … 42 more files in changeset.
Changes to the APM caused installation of this package to break things.

Someone beat me to it but this cleaner ...

working around error message reported here: http://openacs.org/forums/message-view?message_id=89854 by checking in ds_user_switching_enabled_p if the nsv exists (this happens at an unfortunate time when the acs-developer-support procs have been sourced, but not the init file)

properly support EnabledIPs parameter.

check is ds_enabled_p in ds_add

fix date format on request-info page

change sweeper so it can sweep data even if

there is no start record with the request.

package key is acs-developer-support no developer-support.

    • -25
    • +30
    ./acs-developer-support-procs.tcl
  1. … 1 more file in changeset.
Fixed problem with installing developer support causing subsequent packages to not load as per http://openacs.org/forums/message-view?message_id=78516

    • -32
    • +40
    ./acs-developer-support-procs.tcl
Making developer support show bind variable values in queries (only for PG) - thanks Lars. Adding a check in the -init.tcl file so that setup of nsv vars etc is only done once. The new APM will source -init.tcl files once per interpreter - we need to be wary of that.

Merge of all changes from oacs-4-6 to HEAD. All changes up to tag jcd-merge-2

on oacs-4-6 are included.

  1. … 33 more files in changeset.
only collect comments if ds enabled

br singleton

fix html so it is valid xhtml 1.0

    • -18
    • +17
    ./acs-developer-support-procs.tcl
fix for internal redirects which were recording headers et al multiple

times. Also adds url to acs-developer-support/www/index table

display.

    • -10
    • +11
    ./acs-developer-support-procs.tcl
  1. … 1 more file in changeset.
Due (I think) to a bug in the request processor 404s end up putting a

list of values into the start time variable which caused this bit

to fail and not clear out the old data. Here was the debug

[-conn3-] Error: return: failed to redirect '404': exceeded recursion limit of 3

followed by

[-sched-] Debug: JCD: ds_sweep_data: name:4.start nsv:1026036712 1026036712 1026036712 1026036712

when the ds_sweep_data proc was run. Probably should catch the whole

statement to insure that the cleanup is more robust but it is all

treating the symptoms not the disease (RP).

get parameters for the mounted instance Fixes bug 1352 patch 297

Merged with OpenACS 4.5 beta1 branch.

  1. … 88 more files in changeset.

Applied Tilmann Singer's patch #153 which fixes some problems with

acs-developer-support ("becoming" a user didn't quite work).

Change ds_require_permission to return proper HTTP headers (SDM patch

#88)