• last updated 3 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
- use util::http::* instead of deprecated procs

- add code to convert timeout value to a value suitable for the

underlying implementation (NaviServer or curl)

- document timeout values

- base deprecated code on util::http::*

- moved util_link_responding_p and util_get_http_status to

http-client-procs and based it on util::http::*.

- marked util_link_responding_p and util_get_http_status as

deprecated, moved a new version into the util::* namespace

and turned positional arguments into non-positional

- follow documentation conventions

    • -237
    • +261
    /openacs-4/packages/acs-tcl/tcl/http-client-procs.tcl
- use proper version comparison to avoid surprises, when alnum comparison leads to different results

- use util::http::get instead of ns_httpget

- point to naviserver doc

- use util::http::get instead of ns_httpget

- add missing backslashes in util::http::native::request for redirects

- make "GET" default method

- change encoding to unix style (as in other procs)

    • -1511
    • +1515
    /openacs-4/packages/acs-tcl/tcl/http-client-procs.tcl
- provide quoting for page name in generated adp files

    • -79
    • +78
    /openacs-4/packages/xowiki/www/oacs-view.adp
    • -107
    • +102
    /openacs-4/packages/xowiki/www/oacs-view2.adp
    • -114
    • +109
    /openacs-4/packages/xowiki/www/oacs-view3.adp
    • -109
    • +109
    /openacs-4/packages/xowiki/www/view-book-no-ajax.adp
    • -109
    • +109
    /openacs-4/packages/xowiki/www/view-book.adp
    • -63
    • +63
    /openacs-4/packages/xowiki/www/view-default.adp
    • -16
    • +16
    /openacs-4/packages/xowiki/www/view-links.adp
- don't append $search_package_id to param when it is empty

    • -2
    • +2
    /openacs-4/packages/search/www/search.tcl
- remove apparently dead code

    • -70
    • +65
    /openacs-4/packages/search/www/search.adp
    • -19
    • +6
    /openacs-4/packages/search/www/search.tcl
- remove parens from build_query, since handling is broken (e.g. "unimplemented ( 5.5.1 )") and it's not clear what the intended sematics are

- improve checking of category ids

- moderinze tcl: use namespaced variables instead of "global" command

- provide nicer error messages when resolve_page raises an error

    • -4
    • +6
    /openacs-4/packages/xowiki/tcl/package-procs.tcl
- no reason to generate a warning, when a callback is not defined

    • -3
    • +3
    /openacs-4/packages/search/www/search.tcl
- handle empty query parameter

- fix dollar escaping as indicated by Tony Kirkham in the OpenACS Development forum

- add new utility-function for en/decoding the "path" part using the url-encding scheme as define in RFC 3986. The functions are defined as stubs for backward compatibility for aolserver, since aolserver uses always the same encoding

- use ad_urlencode_path in file-storage where necessary

- some cleanup

Recognize @param and @see

Include parameter documentation and "see references", if available.

Allow for setting ad_form's mode

The default behaviour did not change, but one can now set ad_form's mode

to "display", which is used by some applications.

- update in "reparent" the acs_objects entry of the child-rel (mostly context_id); many thanks to guenter ernst for the snippet.

    • -1
    • +9
    /openacs-4/packages/xowiki/tcl/package-procs.tcl
- fix logic for negative numbers

- fix type of argument

- don't produce hard errors, when folder_id is not a valid number. The validator of the page_contract is called before the type of the query variables are checked. The db-query in the validator raised the hard sql error rather the intended error message

- fix for bug #3225: make sure the result list of ad_parse_html_attributes_upvar is a well-formed list

Remove broken check for empty folder name.

A previous change in this line prevented one from instantiating applications

via this UI. However, the check for an empty value is obsolete anyhow...

- patch for a subtle difference between aolserver and Naviserver in the handling of "--" (nonpos parameter terminator)

- undo previous secure-cookie change since it interacts badly in situations where "RestrictLoginToSSLP" is "1" and https is available: In such cases, e.g. the login page is redirected from a http (insecure) url to an https (secure) page. But when later continuing on the http connection, the user appears to be not logged in, since a well-behaved browser does not send the "secure" login coockie over the insecure connection.

- white space changes: replace tabs by spaces

    • -233
    • +250
    /openacs-4/packages/acs-tcl/tcl/security-procs.tcl