OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 10
Total Committers: 146
Last Commit: 14 Nov
Commits this week: 10
Total Lines of Code (LoC): 7,560,821
Net change in LoC this week: 22

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 2 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 01 Mar 2021
11:43 am

gustafn

reduce the number of locks (nsv-accesses) for OACS_FULLQUERIES by a factor of 3 when NaviServer is used.

OACS_FULLQUERIES is one of the 3 most intensively locked nsv arrays for

busy implementation

Options
    • -20
    • +52
    /openacs-4/packages/acs-bootstrap-installer/tcl/40-db-query-dispatcher-procs.tcl
11:12 am

gustafn

improve test coverage

Options
    • -3
    • +41
    /openacs-4/packages/acs-bootstrap-installer/tcl/test/00-proc-procs.tcl
11:11 am

gustafn

reduce visibility of internal functions

Options
    • -4
    • +4
    /openacs-4/packages/acs-bootstrap-installer/tcl/40-db-query-dispatcher-procs.tcl
10:27 am

gustafn

fix entry in listing of covered procs

Options
    • -1
    • +1
    /openacs-4/packages/xotcl-core/tcl/test/xotcl-core-db-tutorial-procs.tcl
10:27 am

gustafn

reduce verbosity

Options
    • -2
    • +4
    /openacs-4/packages/xotcl-core/tcl/06-package-procs.tcl
10:26 am

gustafn

move function db_current_rdbms to acs-bootstrap installer to improve code locality

Options
    • -2
    • +6
    /openacs-4/packages/acs-bootstrap-installer/tcl/40-db-query-dispatcher-procs.tcl
    • -6
    • +1
    /openacs-4/packages/acs-tcl/tcl/01-database-procs.tcl
10:19 am

gustafn

Cleanup of low-level DB-interace: use dict instead of list with fixed positions

VS: ----------------------------------------------------------------------

Options
    • -2
    • +2
    /openacs-4/packages/acs-bootstrap-installer/acs-bootstrap-installer.info
    • -28
    • +48
    /openacs-4/packages/acs-bootstrap-installer/tcl/40-db-query-dispatcher-procs.tcl
    • -3
    • +3
    /openacs-4/packages/acs-tcl/acs-tcl.info
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/01-database-procs.tcl
Sunday 28 Feb 2021
10:56 pm

gustafn

reduce usage of ad_arg_parser by using c-level implementation; fixes as well broken cases of bind-var handling

Options
    • -46
    • +23
    /openacs-4/packages/acs-tcl/tcl/01-database-procs.tcl
10:53 pm

gustafn

added test cases for db_0or1row and db_1row

Options
    • -1
    • +103
    /openacs-4/packages/acs-tcl/tcl/test/db-proc-test-procs.tcl
10:27 pm

gustafn

whitespace changes

Options
    • -9
    • +9
    /openacs-4/packages/acs-tcl/tcl/test/db-proc-test-procs.tcl
10:27 pm

gustafn

add test cases for db_list*

Options
    • -1
    • +33
    /openacs-4/packages/acs-tcl/tcl/test/db-proc-test-procs.tcl
10:24 pm

gustafn

reduce verbosity

Options
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/test/doc-check-procs.tcl
5:56 pm

gustafn

whitespace changes

Options
    • -1
    • +2
    /openacs-4/packages/acs-automated-testing/tcl/coverage-procs.tcl
    • -4
    • +4
    /openacs-4/packages/acs-automated-testing/tcl/example-procs.tcl
    • -5
    • +5
    /openacs-4/packages/acs-automated-testing/www/index.tcl
    • -3
    • +5
    /openacs-4/packages/acs-automated-testing/www/server.tcl
    • -2
    • +2
    /openacs-4/packages/acs-automated-testing/www/admin/index.tcl
    • -1
    • +1
    /openacs-4/packages/acs-automated-testing/www/admin/proc-coverage.tcl
    • -87
    • +87
    /openacs-4/packages/acs-automated-testing/www/admin/record-test.tcl
    • -3
    • +3
    /openacs-4/packages/acs-automated-testing/tcl/test/acs-automated-testing-procs.tcl
5:52 pm

gustafn

remove debug code

Options
    • -3
    • +1
    /openacs-4/packages/acs-automated-testing/tcl/aa-test-procs.tcl
5:45 pm

gustafn

extended regression test: increase coverage of page contract filters

Options
    • -32
    • +43
    /openacs-4/packages/acs-tcl/tcl/test/acs-tcl-test-procs.tcl
5:44 pm

gustafn

fix util::external_url_p when security::locations returns empty element

Options
    • -1
    • +4
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
5:42 pm

gustafn

ease navigation: provide links to coverage pages

Options
    • -2
    • +17
    /openacs-4/packages/acs-automated-testing/www/admin/index.adp
    • -1
    • +2
    /openacs-4/packages/acs-automated-testing/www/admin/index.tcl
    • -8
    • +11
    /openacs-4/packages/acs-automated-testing/www/admin/proc-coverage.tcl
    • -0
    • +2
    /openacs-4/packages/acs-automated-testing/www/admin/testcase.adp
    • -1
    • +2
    /openacs-4/packages/acs-automated-testing/www/admin/testcase.tcl
5:41 pm

gustafn

added new test cases for testing page contract filters

Options
    • -0
    • +30
    /openacs-4/packages/acs-automated-testing/tcl/test/acs-automated-testing-procs.tcl
5:40 pm

gustafn

simplify and modernize Tcl code

Options
    • -13
    • +9
    /openacs-4/packages/acs-automated-testing/tcl/filter-procs.tcl
10:03 am

gustafn

improve navigation structure (context bar) and actions labeling

the reousrce actions is not necessary, since rerun performs an automatic resources

Options
    • -1
    • +3
    /openacs-4/packages/acs-automated-testing/tcl/aa-test-procs.tcl
    • -1
    • +2
    /openacs-4/packages/acs-automated-testing/www/admin/index.adp
    • -6
    • +9
    /openacs-4/packages/acs-automated-testing/www/admin/index.tcl
    • -18
    • +18
    /openacs-4/packages/acs-automated-testing/www/admin/testcase.adp
    • -9
    • +5
    /openacs-4/packages/acs-automated-testing/www/admin/testcase.tcl
Saturday 27 Feb 2021
11:29 pm

gustafn

adjust to api-browser changes for trailing non-positional arguments

Options
    • -3
    • +3
    /openacs-4/packages/xotcl-core/xotcl-core.info
    • -20
    • +24
    /openacs-4/packages/xotcl-core/tcl/03-doc-procs.tcl
11:25 pm

gustafn

Added support for trailing non-positional arguments

The change makes the old hack with the own trailing-argument-parser

"ad_arg_parser" obsolete by using directly the c-level argument parser

which is anyhow capable of handling trailing arguments. A few changes

were necessary for api doc to handle there trailing arguments as well.

The proc "db_string" is already converted to use native arguments.

Options
    • -4
    • +4
    /openacs-4/packages/acs-api-browser/acs-api-browser.info
    • -27
    • +39
    /openacs-4/packages/acs-api-browser/tcl/acs-api-documentation-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-bootstrap-installer/acs-bootstrap-installer.info
    • -7
    • +16
    /openacs-4/packages/acs-bootstrap-installer/tcl/00-proc-procs.tcl
    • -3
    • +3
    /openacs-4/packages/acs-tcl/acs-tcl.info
    • -6
    • +5
    /openacs-4/packages/acs-tcl/tcl/01-database-procs.tcl
    • -1
    • +1
    /openacs-4/packages/acs-tcl/tcl/form-processing-procs.tcl
    • -4
    • +8
    /openacs-4/packages/acs-tcl/tcl/test/doc-check-procs.tcl
11:12 pm

gustafn

added test case for db_string with various bind options

Options
    • -4
    • +33
    /openacs-4/packages/acs-tcl/tcl/test/db-proc-test-procs.tcl
9:26 pm

gustafn

whitespace changes

Options
    • -6
    • +6
    /openacs-4/packages/acs-tcl/tcl/test/db-proc-test-procs.tcl
9:25 pm

gustafn

move db-test case to db-regression test files

Options
    • -181
    • +13
    /openacs-4/packages/acs-tcl/tcl/test/acs-tcl-test-procs.tcl
    • -1
    • +184
    /openacs-4/packages/acs-tcl/tcl/test/db-proc-test-procs.tcl
9:23 pm

gustafn

remove unneeded method

Options
    • -10
    • +1
    /openacs-4/packages/xotcl-core/tcl/cr-procs.tcl
9:19 pm

gustafn

complete listing of covered procs in test cases

Options
    • -0
    • +2
    /openacs-4/packages/acs-lang/tcl/test/acs-lang-test-procs.tcl
    • -1
    • +3
    /openacs-4/packages/acs-service-contract/tcl/test/acs-service-contract-procs.tcl
    • -1
    • +3
    /openacs-4/packages/acs-subsite/tcl/test/acs-subsite-procs.tcl
    • -3
    • +12
    /openacs-4/packages/acs-tcl/tcl/test/acs-tcl-apm-procs.tcl
    • -0
    • +5
    /openacs-4/packages/acs-tcl/tcl/test/apm-parameter-test-procs.tcl
    • -1
    • +7
    /openacs-4/packages/acs-tcl/tcl/test/community-core-test-procs.tcl
    • -1
    • +3
    /openacs-4/packages/acs-tcl/tcl/test/file-test-procs.tcl
    • -0
    • +2
    /openacs-4/packages/acs-tcl/tcl/test/http-client-procs.tcl
    • -0
    • +2
    /openacs-4/packages/acs-tcl/tcl/test/navigation-procs.tcl
    • -1
    • +3
    /openacs-4/packages/acs-tcl/tcl/test/object-test-case-procs.tcl
    • -1
    • +3
    /openacs-4/packages/acs-tcl/tcl/test/test-permissions-procs.tcl
    • -0
    • +2
    /openacs-4/packages/general-comments/tcl/test/general-comments-procs.tcl
    • -0
    • +1
    /openacs-4/packages/xowiki/tcl/test/xowiki-admin-tests-procs.tcl
    • -0
    • +1
    /openacs-4/packages/xowiki/tcl/test/xowiki-link-test-procs.tcl
    • -0
    • +1
    /openacs-4/packages/xowf/tcl/test/xowf-test-procs.tcl
9:17 pm

gustafn

use fine-grade percentage to color mapping

Options
    • -1
    • +21
    /openacs-4/packages/acs-automated-testing/tcl/coverage-procs.tcl
    • -3
    • +6
    /openacs-4/packages/acs-automated-testing/www/admin/index.adp
    • -4
    • +9
    /openacs-4/packages/acs-automated-testing/www/admin/index.tcl
7:03 pm

gustafn

added a comment about the usefulness of ad_arg_parser

Options
    • -1
    • +10
    /openacs-4/packages/acs-bootstrap-installer/tcl/00-proc-procs.tcl
6:48 pm

gustafn

Fix for issue #3442 to support range types in .xql files

PostgreSQL supports range types since 9.5. When using range types,

square braces have to be used in SQL statements. Since OpenACS uses

always Tcl substitution in .xql files, and OpenACS does NOT allow

backslash substitution in these files, square brackets could not be

escaped and therefore not be used in .xql files so far. This change

allows now a developer to deactivate the substitution by passing

e.g. "-subst none" to the db_* command using the .xql file. Valid

values for "-subst" are "all", "none", "vars", and "commands", default

is "all" which is exactly the behavior of before. Therefore, this

change is fully backward compatible.

Options
    • -2
    • +2
    /openacs-4/packages/acs-bootstrap-installer/acs-bootstrap-installer.info
    • -3
    • +19
    /openacs-4/packages/acs-bootstrap-installer/tcl/40-db-query-dispatcher-procs.tcl
    • -1
    • +1
    /openacs-4/packages/acs-tcl/acs-tcl.info
    • -55
    • +65
    /openacs-4/packages/acs-tcl/tcl/01-database-procs.tcl