• last updated 15 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Fixed bug #493: Bugs don't inherit permissions correctly

adding Lars's OpenACS logged in as box in the dotlrn master template in response to bug 391. Tested in NS4, Mozilla 1.3, and IE 6.0 on Windows

    • -6
    • +9
    /openacs-4/packages/dotlrn/www/dotlrn-master.adp
fixing broken new link in forums portlet by using the new /shared/images dir for images

making the login box on the start page honor the DefaultPersistentLoginP parameter

removing obsolete snippet of code writing an empty file list to info files

    • -17
    • +1
    /openacs-4/packages/acs-tcl/tcl/apm-xml-procs.tcl
adding the acs-kernel parameter DefaultPersistentLoginP in response to bug 474

Use new -keyword_ids switch to bug::new

Changed bug_tracker::bug::insert so it can now receive and store keywords/categories. This was necessary for notifications to work properly, otherwise they'd get stored only after notifications had been sent out.

- Moved notifications outside of the transaction, so the transaction will be committed before notifications are sent out, and hence notifications will reflect the new status, not the old one.

- Suppress the space after the (Resolution code) thing, if there is none. Caused an extra space character in the notifications email

    • -21
    • +22
    /openacs-4/packages/workflow/tcl/case-procs.tcl
fixing incorrect PG query children_have_permission_p.child_perms. It would select everything under the folders parent instead of everything under the folder. The symptom was the empty folders could not be deleted. Bug reported by Carl Robert Blesius

removing the file listings from the info files since those are no longer used by OpenACS

    • -103
    • +0
    /openacs-4/packages/forums/forums.info
removing the file listings from the info files since those are no longer used by OpenACS

  1. … 14 more files in changeset.
removing the file listings from the info files since those are no longer used by OpenACS

    • -476
    • +0
    /openacs-4/packages/dotlrn/dotlrn.info
  1. … 6 more files in changeset.
removing annoying debug printout left in master template

    • -3
    • +1
    /openacs-4/packages/dotlrn/www/dotlrn-master.tcl
Added missing package_id field to general comments table.

Updated data model to subtype cr_revision. Started work on plpgsql functions to support object type.

adding missing query apm_package_install_callbacks.delete_all_callbacks

Fixed:

> missing link to http://openacs.org/doc/openacs-4-6-2/files/analog-dev.cfg.txt

> http://openacs.org/doc/openacs-4-6-2/individual-programs.html

Removed the link altogether - removed all links to files actually in

the tarball

----------------------------------------------------------------------

> I'm running Mandrake 9.1 on my new workstation here, and when all the docbook

> stuff's installed there's a convenient "xsl-stylesheets" symbolic link to

Using symlink in openacs.xsl

----------------------------------------------------------------------

In qmail section, link to download page for ucspi and qmail

----------------------------------------------------------------------

>Which is the best keyword for "your service name?" in the docs. It should be

>easily recognized as a placeholder, easy to search-replace, and should

>be generic enough that most users can leave it unchanged. Currently we use

>"service0", which meets the last two of the three requirements.

>Earlier docs used "birdnotes," which met the first two requirements.

Decided I didn't care

----------------------------------------------------------------------

>Red Hat 9 issue:

>code change to compile daemontools and qmail

>http://www.riverside.org/archive/html/djbdns/2003-01/msg00307.html

>http://article.gmane.org/gmane.mail.qmail.general/13960

>put "#include <errno.h>" in /usr/local/src/postgresql-7.2.3/src/include/postgres.h

Added comment to instructions

----------------------------------------------------------------------

> Add text about which version of PostgreSQL works to top of that

section.

added.

----------------------------------------------------------------------

>First, in http://openacs.org/doc/openacs-4-6-2/postgres.html the make

>install didn't work for me when I used postgres so I had to use root and

>then do 'chown -R postgres.web /usr/local/pgsql'

Could not repro.

----------------------------------------------------------------------

> Second, in the [postgres.html] doc, in point 8 for Red Hat, why is

> there chmod 700 for the script? All the other scripts in

> /etc/rc.d/init.d are 755.

Changed to 755.

----------------------------------------------------------------------

>Optimizing Postgres:

>should optimize kernel settings for Postgres

>http://developer.postgresql.org/docs/postgres/kernel-resources.html

Added postgres tuning instructions

----------------------------------------------------------------------

>For compiling nsopenssl, this was necessary on Debian:

>apt-get install libssl-dev

>make OPENSSL=/usr/lib/ssl

>nsopenssl needs 0.9.6 or newer. Debian stable currently runs openssl

>0.9.6c

Added note.

----------------------------------------------------------------------

>If you are on Oracle, you have to su - oracle, then su to root to get

>your environment right. Otherwise, nsoracle won't compile.

Added note.

----------------------------------------------------------------------

>The web user wasn't added in the Oracle install step, so I added it

>now: groupadd web

Already mentioned in the doc.

----------------------------------------------------------------------

>For some reason, the include and sample-config.tcl files were owned by

>500.500 instead of root root. So:

>chown -R root.root include sample.config.tcl

owned by remadmin in reference platform. Seems harmless so didn't add anything to instructions.

----------------------------------------------------------------------

>bin and lib were group owned by staff. I changed that to root as well:

>chown -R root.root bin lib modules

could not repro

----------------------------------------------------------------------

> We should be recommending at least ANALYZE (by itself). If we are

> going to recommend VACUUM, we should recommend VACUUM ANALYZE once an

> hour (or so) and a VACUUM FULL ANALYZE once a night.

Changed default suggestion to --analyze (once per day) to be conservative due to forum thread about full analyze affecting performance due to locking

----------------------------------------------------------------------

> Red hat 9: Stock SSL doesn't work - kerberos problem and also not compiled with

> thread support. (there's an OpenACS thread to fix this)

>http://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=84331

> edit nsopenssl Makefile to say

> CFLAGS += -I$(OPENSSL)/include <b>-I/usr/kerberos/include<b>

Added pointer to thread

Fixed:

> missing link to http://openacs.org/doc/openacs-4-6-2/files/analog-dev.cfg.txt

> http://openacs.org/doc/openacs-4-6-2/individual-programs.html

Removed the link altogether - removed all links to files actually in

the tarball

----------------------------------------------------------------------

> I'm running Mandrake 9.1 on my new workstation here, and when all the docbook

> stuff's installed there's a convenient "xsl-stylesheets" symbolic link to

Using symlink in openacs.xsl

----------------------------------------------------------------------

In qmail section, link to download page for ucspi and qmail

----------------------------------------------------------------------

>Which is the best keyword for "your service name?" in the docs. It should be

>easily recognized as a placeholder, easy to search-replace, and should

>be generic enough that most users can leave it unchanged. Currently we use

>"service0", which meets the last two of the three requirements.

>Earlier docs used "birdnotes," which met the first two requirements.

Decided I didn't care

----------------------------------------------------------------------

>Red Hat 9 issue:

>code change to compile daemontools and qmail

>http://www.riverside.org/archive/html/djbdns/2003-01/msg00307.html

>http://article.gmane.org/gmane.mail.qmail.general/13960

>put "#include <errno.h>" in /usr/local/src/postgresql-7.2.3/src/include/postgres.h

Added comment to instructions

----------------------------------------------------------------------

> Add text about which version of PostgreSQL works to top of that

section.

added.

----------------------------------------------------------------------

>First, in http://openacs.org/doc/openacs-4-6-2/postgres.html the make

>install didn't work for me when I used postgres so I had to use root and

>then do 'chown -R postgres.web /usr/local/pgsql'

Could not repro.

----------------------------------------------------------------------

> Second, in the [postgres.html] doc, in point 8 for Red Hat, why is

> there chmod 700 for the script? All the other scripts in

> /etc/rc.d/init.d are 755.

Changed to 755.

----------------------------------------------------------------------

>Optimizing Postgres:

>should optimize kernel settings for Postgres

>http://developer.postgresql.org/docs/postgres/kernel-resources.html

Added postgres tuning instructions

----------------------------------------------------------------------

>For compiling nsopenssl, this was necessary on Debian:

>apt-get install libssl-dev

>make OPENSSL=/usr/lib/ssl

>nsopenssl needs 0.9.6 or newer. Debian stable currently runs openssl

>0.9.6c

Added note.

----------------------------------------------------------------------

>If you are on Oracle, you have to su - oracle, then su to root to get

>your environment right. Otherwise, nsoracle won't compile.

Added note.

----------------------------------------------------------------------

>The web user wasn't added in the Oracle install step, so I added it

>now: groupadd web

Already mentioned in the doc.

----------------------------------------------------------------------

>For some reason, the include and sample-config.tcl files were owned by

>500.500 instead of root root. So:

>chown -R root.root include sample.config.tcl

owned by remadmin in reference platform. Seems harmless so didn't add anything to instructions.

----------------------------------------------------------------------

>bin and lib were group owned by staff. I changed that to root as well:

>chown -R root.root bin lib modules

could not repro

----------------------------------------------------------------------

> We should be recommending at least ANALYZE (by itself). If we are

> going to recommend VACUUM, we should recommend VACUUM ANALYZE once an

> hour (or so) and a VACUUM FULL ANALYZE once a night.

Changed default suggestion to --analyze (once per day) to be conservative due to forum thread about full analyze affecting performance due to locking

----------------------------------------------------------------------

> Red hat 9: Stock SSL doesn't work - kerberos problem and also not compiled with

> thread support. (there's an OpenACS thread to fix this)

>http://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=84331

> edit nsopenssl Makefile to say

> CFLAGS += -I$(OPENSSL)/include <b>-I/usr/kerberos/include<b>

Added pointer to thread

  1. … 40 more files in changeset.
Forgot to add my upgrade script during my last commit ...

file upgrade-4.6.2-4.6.3.sql was initially added on branch oacs-4-6.

1. removed some needless LARS notices

2. removed acs_methods and friends from the permissions documentation

and got rid of the commented-out table stubs.

3. dropping of permissions was broken in PG, fixed that.

4. cc_users and registered_users views have been sped up.

5. removed an unused and incorrect proc from revision-procs

6. updated acs-kernel to 4.6.3

-------------------------------------------------------------------------------------

Moved edit-this-page's acs-subsite parameters to acs-subsite, and removed them from here. Bumped up the version number and require acs-subsite 4.6.3. See bug #479

Added edit-this-page's parameters to acs-subsite -- I know it's ugle. See bug #479

Planes for fixing up general comments

    • -0
    • +20
    /openacs-4/contrib/packages/general-comments/TODO
Fixed problems with the label for the checkboxes.

Adding development version of general-comments. This is a rewrite of the data

model to remove dependance on acs-messaging.

  1. … 92 more files in changeset.
fixing item 3 of bug 471 by granting admin privilege to creator of a URL just like we do for files

Fixing bug 471. Changing site_node::instantiate_and_mount so that context_id defaults to the closest not-null ancestor package in the site map (the one at the parent node might be null)

Oops, bumped up the ecommerce requirement one too far