• last updated 10 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
resolved bug with revisions

Don't launch a new window when opening a folder; find the correct package_id even if included from elsewhere, e.g. a dotlrn portlet.

Removed trailing semicolons which are problematic for Oracle (unless we're in a plsql block, which we're not).

Oops, DownloadTargetWindowName is a string not a number.

Added parametrized ability to launch downloads in a separate window.

Added a new parameter, DownloadTargetWindowName

Adding a CSS class for file type icons. Currently it's only used by dotlrn but it's helpful, harmless and may come in handy for others at some point.

Rolling in daveb's mime type patches from oacs-5-2

Taking up version numbers -- preparing for release

This script was failing on Oracle. To fix I added named args to all calls and changed acs_sc_impl.new_alias to acs_sc_impl_alias.new

    • -17
    • +17
    ./sql/oracle/upgrade/upgrade-5.1.0a4-5.1.0a5.sql
Adding message keys for es_GT and es_ES locale

    • -1
    • +1
    ./catalog/file-storage.en_US.ISO-8859-1.xml
    • -2
    • +34
    ./catalog/file-storage.es_ES.ISO-8859-1.xml
    • -1
    • +1
    ./catalog/file-storage.es_GT.ISO-8859-1.xml
fix literal backslash n in message keys; bug 2345, 2362 work needs to be done on translation as well

    • -7
    • +7
    ./catalog/file-storage.en_AU.ISO-8859-1.xml
    • -7
    • +7
    ./catalog/file-storage.en_US.ISO-8859-1.xml
    • -7
    • +7
    ./catalog/file-storage.es_CO.ISO-8859-1.xml
    • -7
    • +7
    ./catalog/file-storage.es_GT.ISO-8859-1.xml
reverted previous change, resolved bug #2362. Fixed message keys containing \n manually on our system, Jeff is pinging Joel to do this programatically on the translation server. Removed ns_log Notice that were leftovers from testing the download functionality

Fixing line breaks returned from ad_html_text_convert. Added folder information to the notifications for parent folders as well (not very useful if you have no clue where the file was uploaded to otherwise)

Fixed download that was broken due to name => title change. Broken means relative linking within the directory did not work, if the name of the file had to be renamed due to name conflicts. Using the title instead of the file name is also more in line with the 'Once face to the customer' credo.

The parent_id = was too restrictive. Even if there are multiple folders with the same name, the combination will weed the other ones out.

Changed 200 to 404 as it is a file not found

Previous commit was fixing the wrong cause. Now I use two folders to make sure I'm trying to fetch the correct item. This should be done (in the long run) using a connect by / tree view.

Detected cases where we might have more than one item_id in the subselect. Fixed. Furthermore fixed Oracle Limit 1 problem by using rownum=1

Fixed problem with limit 1 in Oracle

added behavelikefilesystemp parameter. Added code to handle files accordingly.

added behavelikefilesystemp parameter

*** empty log message ***

    • -0
    • +176
    ./catalog/file-storage.en_AU.ISO-8859-1.xml
    • -0
    • +171
    ./catalog/file-storage.es_CO.ISO-8859-1.xml
    • -0
    • +19
    ./catalog/file-storage.es_GT.ISO-8859-1.xml
  1. … 88 more files in changeset.
Changed the upgrade script to use select count(*) to circumwent Oracles dislike for if (select...)

Upgrade scripts was buggy, took the create version

    • -2
    • +12
    ./sql/oracle/upgrade/upgrade-5.1.0a4-5.1.0a5.sql
Change the ifstatement to the select query as in postgres

Fixed my previous select as it was missing the parent_id clause

PLEASE REVERT IF YOU THINK THIS IS NOT RIGHT, but it is the only way this f***ed upgrade script works reliably on the sites I needed to upgrade (and that had the same title twice. I changed the if statement from the complex parent_id, title check to a simple select on the cr_item table, checking if the name is already there. Obviously this is very inefficient (for each file you run yet another select) but it works reliably (with the old version I got errors on two sites)

Bugfix: converted extra 'where' to an 'and'.

    • -2
    • +2
    ./sql/oracle/upgrade/upgrade-5.1.0a13-5.1.0a14.sql
Make sure temp files are deleted after upload