OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 34
Total Committers: 146
Last Commit: 28 Dec
Commits this week: 34
Total Lines of Code (LoC): 7,561,384
Net change in LoC this week: 37

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 9 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 08 Nov 2022
7:04 pm

gustafn

Deescalation: the usage of the pairs in export_vars is not so dangerous as it looked at first sight.

The problem case was originating from the call

lappend __vars [lindex $_var 0] [uplevel subst [lindex $_var 1]]

which calls Tcl's "uplevel" with two arguments. In this case, the arguments

are concatenated and the evaluated in the caller's frame. There is a substitution

before the evaluation. When just one argument is passed in, this problem there

is only one evaluation:

lappend __vars [lindex $_var 0] [uplevel [list subst [lindex $_var 1]]]

Options
    • -5
    • +5
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
    • -6
    • +8
    /openacs-4/packages/xotcl-core/tcl/06-package-procs.tcl
3:20 pm

gustafn

avoid subst in export_vars when not necessary

Options
    • -3
    • +3
    /openacs-4/packages/bug-tracker/lib/nav-bar.tcl
3:19 pm

gustafn

avoid subst in export_vars when not necessary

Options
    • -2
    • +3
    /openacs-4/packages/forums/www/forum-view.tcl
    • -2
    • +3
    /openacs-4/packages/acs-api-browser/www/proc-view.tcl
3:02 pm

gustafn

avoided subst in export_vars when not necessary

Options
    • -1
    • +2
    /openacs-4/packages/acs-admin/lib/service-parameters.tcl
    • -2
    • +6
    /openacs-4/packages/acs-subsite/lib/applications.tcl
2:59 pm

gustafn

added warning to export_vars

Options
    • -1
    • +8
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
2:24 pm

gustafn

Added support for passing parameter_name:value_constraint to xowiki::Package->get_parameter

- The get_parameter method can get values from query-parameters, therefore

we have to validate these.

- Use the new feature at several places (especially for boolean values)

- Still, more places should be checked

- bumped xowiki to 5.10.1d37

- bumped xotcl-core to 5.10.1d14

Options
    • -2
    • +2
    /openacs-4/packages/xotcl-core/xotcl-core.info
    • -26
    • +4
    /openacs-4/packages/xotcl-core/tcl/06-package-procs.tcl
    • -29
    • +52
    /openacs-4/packages/xotcl-core/tcl/context-procs.tcl
    • -3
    • +3
    /openacs-4/packages/xowiki/xowiki.info
    • -1
    • +1
    /openacs-4/packages/xowiki/tcl/folder-procs.tcl
    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/form-field-procs.tcl
    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/menu-procs.tcl
    • -12
    • +29
    /openacs-4/packages/xowiki/tcl/package-procs.tcl
    • -13
    • +13
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
    • -6
    • +6
    /openacs-4/packages/xowiki/tcl/xowiki-utility-procs.tcl
    • -10
    • +10
    /openacs-4/packages/xowiki/tcl/xowiki-www-procs.tcl
1:47 pm

trenner

add missing brackets

Options
    • -2
    • +2
    /openacs-4/packages/xotcl-core/tcl/06-package-procs.tcl
1:45 pm

gustafn

added optional parameter "-timeout" to "CACHE eval ..." method

Options
    • -8
    • +12
    /openacs-4/packages/acs-tcl/tcl/acs-cache-procs.tcl
10:55 am

trenner

make ad_sanitize_filename more robust to filenames with parentheses + extend automated tests

Options
    • -4
    • +7
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
    • -0
    • +4
    /openacs-4/packages/acs-tcl/tcl/test/utilities-procs.tcl
Monday 07 Nov 2022
2:38 pm

trenner

ensure year has only 4 digits

Options
    • -2
    • +2
    /openacs-4/packages/acs-templating/acs-templating.info
    • -0
    • +1
    /openacs-4/packages/acs-templating/catalog/acs-templating.de_DE.ISO-8859-1.xml
    • -0
    • +1
    /openacs-4/packages/acs-templating/catalog/acs-templating.en_US.ISO-8859-1.xml
    • -3
    • +3
    /openacs-4/packages/acs-templating/tcl/date-procs.tcl
2:34 pm

gustafn

new API call util::potentially_unsafe_eval_p

Check content of the string to identify potentially unsafe content

in the provided string. The content is unsafe, when it contains

externally provided content, which might be provided e.g. via

query variables, or via user values stored in the database. When

such content contains square braces, a "subst" command on

theses can evaluate arbitrary commands, which is dangerous.

The new API call is used in "::xo::Package->return_page", where the

"subst" command stripped from its command substitution capabilities.

In case, command subsitution is needed, perform this prior this call.

bumped acs-tcl to 5.10.1d23

bumped xotcl-core to 5.10.1d13

Options
    • -2
    • +2
    /openacs-4/packages/acs-tcl/acs-tcl.info
    • -1
    • +40
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
    • -3
    • +3
    /openacs-4/packages/xotcl-core/xotcl-core.info
    • -2
    • +5
    /openacs-4/packages/xotcl-core/tcl/06-package-procs.tcl
Friday 04 Nov 2022
9:21 pm

gustafn

check queuing situation for every connection pool

Options
    • -13
    • +28
    /openacs-4/packages/xotcl-request-monitor/tcl/throttle_mod-procs.tcl
Thursday 03 Nov 2022
6:33 pm

gustafn

Allow to deactivate client-side double click prevention by setting DefaultPreventDoubleClickTimeoutMs to 0

Options
    • -4
    • +4
    /openacs-4/packages/acs-templating/acs-templating.info
    • -0
    • +3
    /openacs-4/packages/acs-templating/tcl/head-procs.tcl
2:50 pm

hectorr

Add vtt mime type to CR

Options
    • -2
    • +2
    /openacs-4/packages/acs-content-repository/acs-content-repository.info
    • -1
    • +2
    /openacs-4/packages/acs-content-repository/sql/common/mime-type-data.sql
    • -0
    • +45
    /openacs-4/packages/acs-content-repository/sql/oracle/upgrade/upgrade-5.10.1d4-5.10.1d5.sql
    • -0
    • +38
    /openacs-4/packages/acs-content-repository/sql/postgresql/upgrade/upgrade-5.10.1d4-5.10.1d5.sql
2:50 pm

hectorr

file upgrade-5.10.1d4-5.10.1d5.sql was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/acs-content-repository/sql/oracle/upgrade/upgrade-5.10.1d4-5.10.1d5.sql
    • -0
    • +0
    /openacs-4/packages/acs-content-repository/sql/postgresql/upgrade/upgrade-5.10.1d4-5.10.1d5.sql
10:08 am

gustafn

generalize handling of premature ends of request processing at client side

Options
    • -12
    • +17
    /openacs-4/packages/boomerang/tcl/boomerang-procs.tcl
Wednesday 02 Nov 2022
6:04 pm

gustafn

added package parameter DefaultPreventDoubleClickTimeoutMs for default timeout of double click handler

Options
    • -2
    • +4
    /openacs-4/packages/acs-templating/acs-templating.info
    • -3
    • +7
    /openacs-4/packages/acs-templating/tcl/head-procs.tcl
5:08 pm

gustafn

added double-click prevention class to submit widget

Options
    • -3
    • +3
    /openacs-4/packages/acs-templating/tcl/widget-procs.tcl
2:20 pm

gustafn

allow passing of template variables as icon name (which are resolved later)

Options
    • -2
    • +3
    /openacs-4/packages/acs-templating/tcl/style-procs.tcl
10:51 am

gustafn

more beautification of admin pages, make interface more consistent

Options
    • -1
    • +1
    /openacs-4/packages/acs-lang/www/admin/edit-history.adp
    • -1
    • +1
    /openacs-4/packages/acs-lang/www/admin/edit-history.tcl
    • -1
    • +2
    /openacs-4/packages/acs-lang/www/admin/index.tcl
    • -18
    • +19
    /openacs-4/packages/acs-subsite/www/admin/applications/index.tcl
9:38 am

trenner

There is no year zero in the Gregorian calendar

Options
    • -2
    • +2
    /openacs-4/packages/acs-templating/tcl/date-procs.tcl
Tuesday 01 Nov 2022
5:17 pm

gustafn

prefer dict over anonymous array

Options
    • -2
    • +6
    /openacs-4/packages/xooauth/tcl/oauth-procs.tcl
    • -2
    • +2
    /openacs-4/packages/xooauth/tcl/oauth-server-procs.tcl
5:15 pm

gustafn

prefer usage of parameter::get_from_package_key over plain parameter::get

Options
    • -4
    • +5
    /openacs-4/packages/notifications/tcl/reply-sweep-init.tcl
    • -4
    • +5
    /openacs-4/packages/notifications/tcl/sweep-init.tcl
5:13 pm

gustafn

bumped version numbers to reflect dependency on sitemap icon

Options
    • -3
    • +3
    /openacs-4/packages/acs-subsite/acs-subsite.info
    • -0
    • +1
    /openacs-4/packages/acs-subsite/www/resources/sitemap.svg
    • -2
    • +2
    /openacs-4/packages/acs-templating/acs-templating.info
5:13 pm

gustafn

file sitemap.svg was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/acs-subsite/www/resources/sitemap.svg
5:10 pm

gustafn

added sitemap icon

Options
    • -1
    • +5
    /openacs-4/packages/acs-templating/tcl/style-procs.tcl
5:09 pm

gustafn

modernized appearance of sitemap

bumped version number to 5.10.1d10

Options
    • -3
    • +3
    /openacs-4/packages/acs-subsite/acs-subsite.info
    • -15
    • +23
    /openacs-4/packages/acs-subsite/www/admin/site-map/index.tcl
5:06 pm

gustafn

modernized appearance of acs-admin

bumped version to 5.10.1d4

Options
    • -3
    • +3
    /openacs-4/packages/acs-admin/acs-admin.info
    • -3
    • +3
    /openacs-4/packages/acs-admin/lib/service-parameters.tcl
    • -4
    • +4
    /openacs-4/packages/acs-admin/www/index.tcl
    • -19
    • +10
    /openacs-4/packages/acs-admin/www/subsites.tcl
    • -2
    • +3
    /openacs-4/packages/acs-admin/www/apm/index.tcl
    • -15
    • +28
    /openacs-4/packages/acs-admin/www/apm/package-instances.tcl
    • -3
    • +4
    /openacs-4/packages/acs-admin/www/apm/version-view.adp
    • -1
    • +9
    /openacs-4/packages/acs-admin/www/apm/version-view.tcl
Monday 31 Oct 2022
8:14 am

gustafn

Remember pool settings for the number-of-lines filter

Options
    • -12
    • +13
    /openacs-4/packages/xotcl-request-monitor/www/long-calls.adp
    • -1
    • +6
    /openacs-4/packages/xotcl-request-monitor/www/long-calls.tcl
Sunday 30 Oct 2022
1:13 pm

gustafn

Added pool filtering and improved layout for Bootstrap 5

- added filter option for pools on "long-calls" page

- added support for Bootstrap 5

- added adp:icon for parameter

- Bumped version to 0.65

Options
    • -3
    • +3
    /openacs-4/packages/xotcl-request-monitor/xotcl-request-monitor.info
    • -4
    • +5
    /openacs-4/packages/xotcl-request-monitor/tcl/throttle_mod-procs.tcl
    • -2
    • +2
    /openacs-4/packages/xotcl-request-monitor/www/active-communities.tcl
    • -1
    • +2
    /openacs-4/packages/xotcl-request-monitor/www/index.adp
    • -0
    • +14
    /openacs-4/packages/xotcl-request-monitor/www/long-calls.adp
    • -11
    • +57
    /openacs-4/packages/xotcl-request-monitor/www/long-calls.tcl
    • -3
    • +4
    /openacs-4/packages/xotcl-request-monitor/www/whos-online.tcl