OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 6
Total Committers: 146
Last Commit: 21 Nov
Commits this week: 6
Total Lines of Code (LoC): 7,560,943
Net change in LoC this week: 122

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 19 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 07 Nov 2022
2:34 pm

gustafn

new API call util::potentially_unsafe_eval_p

Check content of the string to identify potentially unsafe content

in the provided string. The content is unsafe, when it contains

externally provided content, which might be provided e.g. via

query variables, or via user values stored in the database. When

such content contains square braces, a "subst" command on

theses can evaluate arbitrary commands, which is dangerous.

The new API call is used in "::xo::Package->return_page", where the

"subst" command stripped from its command substitution capabilities.

In case, command subsitution is needed, perform this prior this call.

bumped acs-tcl to 5.10.1d23

bumped xotcl-core to 5.10.1d13

Options
    • -2
    • +2
    /openacs-4/packages/acs-tcl/acs-tcl.info
    • -1
    • +40
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
    • -3
    • +3
    /openacs-4/packages/xotcl-core/xotcl-core.info
    • -2
    • +5
    /openacs-4/packages/xotcl-core/tcl/06-package-procs.tcl
Friday 04 Nov 2022
9:21 pm

gustafn

check queuing situation for every connection pool

Options
    • -13
    • +28
    /openacs-4/packages/xotcl-request-monitor/tcl/throttle_mod-procs.tcl
Thursday 03 Nov 2022
6:33 pm

gustafn

Allow to deactivate client-side double click prevention by setting DefaultPreventDoubleClickTimeoutMs to 0

Options
    • -4
    • +4
    /openacs-4/packages/acs-templating/acs-templating.info
    • -0
    • +3
    /openacs-4/packages/acs-templating/tcl/head-procs.tcl
2:50 pm

hectorr

Add vtt mime type to CR

Options
    • -2
    • +2
    /openacs-4/packages/acs-content-repository/acs-content-repository.info
    • -1
    • +2
    /openacs-4/packages/acs-content-repository/sql/common/mime-type-data.sql
    • -0
    • +45
    /openacs-4/packages/acs-content-repository/sql/oracle/upgrade/upgrade-5.10.1d4-5.10.1d5.sql
    • -0
    • +38
    /openacs-4/packages/acs-content-repository/sql/postgresql/upgrade/upgrade-5.10.1d4-5.10.1d5.sql
2:50 pm

hectorr

file upgrade-5.10.1d4-5.10.1d5.sql was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/acs-content-repository/sql/oracle/upgrade/upgrade-5.10.1d4-5.10.1d5.sql
    • -0
    • +0
    /openacs-4/packages/acs-content-repository/sql/postgresql/upgrade/upgrade-5.10.1d4-5.10.1d5.sql
10:08 am

gustafn

generalize handling of premature ends of request processing at client side

Options
    • -12
    • +17
    /openacs-4/packages/boomerang/tcl/boomerang-procs.tcl
Wednesday 02 Nov 2022
6:04 pm

gustafn

added package parameter DefaultPreventDoubleClickTimeoutMs for default timeout of double click handler

Options
    • -2
    • +4
    /openacs-4/packages/acs-templating/acs-templating.info
    • -3
    • +7
    /openacs-4/packages/acs-templating/tcl/head-procs.tcl
5:08 pm

gustafn

added double-click prevention class to submit widget

Options
    • -3
    • +3
    /openacs-4/packages/acs-templating/tcl/widget-procs.tcl
2:20 pm

gustafn

allow passing of template variables as icon name (which are resolved later)

Options
    • -2
    • +3
    /openacs-4/packages/acs-templating/tcl/style-procs.tcl
10:51 am

gustafn

more beautification of admin pages, make interface more consistent

Options
    • -1
    • +1
    /openacs-4/packages/acs-lang/www/admin/edit-history.adp
    • -1
    • +1
    /openacs-4/packages/acs-lang/www/admin/edit-history.tcl
    • -1
    • +2
    /openacs-4/packages/acs-lang/www/admin/index.tcl
    • -18
    • +19
    /openacs-4/packages/acs-subsite/www/admin/applications/index.tcl
9:38 am

trenner

There is no year zero in the Gregorian calendar

Options
    • -2
    • +2
    /openacs-4/packages/acs-templating/tcl/date-procs.tcl
Tuesday 01 Nov 2022
5:17 pm

gustafn

prefer dict over anonymous array

Options
    • -2
    • +6
    /openacs-4/packages/xooauth/tcl/oauth-procs.tcl
    • -2
    • +2
    /openacs-4/packages/xooauth/tcl/oauth-server-procs.tcl
5:15 pm

gustafn

prefer usage of parameter::get_from_package_key over plain parameter::get

Options
    • -4
    • +5
    /openacs-4/packages/notifications/tcl/reply-sweep-init.tcl
    • -4
    • +5
    /openacs-4/packages/notifications/tcl/sweep-init.tcl
5:13 pm

gustafn

bumped version numbers to reflect dependency on sitemap icon

Options
    • -3
    • +3
    /openacs-4/packages/acs-subsite/acs-subsite.info
    • -0
    • +1
    /openacs-4/packages/acs-subsite/www/resources/sitemap.svg
    • -2
    • +2
    /openacs-4/packages/acs-templating/acs-templating.info
5:13 pm

gustafn

file sitemap.svg was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/acs-subsite/www/resources/sitemap.svg
5:10 pm

gustafn

added sitemap icon

Options
    • -1
    • +5
    /openacs-4/packages/acs-templating/tcl/style-procs.tcl
5:09 pm

gustafn

modernized appearance of sitemap

bumped version number to 5.10.1d10

Options
    • -3
    • +3
    /openacs-4/packages/acs-subsite/acs-subsite.info
    • -15
    • +23
    /openacs-4/packages/acs-subsite/www/admin/site-map/index.tcl
5:06 pm

gustafn

modernized appearance of acs-admin

bumped version to 5.10.1d4

Options
    • -3
    • +3
    /openacs-4/packages/acs-admin/acs-admin.info
    • -3
    • +3
    /openacs-4/packages/acs-admin/lib/service-parameters.tcl
    • -4
    • +4
    /openacs-4/packages/acs-admin/www/index.tcl
    • -19
    • +10
    /openacs-4/packages/acs-admin/www/subsites.tcl
    • -2
    • +3
    /openacs-4/packages/acs-admin/www/apm/index.tcl
    • -15
    • +28
    /openacs-4/packages/acs-admin/www/apm/package-instances.tcl
    • -3
    • +4
    /openacs-4/packages/acs-admin/www/apm/version-view.adp
    • -1
    • +9
    /openacs-4/packages/acs-admin/www/apm/version-view.tcl
Monday 31 Oct 2022
8:14 am

gustafn

Remember pool settings for the number-of-lines filter

Options
    • -12
    • +13
    /openacs-4/packages/xotcl-request-monitor/www/long-calls.adp
    • -1
    • +6
    /openacs-4/packages/xotcl-request-monitor/www/long-calls.tcl
Sunday 30 Oct 2022
1:13 pm

gustafn

Added pool filtering and improved layout for Bootstrap 5

- added filter option for pools on "long-calls" page

- added support for Bootstrap 5

- added adp:icon for parameter

- Bumped version to 0.65

Options
    • -3
    • +3
    /openacs-4/packages/xotcl-request-monitor/xotcl-request-monitor.info
    • -4
    • +5
    /openacs-4/packages/xotcl-request-monitor/tcl/throttle_mod-procs.tcl
    • -2
    • +2
    /openacs-4/packages/xotcl-request-monitor/www/active-communities.tcl
    • -1
    • +2
    /openacs-4/packages/xotcl-request-monitor/www/index.adp
    • -0
    • +14
    /openacs-4/packages/xotcl-request-monitor/www/long-calls.adp
    • -11
    • +57
    /openacs-4/packages/xotcl-request-monitor/www/long-calls.tcl
    • -3
    • +4
    /openacs-4/packages/xotcl-request-monitor/www/whos-online.tcl
11:00 am

gustafn

xo::Table::Action: added property "CSSclass"

This property exists already for all other ::xo::Table::* widgets.

Bumped version number to 5.10.1d12

Options
    • -2
    • +2
    /openacs-4/packages/xotcl-core/xotcl-core.info
    • -3
    • +3
    /openacs-4/packages/xotcl-core/tcl/30-widget-procs.tcl
Friday 28 Oct 2022
8:18 pm

gustafn

minor UI improvement

Options
    • -3
    • +4
    /openacs-4/packages/acs-lang/www/admin/import-messages.adp
8:16 pm

gustafn

prefer adp:icon over old-style .gif files

Options
    • -2
    • +2
    /openacs-4/packages/file-storage/lib/folder-links.tcl
8:14 pm

gustafn

removed obsolete argument

Options
    • -2
    • +2
    /openacs-4/packages/xowiki/www/admin/index.tcl
8:14 pm

gustafn

added "invisible" to the code documentation line

Options
    • -1
    • +1
    /openacs-4/packages/bootstrap-icons/www/sitewide-admin/sample.adp
    • -1
    • +1
    /openacs-4/packages/fa-icons/www/sitewide-admin/sample.adp
2:52 pm

gustafn

Handling of cases where exercises with 0 minutes (or empty minutes fields) are used,

or when the full exam has no minutes specifed

- Provide a hint on lecturers dashboard for questions with 0 minutes

- Don't provide timer on the lecturers dashboard

- Don't provide timer for the students

- Don't show timer for very short exams/quizzes (below 1 minute)

- Provide a hint on lecturers dashboard when no timer is displayed

- When the countdown timer has expired more than a minute, display the text

that the timer has expired, rather than counting to negative values.

Hints:

* It is recommended to set the end-time of the exam manually,

when a time window is specified and the total exam time is provided as 0.

* When there is no timer, the special autosaving semantics for the end of the exam

will not work (trying to get a snapshort short before the exam end).

* When there is no time-budget, the time budget control ("be able" exams) won't work

- bumping version to 5.10.1d47

Options
    • -2
    • +2
    /openacs-4/packages/xowf/xowf.info
    • -0
    • +3
    /openacs-4/packages/xowf/catalog/xowf.de_DE.ISO-8859-1.xml
    • -4
    • +7
    /openacs-4/packages/xowf/catalog/xowf.en_US.ISO-8859-1.xml
    • -15
    • +18
    /openacs-4/packages/xowf/lib/inclass-exam-answer.wf
    • -4
    • +7
    /openacs-4/packages/xowf/lib/inclass-exam.wf
    • -6
    • +49
    /openacs-4/packages/xowf/tcl/test-item-procs.tcl
2:32 pm

gustafn

shorten the description test and remove fa specifics

Options
    • -33
    • +13
    /openacs-4/packages/acs-templating/www/sitewide-admin/index.adp
2:23 pm

gustafn

extended adp:icon

- added the feature "invisible" to <adp:icon....>

- added generic names "admin", "cog", "folder-add", "permissions", "search", and "unmount"

- added an overview page of adp-icons to the sitewide admin page

- bumped version to 5.10.1d22

Options
    • -2
    • +2
    /openacs-4/packages/acs-templating/acs-templating.info
    • -3
    • +34
    /openacs-4/packages/acs-templating/tcl/style-procs.tcl
    • -2
    • +4
    /openacs-4/packages/acs-templating/tcl/tag-init.tcl
    • -0
    • +53
    /openacs-4/packages/acs-templating/www/sitewide-admin/index.adp
    • -0
    • +42
    /openacs-4/packages/acs-templating/www/sitewide-admin/index.tcl
Thursday 27 Oct 2022
12:58 pm

gustafn

reduce verbosity

Options
    • -2
    • +1
    /openacs-4/packages/acs-api-browser/tcl/acs-api-documentation-procs.tcl
    • -2
    • +1
    /openacs-4/packages/acs-api-browser/www/plsql-subprogram-one.tcl
    • -2
    • +1
    /openacs-4/packages/acs-api-browser/www/plsql-subprograms-all.tcl
    • -2
    • +2
    /openacs-4/packages/acs-api-browser/www/proc-view.tcl
    • -2
    • +2
    /openacs-4/packages/acs-api-browser/www/tcl-doc-search.tcl
12:57 pm

gustafn

Deactivate api-doc access for all registered users by default

Over many years, all "Registered Users" got per default access

to /api-doc. This is probably OK, when one assumes that the

registered users are developers. However, providing source code

access to all registered users can pose a security thread,

especially on large sites.

For new installs, api-doc is now just accessible for site-wide admins.

Providing more liberal rights for users can be achieved via

setting the permissions via the sitemap.

Options
    • -8
    • +21
    /openacs-4/packages/acs-tcl/tcl/apm-install-procs.tcl