OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 22
Total Committers: 146
Last Commit: 11:40
Commits this week: 22
Total Lines of Code (LoC): 7,560,945
Net change in LoC this week: 124

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 9 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 25 Jan 2022
11:15 pm

gustafn

prefer "string first" over "string match" (the first one is slightly faster)

Options
    • -8
    • +7
    /openacs-4/packages/xowiki/tcl/xowiki-www-procs.tcl
6:33 pm

antoniop

Streamline idiom

Options
    • -8
    • +4
    /openacs-4/packages/acs-tcl/tcl/community-core-procs.tcl
6:31 pm

antoniop

Whitespace cleanup

Options
    • -20
    • +20
    /openacs-4/packages/acs-tcl/tcl/community-core-procs.xql
5:47 pm

antoniop

Do the transaction only if necessary

Options
    • -4
    • +6
    /openacs-4/packages/forums/lib/message/post.tcl
5:44 pm

antoniop

Break overlong lines

Options
    • -2
    • +16
    /openacs-4/packages/forums/lib/message/post.tcl
3:45 pm

antoniop

Add multiselect to the widgets we check

Options
    • -2
    • +3
    /openacs-4/packages/acs-templating/tcl/data-procs.tcl
3:32 pm

antoniop

Fix validated input format

Options
    • -2
    • +2
    /openacs-4/packages/calendar/www/cal-item-new.tcl
3:27 pm

antoniop

Restrict new widget validation of options to select and radio, not every widget must restrict the values to the options property

Options
    • -2
    • +3
    /openacs-4/packages/acs-templating/tcl/data-procs.tcl
3:19 pm

antoniop

Apply a date-aware validation

Options
    • -2
    • +5
    /openacs-4/packages/calendar/www/cal-item-new.tcl
3:00 pm

antoniop

Trap the case where invalid dates are supplied to the proc

Options
    • -2
    • +15
    /openacs-4/packages/calendar/tcl/cal-item-procs.tcl
    • -9
    • +0
    /openacs-4/packages/calendar/tcl/cal-item-procs.xql
2:39 pm

antoniop

Cleanup redundant validation

Options
    • -4
    • +1
    /openacs-4/packages/calendar/www/cal-item-new.tcl
2:38 pm

antoniop

Implement a hook for widget-specific validation and use it to enforce that widgets that specify a list of options must return a value that belongs to those options

Options
    • -2
    • +38
    /openacs-4/packages/acs-templating/tcl/data-procs.tcl
1:56 pm

antoniop

Add input validation

Options
    • -1
    • +4
    /openacs-4/packages/calendar/www/cal-item-new.tcl
12:35 pm

antoniop

Don't pass around variables that are not meant to be changed by the UI as hidden fields

Options
    • -11
    • +7
    /openacs-4/packages/calendar/www/cal-item-new.tcl
12:12 pm

antoniop

Fix typo

Options
    • -2
    • +2
    /openacs-4/packages/file-storage/www/folder-create.tcl
Monday 24 Jan 2022
7:25 pm

gustafn

no need for curly braces

Options
    • -2
    • +2
    /openacs-4/packages/acs-bootstrap-installer/bootstrap.tcl
7:24 pm

gustafn

extend test cases

Options
    • -0
    • +34
    /openacs-4/packages/acs-tcl/tcl/test/acs-tcl-test-procs.tcl
    • -4
    • +5
    /openacs-4/packages/acs-tcl/tcl/test/doc-check-procs.tcl
7:23 pm

gustafn

improve documentation and streamline code

Options
    • -2
    • +2
    /openacs-4/packages/xotcl-core/tcl/context-procs.tcl
    • -8
    • +15
    /openacs-4/packages/xotcl-core/tcl/policy-procs.tcl
    • -0
    • +1
    /openacs-4/packages/xotcl-core/tcl/test/xotcl-test-procs.tcl
7:11 pm

gustafn

do not allow to edit unresolve links during the exam, but allow this in the preview mode

Options
    • -1
    • +1
    /openacs-4/packages/xowf/lib/answer-single-question.wf
    • -6
    • +0
    /openacs-4/packages/xowf/tcl/test-item-procs.tcl
5:35 pm

antoniop

Inform widget: do not render any input element alongside the form value

Options
    • -8
    • +4
    /openacs-4/packages/acs-templating/tcl/widget-procs.tcl
5:31 pm

antoniop

Check if o is an object only once, use nsf idiom to check for a class, unwrap idioms

Options
    • -7
    • +13
    /openacs-4/packages/xotcl-core/tcl/policy-procs.tcl
5:15 pm

antoniop

Port edit-new policy rule from original policy1 object, so that unresolved links can be rendered correctly

Fixes xowf create_composite_test_item automated test

Options
    • -0
    • +6
    /openacs-4/packages/xowf/tcl/test-item-procs.tcl
4:06 pm

gernst

Use package_id instead of the package object

Options
    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/package-procs.tcl
Saturday 22 Jan 2022
7:37 pm

gustafn

fix typo

Options
    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/package-procs.tcl
7:35 pm

gustafn

Disallow "create-from-prototype" to non-admins in exam-answering workflows.

Options
    • -9
    • +25
    /openacs-4/packages/xowf/tcl/test-item-procs.tcl
7:31 pm

gustafn

Added policy priviledge "create-from-prototype"

In certain situations, creating pages from prototype pages might not

be allowed for certain users. The off-the-shelf policies allow

"create-from-prototype" to all users having "create" permissions on

the package_id (very similar to edit-new).

Improve program comments.

Options
    • -30
    • +48
    /openacs-4/packages/xowiki/tcl/package-procs.tcl
7:10 pm

gustafn

Don't break the page cyclus protocol if not necessary.

There is no need to call ad_script_abort in a situation,

where the local installation is broken.

Options
    • -9
    • +16
    /openacs-4/packages/xowiki/tcl/xowiki-www-procs.tcl
1:09 pm

gustafn

Modernize parameter parsing (query and includelet paramters)

- handle invalid UTF-8 exception that might be triggered by

"ns_parsequery" in newer versions of NaviServer

- the new code is about 4 times faster than the old one

- replaced array by dict

- don't create helper procs on the fly but use "nsf::parseargs" if possible

- added icanuse rules for

* "nsf::parseargs -asdict"

* "ns_parsequery -charset"

Options
    • -1
    • +2
    /openacs-4/packages/acs-tcl/tcl/00-icanuse-procs.tcl
    • -31
    • +49
    /openacs-4/packages/xotcl-core/tcl/context-procs.tcl
12:33 pm

gustafn

make function private

Options
    • -2
    • +2
    /openacs-4/packages/xotcl-core/tcl/05-db-procs.tcl
Friday 21 Jan 2022
1:56 pm

antoniop

New test to detect smells of hacking in the code, raising a warning when certain smelly keywords are found

Options
    • -1
    • +39
    /openacs-4/packages/acs-api-browser/tcl/test/acs-api-browser-procs.tcl