• last updated 3 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Improve cmd detection semantics in "tclcode_to_html" to avoid

misintepretations from arguments lists. Make as well explicitly clear

that the results of the private function "api_called_proc_names" is

just based on heuristics, such it can only be used in cases, where

false positives do not matter.

revert change, since it is not clear from the description what it was for

Rename domNode argument to dom_node

tDOM defines a ::domNode command in the global namespace, which might potentially conflict with the argument name. Also, in certain configurations the api-doc machinery will treat the argument as a command usage and try to enforce e.g. the naming convention on it in acs-tcl.naming__proc_naming automated test.

added required argument to calc_grade (many thanks to Markus Moser for noting)

make debug messages more uniform (start always with object and method name)

make log messages more uniform (no need to start with actual proc name)

    • -14
    • +14
    /openacs-4/packages/xowiki/tcl/package-procs.tcl
Don't try query parameters when resolving standard pages

    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/package-procs.tcl
make sure to html-quote error message

    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/package-procs.tcl
Bump version number after spelling changes in message keys

update CKEditor version numbers

An upgrade is highly recommended since the new version contains several security fixes.

https://ckeditor.com/cke4/release-notes

Improve spelling

Fixed update script for applications having the view "upgrade-5.10.0-5.10.1d1.sql" not defined.

This view is a legacy view ancient times, which is no included in standard installations

since ages.... It was however defined on openacs.org.

--

-- Some legacy applications might contain still the VIEW

-- "registered_users_of_package_id", which is defined in

--

-- acs-subsite/sql/postgresql/user-profiles-create.sql

--

-- This file is NOT included in new installations since over 20 years,

-- so it is not maintained and treated as a leftover from ancient

-- times. Therefore, the view registered_users_of_package_id is not

-- recreated by this update script.

fix SQL query

break overlong lines and whitespace cleanup

improve robustness when processing legacy questions

reduce cache hits on nsv "::chat::Chat" and on "::chat::Chat-ID-options"

    • -10
    • +19
    /openacs-4/packages/xowiki/tcl/chat-procs.tcl
replace deprecated calls in test

add debugging info to figure out where xo::parameter is used directly in downstream code

make log entries more uniform

modernize code

fix indentation

improve spelling

    • -2
    • +2
    /openacs-4/packages/dotlrn/dotlrn.info
Bump version number to 5.10.1d6 to reload message keys

    • -2
    • +2
    /openacs-4/packages/acs-tcl/acs-tcl.info
Use "ns_baseunit", when available for size calculation of parititoned caches

Generalize ::acs::try_cache (such it can be use not only for "...cache eval..."

get rid of pipe-open, when nsproxy exec is available

break overlong lines

modernize code

    • -31
    • +36
    /openacs-4/packages/acs-tcl/tcl/defs-procs.tcl
improve spelling

Added support for manual grading and individual feedback

- Lecturers can provide points and feedback comments

directly via exam protocol

- Grading is allowed, when student has submitted the exam or

the exam is not open

- Composite questions are graded at the sub-question level

- Manual grading have a higher priority than automatic grades

- Manual grading/comments can be undone by clearingfield

(showing then missing points, automated computed points, ...)

- Grades and comments are included in the exam review for

students ("Einsicht").

- Grading interactions are implemented as AJAX calls

(no need for redrawing the exam protocol, immediate feedback)

    • -11
    • +56
    /openacs-4/packages/xowf/lib/inclass-exam.wf
    • -159
    • +669
    /openacs-4/packages/xowf/tcl/test-item-procs.tcl
reduce verbosity

    • -3
    • +4
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl