Activity OpenACS/

Redefine faq questions and answers as text, the same as downstream, then redefine all database function api so that argument types are taken from table definition

- -2
- +2
/openacs-4/packages/faq/faq.info
- History
- Source
- Diff
/openacs-4/packages/faq/faq.info
- -3
- +3
/openacs-4/packages/faq/sql/postgresql/faq-create.sql
- History
- Source
- Diff
/openacs-4/packages/.../faq-create.sql
- -27
- +29
/openacs-4/packages/faq/sql/postgresql/faq-package-create.sql
- History
- Source
- Diff
/openacs-4/.../faq-package-create.sql
- -0
- +156
/openacs-4/packages/faq/sql/postgresql/upgrade/upgrade-5.10.0d7-5.10.0d8.sql
- History
- Source
- Diff
/openacs-4/.../upgrade-5.10.0d7-5.10.0d8.sql

12:55 pm

antoniop

More
MAIN:antoniop:20200320115547
deleted 1 file
MAIN

file upgrade-5.10.0d7-5.10.0d8.sql was initially added on branch oacs-5-10.

- -0
- +0
/openacs-4/packages/faq/sql/postgresql/upgrade/upgrade-5.10.0d7-5.10.0d8.sql
- History
- Source
/openacs-4/.../upgrade-5.10.0d7-5.10.0d8.sql

12:55 pm

gustafn

call table data formatter, when avaliable

- -4
- +11
/openacs-4/packages/xowf/tcl/test-item-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../test-item-procs.tcl

12:52 pm

gustafn

provide pretty-print methods for tabular data views

- -1
- +13
/openacs-4/packages/xowiki/tcl/form-field-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../form-field-procs.tcl

11:52 am

antoniop

Handle the case when one is trying to access a non-existing room

- -2
- +10
/openacs-4/packages/chat/www/room-enter.tcl
- History
- Source
- Diff
/openacs-4/packages/.../www/room-enter.tcl

8:24 am

gustafn

Improve last change and document it properly.

Set outdated HTML attributes as depreacted.

- -4
- +28
/openacs-4/packages/xowiki/tcl/link-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../tcl/link-procs.tcl

6:19 pm

gustafn

- make repeatable formfields better configurable (provde max number for repeated elements via parameter)

- improve robustness, when a form field does not provide a "correction" instance variable after "make_correct"

- imporve documentation

- -5
- +23
/openacs-4/packages/xowf/tcl/test-item-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../test-item-procs.tcl

5:13 pm

antoniop

Remove href from the variables we inspect the item for in a file link:

this variable is most likely set, therefore embed_options will be non-empty and most links downstream will be rendered via <embed>

instead than a plain link.

Furthermore, it does appear as non standard according to e.g. https://developer.mozilla.org/en-US/docs/Web/HTML/Element/embed and would probably conflict with the src attribute, which is always set.

- -2
- +2
/openacs-4/packages/xowiki/tcl/link-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../tcl/link-procs.tcl

3:32 pm

gustafn

support show_max for short_text answers

- -3
- +3
/openacs-4/packages/xowiki/tcl/form-field-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../form-field-procs.tcl

3:30 pm

gustafn

omit question title in inclass-exam

- -1
- +1
/openacs-4/packages/xowf/lib/inclass-exam-answer.wf
- History
- Source
- Diff
/openacs-4/.../inclass-exam-answer.wf

3:14 pm

antoniop

Keep returning 0 when no transcript is created, as the code expects

- -2
- +4
/openacs-4/packages/chat/tcl/xotcl-chat-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../xotcl-chat-procs.tcl

3:06 pm

antoniop

Uniform the quoting criteria when dealing with transcripts:

- transcripts are stored as they are, no quoting in the data we store (and therefore HTML should be avoided)

- transcripts are displayed quoted, therefore disabling any effect from HTML eventually present in the content

- bring the logics to build transcript content in the api to avoid duplication

- avoid sending the transcript content to transcript-new-2, as we can generate it server side

Note: storing transcripts as a pre-formatted chunk of text is probably not the best approach, as any changes to the formatting cannot be applied to pre-existing data without a delicate upgrade. This new approach will make <br> tags inside older transcripts visible...