OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 5
Total Committers: 146
Last Commit: 20 Dec
Commits this week: 5
Total Lines of Code (LoC): 7,561,347
Net change in LoC this week: 335

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 13 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 23 Apr
6:21 pm

antoniop

Prevent sneaking symlinks in the content repository

Many thanks to Thomas Rennner and Günter Ernst for analyzing the issue

Options
    • -1
    • +11
    /openacs-4/packages/acs-content-repository/tcl/content-procs.tcl
4:43 pm

antoniop

cr_write_content reform

when serving files, do not trust the content information, as the absolute path to the file can be determined programmatically in this case.

This also reduce divergency between Oracle and Postgres

Options
    • -8
    • +0
    /openacs-4/packages/acs-content-repository/tcl/revision-procs-oracle.xql
    • -8
    • +0
    /openacs-4/packages/acs-content-repository/tcl/revision-procs-postgresql.xql
    • -14
    • +9
    /openacs-4/packages/acs-content-repository/tcl/revision-procs.tcl
2:19 pm

gustafn

Fixed issue introduced in OpenACS 5.9.0

The old version did not insert a property value via the

sec_session_property__upsert() in PostgreSQL on the initial setting

(later updates were OK). The broken version was just adding a tuple

and left the "property_value" empty.

Many thanks to Jonathan Kelley for identifying the issue and reporting it.

Options
    • -2
    • +2
    /openacs-4/packages/acs-kernel/acs-kernel.info
    • -16
    • +16
    /openacs-4/packages/acs-kernel/sql/postgresql/security-create.sql
    • -0
    • +37
    /openacs-4/packages/acs-kernel/sql/postgresql/upgrade/upgrade-5.10.1b4-5.10.1b5.sql
2:19 pm

gustafn

file upgrade-5.10.1b4-5.10.1b5.sql was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/acs-kernel/sql/postgresql/upgrade/upgrade-5.10.1b4-5.10.1b5.sql
1:06 pm

antoniop

Implement a new filter for inclass-exam submissions

When displayed by the print-answers method, allow to filter also for not graded.

Options
    • -10
    • +10
    /openacs-4/packages/xowf/xowf.info
    • -0
    • +1
    /openacs-4/packages/xowf/catalog/xowf.de_DE.ISO-8859-1.xml
    • -0
    • +1
    /openacs-4/packages/xowf/catalog/xowf.en_US.ISO-8859-1.xml
    • -0
    • +1
    /openacs-4/packages/xowf/catalog/xowf.it_IT.ISO-8859-1.xml
    • -0
    • +7
    /openacs-4/packages/xowf/tcl/test-item-procs.tcl
    • -11
    • +24
    /openacs-4/packages/xowf/www/resources/inclass-exam.js
Friday 05 Apr
11:01 am

gustafn

added link to cluster info to acs-admin main page when cluster is enabled

Options
    • -0
    • +1
    /openacs-4/packages/acs-admin/lib/site-wide-services.adp
    • -1
    • +1
    /openacs-4/packages/acs-admin/lib/site-wide-services.tcl
10:53 am

gustafn

improved spelling

Options
    • -1
    • +1
    /openacs-4/packages/xowf/lib/inclass-quiz-answer.wf
    • -2
    • +2
    /openacs-4/packages/xowf/www/index.vuh
    • -1
    • +1
    /openacs-4/packages/xowf/www/resources/inclass-exam.js
    • -1
    • +1
    /openacs-4/packages/xowiki/xowiki.info
    • -2
    • +2
    /openacs-4/packages/xowiki/www/index.vuh
10:41 am

gustafn

clean dirty editor buffer

Options
    • -1
    • +1
    /openacs-4/packages/acs-bootstrap-installer/tcl/40-db-query-dispatcher-procs.tcl
10:39 am

gustafn

improved spelling

Options
    • -2
    • +3
    /openacs-4/packages/acs-bootstrap-installer/tcl/40-db-query-dispatcher-procs.tcl
    • -1
    • +1
    /openacs-4/packages/acs-bootstrap-installer/tcl/test/30-apm-load-procs.tcl
    • -3
    • +3
    /openacs-4/packages/xotcl-core/tcl/03-doc-procs.tcl
    • -3
    • +3
    /openacs-4/packages/xotcl-core/tcl/http-client-procs.tcl
10:39 am

gustafn

Made startup more robust

- handle not-yet-defined callback procs gracefully

Options
    • -3
    • +14
    /openacs-4/packages/acs-bootstrap-installer/tcl/00-proc-procs.tcl
10:32 am

gustafn

updated version number of jquery (introduced not long ago)

Options
    • -1
    • +1
    /openacs-4/packages/dotlrn-bootstrap3-theme/tcl/apm-callback-procs.tcl
10:28 am

gustafn

Improved readability of configuration parameter "parameterSecret"

- Switched to camelCase for better readabilty and uniformity

- NaviServer configuration parameters are case insensitive, so no danger for backward compatibility

Options
    • -4
    • +4
    /openacs-4/packages/acs-tcl/tcl/security-init.tcl
    • -6
    • +6
    /openacs-4/packages/acs-tcl/tcl/security-procs.tcl
    • -4
    • +4
    /openacs-4/packages/acs-tcl/tcl/tcl-documentation-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
    • -1
    • +1
    /openacs-4/packages/xotcl-core/tcl/01-debug-procs.tcl
    • -3
    • +3
    /openacs-4/packages/xowiki/tcl/form-field-procs.tcl
Friday 29 Mar
9:39 am

gustafn

Made .xql file more consistent by using dot notation

OpenACS for PostgreSQL uses since the release of 5.10.0 the dot

notation for the SQL function acs_permission.permission_p() to ease

portability with Oracle.

In general, one has to be careful that during an upgrade from an older

OpenACS version (e.g. 5.9.*) directly to 5.10.1 to upgrade process

does not depend on the dot notation, otherwise the upgrade will fail.

One should be safe for most UI functions in this respect.

Options
    • -2
    • +2
    /openacs-4/packages/acs-subsite/www/admin/site-map/index-postgresql.xql
Wednesday 27 Mar
12:46 pm

antoniop

Expand permission test suite to include definition of custom privileges in a couple of setups

Options
    • -11
    • +221
    /openacs-4/packages/acs-tcl/tcl/test/test-permissions-procs.tcl
Tuesday 26 Mar
10:10 am

antoniop

Provide an automated test of "advanced" permission features: permission inheritance via group, or via the permission context

Options
    • -1
    • +203
    /openacs-4/packages/acs-tcl/tcl/test/test-permissions-procs.tcl
Friday 22 Mar
4:06 pm

antoniop

Use a simpler approach to achieve the intended result, which does not rely on events

Options
    • -19
    • +8
    /openacs-4/packages/xowiki/tcl/chat-procs.tcl
Wednesday 20 Mar
12:25 pm

antoniop

Keep comments on the server side

Options
    • -7
    • +10
    /openacs-4/packages/xowiki/tcl/chat-procs.tcl
11:25 am

gustafn

JS upstream updates

- Updated highcharts to 11.4.0 (when highcharts package is not installed)

- Updated jquery-3.6.3 to jquery-3.7.1.

- Bumped version number to 5.10.1b10

Options
    • -2
    • +2
    /openacs-4/packages/xowiki/xowiki.info
    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/resource-init.tcl
    • -10965
    • +0
    /openacs-4/packages/xowiki/www/resources/jquery/jquery-3.6.4.js
    • -2
    • +0
    /openacs-4/packages/xowiki/www/resources/jquery/jquery-3.6.4.min.js
    • -0
    • +10716
    /openacs-4/packages/xowiki/www/resources/jquery/jquery-3.7.1.js
    • -0
    • +2
    /openacs-4/packages/xowiki/www/resources/jquery/jquery-3.7.1.min.js
11:24 am

antoniop

Ensure chat javascript is executed only when the chat itself is actually a part of the DOM

This may not be the case at the time of rendering, e.g. because the chat is rendered inside of a <template> tag and appended to the document at a later moment.

Options
    • -2
    • +19
    /openacs-4/packages/xowiki/tcl/chat-procs.tcl
11:21 am

gustafn

JS upstream updates

- Updated upstream library to 11.4.0

- Bumped version to 0.5

Options
    • -2
    • +2
    /openacs-4/packages/highcharts/highcharts.info
    • -2
    • +2
    /openacs-4/packages/highcharts/tcl/resource-procs.tcl
11:19 am

gustafn

JS upstream updates

- Updated jquery-3.6.3 to jquery-3.7.1.

- Bumped version to 5.10.1b2

Options
    • -2
    • +2
    /openacs-4/packages/openacs-bootstrap3-theme/openacs-bootstrap3-theme.info
    • -1
    • +1
    /openacs-4/packages/openacs-bootstrap3-theme/tcl/resource-init.tcl
    • -10993
    • +0
    /openacs-4/packages/openacs-bootstrap3-theme/www/resources/js/jquery-3.6.3.js
    • -0
    • +10716
    /openacs-4/packages/openacs-bootstrap3-theme/www/resources/js/jquery-3.7.1.js
    • -0
    • +2
    /openacs-4/packages/openacs-bootstrap3-theme/www/resources/js/jquery-3.7.1.min.js
11:18 am

gustafn

JS upstream updates

- Updated boostrap5 to 5.3.3

- Updated jquery-3.6.3 to jquery-3.7.1.

- Bumped version to 5.10.1b4

Options
    • -2
    • +2
    /openacs-4/packages/openacs-bootstrap5-theme/openacs-bootstrap5-theme.info
    • -1
    • +1
    /openacs-4/packages/openacs-bootstrap5-theme/tcl/resource-init.tcl
    • -1
    • +1
    /openacs-4/packages/openacs-bootstrap5-theme/tcl/resource-procs.tcl
    • -10993
    • +0
    /openacs-4/packages/openacs-bootstrap5-theme/www/resources/js/jquery-3.6.3.js
    • -2
    • +0
    /openacs-4/packages/openacs-bootstrap5-theme/www/resources/js/jquery-3.6.3.min.js
    • -0
    • +10716
    /openacs-4/packages/openacs-bootstrap5-theme/www/resources/js/jquery-3.7.1.js
    • -0
    • +2
    /openacs-4/packages/openacs-bootstrap5-theme/www/resources/js/jquery-3.7.1.min.js
11:18 am

gustafn

file jquery-3.7.1.js was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/openacs-bootstrap5-theme/www/resources/js/jquery-3.7.1.js
    • -0
    • +0
    /openacs-4/packages/openacs-bootstrap3-theme/www/resources/js/jquery-3.7.1.js
    • -0
    • +0
    /openacs-4/packages/xowiki/www/resources/jquery/jquery-3.7.1.js
11:18 am

gustafn

file jquery-3.7.1.min.js was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/openacs-bootstrap5-theme/www/resources/js/jquery-3.7.1.min.js
    • -0
    • +0
    /openacs-4/packages/openacs-bootstrap3-theme/www/resources/js/jquery-3.7.1.min.js
    • -0
    • +0
    /openacs-4/packages/xowiki/www/resources/jquery/jquery-3.7.1.min.js
Tuesday 19 Mar
11:47 am

antoniop

Untangle if logics

Options
    • -23
    • +30
    /openacs-4/packages/acs-tcl/tcl/text-html-procs.tcl
11:46 am

antoniop

Reject URLs displaying multiple protocols

Options
    • -1
    • +27
    /openacs-4/packages/acs-tcl/tcl/text-html-procs.tcl
11:44 am

antoniop

Test further improvement of injection attempt by penetration tests

Options
    • -0
    • +10
    /openacs-4/packages/acs-tcl/tcl/test/text-html-procs.tcl
Monday 18 Mar
2:24 pm

antoniop

Harden page contract

Options
    • -2
    • +2
    /openacs-4/packages/acs-subsite/www/permissions/one.tcl
    • -3
    • +3
    /openacs-4/packages/acs-subsite/www/permissions/toggle-inherit.tcl
2:13 pm

antoniop

Strenghten validation against smarter attempts to disguise the javascript: protocol

Options
    • -10
    • +17
    /openacs-4/packages/acs-tcl/tcl/text-html-procs.tcl
2:12 pm

antoniop

Replicate a smarter attempt by a penetration tool to disguise the javascript: protocol

Options
    • -11
    • +24
    /openacs-4/packages/acs-tcl/tcl/test/text-html-procs.tcl