• last updated 7 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Test portlet rendering

Make one-time apm callbacks private

Complete coverage of the remaining api

Deprecate trivial calendar_portlet_display::get_url_stub not used anywhere

Name the form in a way that it will be de-facto unique on the page and multiple instances of the same portlet can be rendered together

Extend tests of calendar portlet rendering

This will expose a limitation when multiple instances of the same portlet are rendered on the same page

Make test more independent from current instance status

Basic test of portlet rendering

Handle persisting messages from outside of a connection, e.g. in the chat sweeper

Port of downstream behavior:

- never display all of the rooms, but only those where we have access (e.g. read permission and not banned) on the specified packages

- when the portlet is rendered outside of a community, e.g. in the personal home, split chat rooms by package (community name)

- considered rendering outside a connection or lack of package as shaded

- display number of currently connected users

- (Postgres only) provide a more efficient query when one might have access to many chats

Also cleanup acs_attribute

Deprecate trivial wrapper dotlrn_chat::add_portlet_helper

Cus short computations when the portlet is shaded

Reduce divergency between Oracle and Postgres codebase

Cleanup the vestigial moderated_p flag

    • -5
    • +5
    /openacs-4/packages/chat/tcl/chat-procs.tcl
    • -2
    • +1
    /openacs-4/packages/chat/www/index.tcl
    • -6
    • +0
    /openacs-4/packages/chat/www/room-edit.tcl
Get rid of the intermediate "room-enter" page and enforce all of the relevant permission in place in the "chat" page, cleanup variables and update automated tests

    • -24
    • +9
    /openacs-4/packages/chat/www/chat.tcl
    • -2
    • +2
    /openacs-4/packages/chat/www/index.tcl
    • -36
    • +0
    /openacs-4/packages/chat/www/room-enter.tcl
Update api

Modernize api

Modernize idiom

Use modern api

Update api to streamline idiom

Update api

No need to access the form directly here

ns_getform will return the empty string only when invoked outside of a connection thread, which is a non-issue at installation time

Deprecate trivial wrappers to the NaviServer API

Modern ns_getform will not return the empty string for empty requests, but only when we are operating outside of a connection. In such circumstances is arguably useful to manipulate the request parameters.

Commit missing change to the users api

Prefer Naviserver API directly

Prefer NaviServer API directly

Rework idiom

Rework idiom