Activity OpenACS/

[30/Aug/2022:14:07:29.820625][3102633.7f152c28d700][-conn:openacs.org:default:0:196214-] Error: rp_handler no-script-abort: errorMsg can't read "message(forum_id)": no such variable while serving GE

T /forums/message-view?message_id HTTP/1.1

: ad_url </forums/message-view> maps to file </var/www/openacs.org/packages/forums/www/message-view.adp>

: TCL LOOKUP VARNAME message

: can't read "message(forum_id)": no such variable

: while executing

: "forum::get -forum_id $message(forum_id) -array forum"

Probably, in many more cases, the incorrect removal of the notnull constrain performed by [1]

requires the same fix.

[1] https://github.com/openacs/forums/commit/c403e3134ce4e73ba94a80540a8b0f3cb1651ed0#diff-d35c736495ede0174fb39791ab660c5cd1a4ca467db2c4741cfc935167d7e5a8

- -2
- +2
/openacs-4/packages/forums/www/message-view.tcl
- History
- Source
- Diff
/openacs-4/packages/.../www/message-view.tcl

2:03 pm

gustafn

handle clases, where "nt_load_end" is not provided

- -2
- +6
/openacs-4/packages/boomerang/tcl/boomerang-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../boomerang-procs.tcl

1:13 pm

hectorr

Replace message keys inside message keys. Many thanks to Monika Andergassen.

- -2
- +2
/openacs-4/packages/acs-subsite/acs-subsite.info
- History
- Source
- Diff
/openacs-4/packages/.../acs-subsite.info
- -1
- +1
/openacs-4/packages/acs-subsite/catalog/acs-subsite.de_DE.ISO-8859-1.xml
- History
- Source
- Diff
/openacs-4/.../acs-subsite.de_DE.ISO-8859-1.xml
- -1
- +1
/openacs-4/packages/acs-subsite/catalog/acs-subsite.en_US.ISO-8859-1.xml
- History
- Source
- Diff
/openacs-4/.../acs-subsite.en_US.ISO-8859-1.xml
- -1
- +1
/openacs-4/packages/acs-subsite/catalog/acs-subsite.it_IT.ISO-8859-1.xml
- History
- Source
- Diff
/openacs-4/.../acs-subsite.it_IT.ISO-8859-1.xml
- -1
- +1
/openacs-4/packages/acs-subsite/catalog/acs-subsite.ru_RU.utf-8.xml
- History
- Source
- Diff
/openacs-4/.../acs-subsite.ru_RU.utf-8.xml

12:20 pm

antoniop

Harden page contract

- -9
- +2
/openacs-4/packages/acs-subsite/www/user/portrait/upload.tcl
- History
- Source
- Diff
/openacs-4/packages/.../portrait/upload.tcl

12:15 pm

antoniop

Make script more robust to agents that won't specify the tmpfile via using the api to retrieve the file information

- -6
- +14
/openacs-4/packages/acs-subsite/www/user/portrait/upload.tcl
- History
- Source
- Diff
/openacs-4/packages/.../portrait/upload.tcl

11:38 am

antoniop

Fix typo

- -2
- +4
/openacs-4/packages/acs-templating/tcl/element-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../tcl/element-procs.tcl

11:35 am

antoniop

template::element validation reform: do not run custom user-defined validation on fields that are not formally correct

Rationale: user-defined validation often assumes some basic consistency of the submitted value. When this is not formally correct, users might have to reimplement the whole formal validation in their custom fields in order to prevent exceptions. By preventing their custom blocks from being executed, users can rely on their custom fields to be run only against sane values.