• last updated 12 hours ago
Constraints: committers
Constraints: files
Constraints: dates
Fix acs-lang.test_message_register automated test:

when checking if a message should be created or updated, do not trust the nsv, which won't be there for messages that have been soft-deleted and go to the db instead. When a message is soft deleted, cleanup the nsv cache.

Expose a bug in the message key registration:

when a message key is soft-deleted and the server is restarted, upon re-registration the nsv that signals its presence won't be found and an insertion will be attempted. However, as the db entry is there, a primary key constraint will be triggered.

Test content::item::copy

make parameter name more self-expanatory to avoid misinterpretations

    • -1
    • +1
    • -2
    • +2
    • -11
    • +11
user forwarder for answer manager AM similar to the question manager QM

    • -33
    • +30
Store statistics in a separate page instead of the workflow itself

- advantages:

* smaller workflow instance

- no danger that page is too large for caching, even for large exams.

- smaller objects mean also better performance

* modification date in exam is not modified when statistics

are updated

* easier extensible

- New function WorkflowPage->childpage

easy to use interface for creating child pages

- render_submission=exam_protocol: changed name of

parameter "-form_objs" to "-filter_form_ids", since

form_objs are used typically to keep objects, not ids

- Still to do: policy for inclass-exam-statistics.wf

- Bumped version number to 5.10.1d25

    • -8
    • +12
    • -40
    • +113
    • -8
    • +55
file inclass-exam-statistics.wf.page was initially added on branch oacs-5-10.

Updated inferface for Page->create_form_page_instance

Since "create_form_page_instance" creates always a form

page, we can also pass the state at creation to it

(like other essential parameters). The default value

is "initial" (the default state in workflows).

Bumped version number to 5.10.1d15

    • -2
    • +2
    • -5
    • +3
updated list of tested functions

Fix comment

Simplify test logics, bring comment closer to relevant code

make calculation of [ns_set array [ns_getform]] more robust

in case, invalid UTF-8 is passed in, [ns_getform] might be empty.

probably this could also be addressed in NaviServer

    • -5
    • +8
improve styling of horizonal form fields (many thanks to Monika Andergassen)

Improve robustness of xowf.create_test_items automated test: make sure that the exercise appearing is actually supposed to render 2 images

Fixes xowf.create_test_items automated test

Compute amplitude and wavelength explicitly in pixels and make it stable with respect to the captcha size, introduce a random offset for the wave instead

Fixes acs-templating.tesseract_cannot_crack_catpcha automated test

Fix typo

Fix tag

Minor modernization

- use atomic stack operations to reduce locks and avoid race conditions

- improve spelling

- break overlong lines

- better align comments with actual code

refactor code

    • -20
    • +44
    • -35
    • +8
Make creation of ::xo::cc more robust

In case the argument processing of

ConnectionContext create ::xo::cc -p1 ... -p2 ....

::xo::cc destroy_on_cleanup

runs into an exception leading to an ad_script_abort, the half-in

initialized object without cleanup definition will survive. At later

times, this object might be reused, containing potentially

cached results from earlier runs, which can cause troubles in error


This change takes care that errors during argument processing will

not leave half-initialized objects behind.

improve wording in comments

use "ns_strcoll" for ordered composite when available

improve wording

safetybelt for acunetix testing: refetch parameter page, when it is not initialized

hopefully a temporary measure

    • -1
    • +9
Do not consider unchecked radio buttons as form values, or when an unselected radio exists, the last value will might be picked

Fixes xowiki.create_form_with_form_instance, breaks xowf.create_test_items

Test reproducing an upstream use case: a compound field made of both regular, and compound field, with the compound field also repeated

This test exposes a bug in the acs::test::xpath::get_form_values proc

update message catalog

Provide a message key for help text, localize in German

Drop the pointsize parameter, use size instead, yielding more predictable results across Imagemagik versions and more controllable in general, make the wavelength randomized in the distortion

Port downstream change: adding label for question selection box

Many thanks to Felix Mödritscher