OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 8
Total Committers: 146
Last Commit: 14:20
Commits this week: 8
Total Lines of Code (LoC): 7,560,931
Net change in LoC this week: 110

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 13 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 04 Oct 2021
3:56 pm

antoniop

Reduce divergency between oracle and postgres codebase

Options
    • -25
    • +0
    /openacs-4/packages/acs-subsite/www/admin/rel-types/one-oracle.xql
    • -22
    • +0
    /openacs-4/packages/acs-subsite/www/admin/rel-types/one-postgresql.xql
    • -2
    • +15
    /openacs-4/packages/acs-subsite/www/admin/rel-types/one.tcl
3:49 pm

antoniop

Cleanup unreferenced SQL

Options
    • -15
    • +0
    /openacs-4/packages/acs-subsite/www/admin/site-map/index-oracle.xql
12:30 pm

antoniop

Reduce divergency between oracle and postgres codebase

Options
    • -27
    • +0
    /openacs-4/packages/acs-subsite/www/admin/group-types/one-oracle.xql
    • -23
    • +0
    /openacs-4/packages/acs-subsite/www/admin/group-types/one-postgresql.xql
    • -2
    • +15
    /openacs-4/packages/acs-subsite/www/admin/group-types/one.tcl
12:12 pm

antoniop

Reduce divergency between oracle and postgres codebase

Options
    • -19
    • +0
    /openacs-4/packages/acs-authentication/tcl/test/acs-authentication-procs-oracle.xql
    • -19
    • +0
    /openacs-4/packages/acs-authentication/tcl/test/acs-authentication-procs-postgresql.xql
    • -2
    • +11
    /openacs-4/packages/acs-authentication/tcl/test/acs-authentication-procs.tcl
    • -19
    • +0
    /openacs-4/packages/acs-lang/tcl/lang-util-procs-oracle.xql
    • -18
    • +0
    /openacs-4/packages/acs-lang/tcl/lang-util-procs-postgresql.xql
    • -2
    • +8
    /openacs-4/packages/acs-lang/tcl/lang-util-procs.tcl
    • -36
    • +0
    /openacs-4/packages/acs-lang/www/admin/batch-editor-oracle.xql
    • -29
    • +0
    /openacs-4/packages/acs-lang/www/admin/batch-editor-postgresql.xql
    • -1
    • +20
    /openacs-4/packages/acs-lang/www/admin/batch-editor.tcl
11:37 am

gustafn

Improving ad_parameter_cache:

- added handling of cachingmode "none"

- added implementation via "nsv_dict" (cluster aware)

- execute parameter callbacks cluster-wide

- version number bumped to 5.10.1d4

Options
    • -2
    • +2
    /openacs-4/packages/acs-tcl/acs-tcl.info
    • -7
    • +9
    /openacs-4/packages/acs-tcl/tcl/acs-cache-procs.tcl
    • -47
    • +165
    /openacs-4/packages/acs-tcl/tcl/defs-procs.tcl
    • -3
    • +3
    /openacs-4/packages/acs-tcl/tcl/parameter-procs.tcl
11:35 am

gustafn

improve spelling

Options
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/security-procs.tcl
10:34 am

gustafn

added line missing after refactoring

Options
    • -0
    • +1
    /openacs-4/packages/xowf/lib/inclass-exam.wf
10:31 am

gustafn

fix editing bug

Options
    • -2
    • +2
    /openacs-4/packages/xotcl-core/tcl/cluster-procs.tcl
10:05 am

gustafn

improve robustness for earlier created exams

Options
    • -2
    • +1
    /openacs-4/packages/xowf/lib/inclass-exam.wf
Sunday 03 Oct 2021
8:20 pm

gustafn

improve spelling in .info files

Options
    • -1
    • +1
    /openacs-4/packages/acs-kernel/acs-kernel.info
    • -1
    • +1
    /openacs-4/packages/chat/chat.info
    • -1
    • +1
    /openacs-4/packages/dotlrn/dotlrn.info
    • -1
    • +1
    /openacs-4/packages/file-storage/file-storage.info
    • -2
    • +2
    /openacs-4/packages/forums/forums.info
    • -1
    • +1
    /openacs-4/packages/new-portal/new-portal.info
8:18 pm

gustafn

update release date

Options
    • -1
    • +1
    /openacs-4/packages/contacts-lite/contacts-lite.info
8:14 pm

gustafn

fix typo

Options
    • -1
    • +1
    /openacs-4/packages/acs-kernel/acs-kernel.info
8:13 pm

gustafn

added support for SCRYPT (RFC 7914) as password hash function.

The use of scrypt requires NaviServer compiled with OpenSSL 3.0 or newer

Options
    • -3
    • +3
    /openacs-4/packages/acs-kernel/acs-kernel.info
    • -2
    • +15
    /openacs-4/packages/acs-tcl/tcl/security-procs.tcl
7:38 pm

gustafn

use acs::clusterwide instead of xo::clusterwide

Options
    • -2
    • +2
    /openacs-4/packages/chat/tcl/chat-ajax-procs.tcl
    • -1
    • +1
    /openacs-4/packages/xooauth/tcl/package-procs.tcl
    • -44
    • +0
    /openacs-4/packages/xotcl-core/tcl/cluster-init.tcl
    • -125
    • +17
    /openacs-4/packages/xotcl-core/tcl/cluster-procs.tcl
    • -23
    • +23
    /openacs-4/packages/xowiki/tcl/chat-procs.tcl
    • -3
    • +3
    /openacs-4/packages/xowiki/tcl/link-procs.tcl
7:15 pm

gustafn

improve spelling

Options
    • -1
    • +2
    /openacs-4/packages/acs-bootstrap-installer/tcl/20-db-bootstrap-procs.tcl
    • -3
    • +3
    /openacs-4/packages/xotcl-request-monitor/tcl/throttle_mod-procs.tcl
Saturday 02 Oct 2021
11:25 am

gustafn

Make inclass-exam more foolproof

In case, the randomization is NOT suited for a real exam, do not allow

the user to publish this exam. In cases, where creating exams with

randomization=always are ok, pass "p.realexam=0" to the create

link (and call the entry maybe "training exam")

Options
    • -1
    • +12
    /openacs-4/packages/xowf/lib/inclass-exam.wf
    • -1
    • +1
    /openacs-4/packages/xowf/tcl/test-item-procs.tcl
Friday 01 Oct 2021
9:30 am

gustafn

file upgrade-5.10.1d2-5.10.1d3.sql was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/acs-kernel/sql/oracle/upgrade/upgrade-5.10.1d2-5.10.1d3.sql
    • -0
    • +0
    /openacs-4/packages/acs-kernel/sql/postgresql/upgrade/upgrade-5.10.1d2-5.10.1d3.sql
9:30 am

gustafn

stick to the original names with the "-" since this is also the naming convention outside of OpenACS (e.g. "scram-sha-256")

Options
    • -2
    • +2
    /openacs-4/packages/acs-kernel/acs-kernel.info
    • -2
    • +2
    /openacs-4/packages/acs-kernel/sql/oracle/community-core-create.sql
    • -0
    • +9
    /openacs-4/packages/acs-kernel/sql/oracle/upgrade/upgrade-5.10.1d2-5.10.1d3.sql
    • -2
    • +2
    /openacs-4/packages/acs-kernel/sql/postgresql/community-core-create.sql
    • -0
    • +10
    /openacs-4/packages/acs-kernel/sql/postgresql/upgrade/upgrade-5.10.1d2-5.10.1d3.sql
    • -3
    • +3
    /openacs-4/packages/acs-tcl/acs-tcl.info
    • -7
    • +7
    /openacs-4/packages/acs-tcl/tcl/security-procs.tcl
    • -2
    • +4
    /openacs-4/packages/acs-tcl/tcl/test/doc-check-procs.tcl
Thursday 30 Sep 2021
6:21 pm

antoniop

Set ad_include_contract's local variables in a way that they are hinted as private by the "__" prefix: this reduces the chance of conflicting with popular variable names to pass to an include such as "context"

Options
    • -5
    • +5
    /openacs-4/packages/acs-tcl/tcl/tcl-documentation-procs.tcl
2:34 pm

gustafn

Change caching of driver keys

There seems to be a bug in "db_driverkey", when OpenACS connects to

multiple databases [1]. The situation with "db_driverkey" is

complicated by the fact that this function is sometimes called with a

database name in its argument "dbn", and sometimes with a database

handle. This is something to look at in the future.

The new version removes the per-thread caching, which was introduced

to reduce the high number of mutex locks caused in busy machines. The

new version is better by a factor of 2 than older versions, but relies

on NaviServer.

[1] https://openacs.org/forums/message-view?message_id=5537865

Options
    • -33
    • +42
    /openacs-4/packages/acs-tcl/tcl/01-database-procs.tcl
Wednesday 29 Sep 2021
2:09 pm

antoniop

file upgrade-5.10.1d1-5.10.1d2.sql was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/acs-kernel/sql/oracle/upgrade/upgrade-5.10.1d1-5.10.1d2.sql
    • -0
    • +0
    /openacs-4/packages/acs-kernel/sql/postgresql/upgrade/upgrade-5.10.1d1-5.10.1d2.sql
2:09 pm

antoniop

Complete reform introduced in https://cvs.openacs.org/changelog/OpenACS?cs=oacs-5-10%3Agustafn%3A20210928124647

- add datamodel change to the creation script

- refactor algorithm names in a way that the new procs will comply with acs-tcl.naming__proc_naming automated test

Options
    • -3
    • +3
    /openacs-4/packages/acs-kernel/acs-kernel.info
    • -2
    • +4
    /openacs-4/packages/acs-kernel/sql/oracle/community-core-create.sql
    • -0
    • +9
    /openacs-4/packages/acs-kernel/sql/oracle/upgrade/upgrade-5.10.1d1-5.10.1d2.sql
    • -2
    • +4
    /openacs-4/packages/acs-kernel/sql/postgresql/community-core-create.sql
    • -0
    • +10
    /openacs-4/packages/acs-kernel/sql/postgresql/upgrade/upgrade-5.10.1d1-5.10.1d2.sql
    • -3
    • +3
    /openacs-4/packages/acs-tcl/acs-tcl.info
    • -7
    • +7
    /openacs-4/packages/acs-tcl/tcl/security-procs.tcl
1:34 pm

antoniop

Fix typo affecting only a fresh installation of the chat package...

Options
    • -1
    • +1
    /openacs-4/packages/chat/tcl/xotcl-chat-procs.tcl
Tuesday 28 Sep 2021
10:15 pm

gustafn

revert regression introduced on Aug 07 and factor out common code

Options
    • -8
    • +16
    /openacs-4/packages/xowiki/tcl/xowiki-www-procs.tcl
2:46 pm

gustafn

file upgrade-5.10.0-5.10.1d1.sql was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/acs-kernel/sql/oracle/upgrade/upgrade-5.10.0-5.10.1d1.sql
    • -0
    • +0
    /openacs-4/packages/acs-kernel/sql/postgresql/upgrade/upgrade-5.10.0-5.10.1d1.sql
2:46 pm

gustafn

Stronger password hashes for OpenACS

This change introduces the possibility to use either the classical

OpenACS password hash algorithm "salted-sha1" or the SCRAM passord

function "scram-sha-256". The latter can be used by (a) using the

most recent version of NaviServer (from Sept 28, 2021 or newer) and

(b) by configuring the password hash preferences via Kernel package

parameter "PasswordHashAlgorithm". The package parameter can contain a

list of multiple hash algorithms in preference order. The most

preferred available algorithm is chosen.

By default, the "PasswordHashAlgorithm" is "salted-sha1", and the

behavior is as before. After upgrading to the new version of acs-tcl

and acs-kernel, the preference list can be configured. When a user

logs in and the preferred available algorithm is different from the

previously used algorithm, the upgrade is performed for the user

automatically.

The usage of SHA1 in OpenACS is easily target of security audits (see

[1]). The biggest danger is that if somebody gets full access to the

"users" table (e.g. when decommissioning a hard disk). In this case

the hashes can be attacked with dictionaries by using some crypto

hardware (when someone gets raw access to the DB, one has usually some

other big problems). However, by using the "scram-sha-256" hash

function this danger is substantially reduced. This function computes

a password hash using PBKDF2 (Password-Based Key Derivation Function

2). This function is used to reduce vulnerabilities of brute-force

attacks against password hashes. The hash function of SCRAM is PBKDF2

[RFC2898] with HMAC as the pseudorandom function (PRF) and with dkLen

== output length of HMAC == output length of the digest function. So,

it uses a better hash algorithm (sha-256 vs. sha1) and applies this a

high number of times (15K times for a password hash computation).

NaviServer supports as well the even better SCRYPT algorithm, but this

is only available when NaviServer is compiled with OpenSSL 3.0 or

newer. On the contrary, scram-sha-256 (actually PKCS5_PBKDF2_HMAC) is

available since OpenSSL 1.0.0 (2015).

All the improved hash functions require NaviServer with its tight

integration to the crypto functions of OpenSSL.

[1] https://openacs.org/forums/message-view?message_id=5522562

Options
    • -2
    • +3
    /openacs-4/packages/acs-kernel/acs-kernel.info
    • -0
    • +57
    /openacs-4/packages/acs-kernel/sql/oracle/upgrade/upgrade-5.10.0-5.10.1d1.sql
    • -0
    • +47
    /openacs-4/packages/acs-kernel/sql/postgresql/upgrade/upgrade-5.10.0-5.10.1d1.sql
    • -3
    • +3
    /openacs-4/packages/acs-tcl/acs-tcl.info
    • -0
    • +1
    /openacs-4/packages/acs-tcl/tcl/00-icanuse-procs.tcl
    • -14
    • +103
    /openacs-4/packages/acs-tcl/tcl/security-procs.tcl
    • -17
    • +0
    /openacs-4/packages/acs-tcl/tcl/security-procs.xql
Monday 27 Sep 2021
1:28 pm

antoniop

Add missing argument expansion and comply with automated test

Options
    • -3
    • +3
    /openacs-4/packages/acs-tcl/tcl/request-processor-procs.tcl
1:27 pm

antoniop

Test for ad_register_proc exposing a bug due to missing argument expansion

Options
    • -0
    • +159
    /openacs-4/packages/acs-tcl/tcl/test/request-processor-procs.tcl
1:27 pm

antoniop

file request-processor-procs.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/acs-tcl/tcl/test/request-processor-procs.tcl
Friday 24 Sep 2021
1:38 pm

gustafn

Improved spelling

Options
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/tcl-documentation-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl