• last updated 16 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
ad_urlencode_url: add a slash to the path when this is not empty, fix test case

Extend test

Avoid useless check

Expose a regression after changes for bug #3437

styling for count-down alarm

countdown alarm: add audible alarm when the countdown timer reaches expiration.

Per default, the audible alarm is turned off, but the user sees a

mute symbol. When the user activates the audible alarm, the browser

will announce the nearing end by beep signals in increasingly shorter

periods before its expiration (default settings: 60, 30, 20, 10, 5,

2s; these values can be changed via HTML). Once a user has activated

the audio signals, these are preseveed between page changes via a

cookie. On some browsers (e.g. Chrome), the audioContext settings are

so restrictive, that the full reload requires a new activation of the

alarm via a "user gesture" (i.e. clicking on the audio symbol). It

would be not surprising, if some other browsers show different

behavior, but the code follows the relatively new recommendations. The

code was tested with Chrome/Chromium 83 and Firefox 77).

    • -1
    • +128
    /openacs-4/packages/xowf/tcl/test-item-procs.tcl
Whitespace cleanup

whitespace cleanup

don't try to compute points from starred results

Kill message key translation only when the original user message is included in the notification

Do not kill localization for moderator notifications, as they contain indeed message keys to be localized

- textarea: added attribute "autosave"

- set autosave attributes in text_fields, when "multiple_lines" was specified.

- remove for the time being "hkey" from "non_cached_instance_var_patterns",

since this was recently fixed (TODO: check regression test and reactivate it later)

- new Externally callable method: autosave-attribute:

this is a simplified version of "save-attributes", but which does

NOT perform input validation, which might be a problem in case of partial input

- add "autosave-attribute" to all policies, where "save-attributes" was set

    • -1
    • +5
    /openacs-4/packages/xowiki/tcl/package-procs.tcl
    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
file autosave-text.js was initially added on branch oacs-5-10.

    • -0
    • +0
    /openacs-4/packages/xowiki/www/resources/autosave-text.js
- fix remove_non_persistent_vars (ignored specified pattern)

- update_attribute_from_slot: make sure the instance variable is also updated

provide better recovery from internal redirects, where ::ad_conn is not available

add test cases for slot interactions

preserver slot, such that updating extended slots (e.g. "description") via update_attribute_from_slot works

make test more robust against extending attributes

Whitespace changes

Fix regression in '::xo::system_stats' proc 'recordtimes' introduced during array to dict conversion. Name and tid of the thread were excluded from the 'i' dict, breaking the call to ':thread_classify'

Fix for plausible file checking in cr_delete_orphans

The code checks for files, which are not conforming to the naming conventions,

and intends to skip these. ... but a "continue" was missing.

Many thanks to Franz Penz

more more fix for issue #3441

As Keith reported, there is was one more issue concerning missing column_names and empty query results. This is now as well fixed in oacs-5-10. Also, the regression test was extended to handle these cases as well.

Status is actually a number

improve loading times and blueprint size, when acs-automated testing is deactivated

For details, see: https://openacs.org/forums/message-view?message_id=5452350

CVS: ----------------------------------------------------------------------

fix typo

provide better handling of deactivated packages

don't depend on the node-id cache, which is only available, when xotcl-core is loaded

    • -2
    • +2
    /openacs-4/packages/acs-tcl/acs-tcl.info
file acs-cache-init.tcl was initially added on branch oacs-5-10.

    • -0
    • +0
    /openacs-4/packages/acs-tcl/tcl/acs-cache-init.tcl
make sure, the notification url has a slash before the package path

fix for issue #3441