OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 18
Total Committers: 146
Last Commit: 12:28
Commits this week: 18
Total Lines of Code (LoC): 7,560,946
Net change in LoC this week: 3

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 11 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 26 Nov
9:18 am

gustafn

Avoid calls to deprecated NaviServer functions

Options
    • -1
    • +0
    /openacs-4/packages/acs-tcl/tcl/00-icanuse-procs.tcl
    • -1
    • +1
    /openacs-4/packages/acs-tcl/tcl/cluster-procs.tcl
    • -5
    • +5
    /openacs-4/packages/acs-tcl/tcl/deprecated-procs.tcl
    • -22
    • +1
    /openacs-4/packages/acs-tcl/tcl/security-procs.tcl
Monday 25 Nov
5:24 pm

antoniop

Initializing a formfield with an invalid spec fails as expected, however, it appears to leave behind the formfield object, which many automated tests will now consider a failure

Ensure the formfield object is destroyed when reading the spec fails

Options
    • -2
    • +11
    /openacs-4/packages/xowiki/tcl/form-field-procs.tcl
5:22 pm

antoniop

Make the search datasource callback more robust in case pages are broken or otherwise invalid (but complain about it)

Options
    • -9
    • +28
    /openacs-4/packages/xowiki/tcl/xowiki-sc-procs.tcl
3:46 pm

antoniop

Cast to correct datatypes, delete broken placeholder query

Options
    • -3
    • +3
    /openacs-4/packages/new-portal/tcl/portal-callback-procs.tcl
3:28 pm

antoniop

Better initialize the datasource for those object that won't return the full set of expected fields

Options
    • -1
    • +4
    /openacs-4/packages/search/tcl/search-procs.tcl
3:16 pm

antoniop

Add missing return

Options
    • -1
    • +2
    /openacs-4/packages/search/tcl/search-convert-procs.tcl
3:16 pm

antoniop

Tolerate non-existing files, but throw a warning

Options
    • -1
    • +5
    /openacs-4/packages/search/tcl/search-convert-procs.tcl
2:20 pm

gustafn

removed deprecated "ns_set new" by "ns_set create"

Options
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/html-email-procs.tcl
    • -19
    • +4
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
2:18 pm

gustafn

moved stuff for AOLserver 2 emulation to deprecated procs, mark it explicitly as deprecated

Options
    • -173
    • +0
    /openacs-4/packages/acs-tcl/tcl/aolserver-3-procs.tcl
    • -3
    • +179
    /openacs-4/packages/acs-tcl/tcl/deprecated-procs.tcl
Thursday 21 Nov
5:34 pm

antoniop

Allow HTML in the default value for parameters, as this could contain markup, e.g. , if the value is some kind of snippet.

Options
    • -2
    • +2
    /openacs-4/packages/acs-admin/www/apm/parameter-edit-2.tcl
3:51 pm

antoniop

Further collect callback logics into procs and test them

Options
    • -2
    • +2
    /openacs-4/packages/search/search.info
    • -4
    • +44
    /openacs-4/packages/search/tcl/search-procs.tcl
    • -1
    • +18
    /openacs-4/packages/search/tcl/test/search-procs.tcl
    • -21
    • +13
    /openacs-4/packages/search/www/search.tcl
2:27 pm

antoniop

Further cleanup of the indexer logics

- unindexing an object in an own proc

- clarified idioms

- cleanup redundant operations

Options
    • -56
    • +60
    /openacs-4/packages/search/tcl/search-procs.tcl
    • -0
    • +5
    /openacs-4/packages/search/tcl/test/search-procs.tcl
1:49 pm

antoniop

Claim coverage, bump version number

Options
    • -2
    • +2
    /openacs-4/packages/search/search.info
    • -2
    • +2
    /openacs-4/packages/search/tcl/test/search-procs.tcl
1:47 pm

antoniop

Factor some of the logic in the indexer into own procs for the purpose of:

- being able to tell programmatically if an object can be indexed

- being able to index an object programmatically using a simpler api

- better test operations

Options
    • -87
    • +126
    /openacs-4/packages/search/tcl/search-procs.tcl
    • -0
    • +42
    /openacs-4/packages/search/tcl/test/search-procs.tcl
Wednesday 20 Nov
4:33 pm

antoniop

Rework file-to-text conversion with the goal of:

- also for LibreOffice documents, strip the XML from extracted content

- handle errors all at once outside the switch, as the behavior would always be the same

- avoid creating a tempfile

Options
    • -142
    • +125
    /openacs-4/packages/search/tcl/search-convert-procs.tcl
Thursday 14 Nov
6:01 pm

antoniop

Fix more confusion

Options
    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/resource-info-procs.tcl
5:54 pm

antoniop

Fix rather confusing name of javascript library file

Options
    • -3
    • +3
    /openacs-4/packages/xowiki/tcl/resource-info-procs.tcl
1:02 pm

antoniop

Ensure the namespace exists for template::form::export

Options
    • -1
    • +4
    /openacs-4/packages/acs-templating/tcl/deprecated-procs.tcl
Wednesday 13 Nov
6:36 pm

gustafn

Fixed runtime error, when "ns_cache" is viewed over the API browser

The problem was the method "flush", which is implemented via

alias to ::ns_cache__flush. In this case, "ns_cache info lookup syntax flush"

fails, because "info parameter" fails on the alias in command:

"::nsf::cmd::info parameter -context ::ns_cache ::ns_cache::flush"

Options
    • -1
    • +30
    /openacs-4/packages/acs-api-browser/tcl/acs-api-documentation-procs.tcl
    • -3
    • +13
    /openacs-4/packages/xotcl-core/tcl/03-doc-procs.tcl
9:43 am

gustafn

prefer more efficient approach to iterate over all key/values of an ns_set

Options
    • -18
    • +5
    /openacs-4/packages/acs-tcl/tcl/tcl-documentation-procs.tcl
9:42 am

gustafn

use case-insensitive access to configuration values

Options
    • -2
    • +5
    /openacs-4/packages/oacs-dav/tcl/tDAV-procs.tcl
9:41 am

gustafn

prefer more efficient "ns_set array" over single item ns_set access

Options
    • -23
    • +16
    /openacs-4/packages/acs-templating/tcl/tag-procs.tcl
9:40 am

gustafn

use consistently case-insensitive access to attributes of tags

Options
    • -2
    • +2
    /openacs-4/packages/acs-templating/tcl/parse-procs.tcl
    • -1
    • +1
    /openacs-4/packages/acs-templating/tcl/tab-procs.tcl
    • -11
    • +9
    /openacs-4/packages/acs-templating/tcl/tag-init.tcl
9:36 am

gustafn

moved deprecated proc to deprecated-procs.tcl

Options
    • -1
    • +31
    /openacs-4/packages/acs-templating/tcl/deprecated-procs.tcl
    • -31
    • +1
    /openacs-4/packages/acs-templating/tcl/form-procs.tcl
9:34 am

gustafn

documentation update: advertise more efficient and recent idiom

Options
    • -4
    • +3
    /openacs-4/packages/acs-core-docs/www/xml/developers-guide/programming-with-aolserver.xml
    • -3
    • +3
    /openacs-4/packages/acs-core-docs/www/xml/kernel/db-api.xml
Thursday 07 Nov
12:54 pm

antoniop

Extend user_message feature so that a "severity" information can be passed alongside the message

This allows theme templates to color code messages according to their severity. Severity follows the Bootstrap nomenclature of "info", "success", "warning" and "danger".

Default severity has been set to "success" consistent with styling applied so far by OpenACS to the user messages.

Options
    • -3
    • +3
    /openacs-4/packages/acs-tcl/acs-tcl.info
    • -4
    • +14
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
    • -5
    • +4
    /openacs-4/packages/openacs-bootstrap3-theme/openacs-bootstrap3-theme.info
    • -1
    • +1
    /openacs-4/packages/openacs-bootstrap3-theme/resources/masters/plain-master.adp
    • -5
    • +4
    /openacs-4/packages/openacs-bootstrap5-theme/openacs-bootstrap5-theme.info
    • -1
    • +1
    /openacs-4/packages/openacs-bootstrap5-theme/resources/masters/plain-master.adp
    • -3
    • +4
    /openacs-4/packages/openacs-default-theme/openacs-default-theme.info
    • -1
    • +1
    /openacs-4/packages/openacs-default-theme/lib/plain-master.adp
    • -10
    • +27
    /openacs-4/packages/openacs-default-theme/www/resources/styles/default-master.css
Wednesday 06 Nov
4:51 pm

antoniop

Bring existing doc into the object's documentation, so that tests would not fail...

Options
    • -8
    • +9
    /openacs-4/packages/acs-subsite/tcl/group-init.tcl
    • -16
    • +20
    /openacs-4/packages/xowf/tcl/iprange-init.tcl
1:59 pm

antoniop

Deprecate template::list::csv_quote and replace its usages in packages that we have been supporting

Options
    • -2
    • +6
    /openacs-4/packages/acs-templating/tcl/list-procs.tcl
    • -16
    • +14
    /openacs-4/packages/contacts/www/admin/full-organizations.tcl
    • -15
    • +14
    /openacs-4/packages/contacts/www/admin/full-people.tcl
    • -12
    • +10
    /openacs-4/packages/contacts/www/admin/full-rels.tcl
1:37 pm

antoniop

Introduce a new "label_headers" flag for template::list::write_csv that allows to revert to behavior before https://cvs.openacs.org/changelog/OpenACS?cs=MAIN%3Adaveb%3A20080908165252, e.g. use the column names as headers rather than the labels

For some use cases is in fact more useful to have machine-readable headers, e.g. when processing the csv via software

Options
    • -2
    • +11
    /openacs-4/packages/acs-templating/tcl/list-procs.tcl
1:18 pm

antoniop

Rely on the csv Tcllib package to generate a csv from a template::list

Options
    • -7
    • +12
    /openacs-4/packages/acs-templating/tcl/list-procs.tcl